cadonna commented on code in PR #15790:
URL: https://github.com/apache/kafka/pull/15790#discussion_r1620256284
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java:
##########
@@ -58,8 +60,21 @@ public void addChild(final ProcessorNode<Void, Void, ?, ?>
child) {
public void init(final InternalProcessorContext<Void, Void> context) {
super.init(context);
this.context = context;
- keySerializer = prepareKeySerializer(keySerializer, context,
this.name());
- valSerializer = prepareValueSerializer(valSerializer, context,
this.name());
+ try {
+ keySerializer = prepareKeySerializer(keySerializer, context,
this.name());
+ } catch (final ConfigException e) {
+ throw new ConfigException(String.format("Failed to initialize key
serdes for sink node %s", name()));
+ } catch (final StreamsException e) {
Review Comment:
Why `RuntimeException`? Can't we catch `ConfigException` and
`StreamsException` in one catch clause and then throw a `StreamsException`.
This seems safer to me, because otherwise with future code changes that might
throw exceptions like `IllegalStateException` we would wrap unexpected
exception due to mistakes in Streams in `StreamsException`.
```java
catch (final ConfigException | final StreamsException ex) {
// handle the exception
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
