chia7712 commented on code in PR #16062: URL: https://github.com/apache/kafka/pull/16062#discussion_r1620696237
########## clients/src/test/java/org/apache/kafka/common/ClusterTest.java: ########## @@ -89,4 +92,74 @@ public void testReturnUnmodifiableCollections() { new PartitionInfo(TOPIC_B, 2, NODES[1], NODES, NODES))); } + @Test + public void testNotEquals() { + String clusterId1 = "clusterId1"; + String clusterId2 = "clusterId2"; + Node node0 = new Node(0, "host0", 100); + Node node1 = new Node(1, "host1", 100); + Set<PartitionInfo> partitions1 = Collections.singleton(new PartitionInfo("topic1", 0, node0, new Node[]{node0, node1}, new Node[]{node0})); + Set<PartitionInfo> partitions2 = Collections.singleton(new PartitionInfo("topic2", 0, node0, new Node[]{node1, node0}, new Node[]{node1})); + Set<String> unauthorizedTopics1 = Collections.singleton("topic1"); + Set<String> unauthorizedTopics2 = Collections.singleton("topic2"); + Set<String> invalidTopics1 = Collections.singleton("topic1"); + Set<String> invalidTopics2 = Collections.singleton("topic2"); + Set<String> internalTopics1 = Collections.singleton("topic3"); + Set<String> internalTopics2 = Collections.singleton("topic4"); + Node controller1 = node0; Review Comment: ditto. Could you please generate new node object? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org