dajac commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1620735975


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##########
@@ -293,14 +295,22 @@ public TargetAssignmentBuilder removeMember(
      * @throws PartitionAssignorException if the target assignment cannot be 
computed.
      */
     public TargetAssignmentResult build() throws PartitionAssignorException {
-        Map<String, AssignmentMemberSpec> memberSpecs = new HashMap<>();
+        Map<String, MemberSubscriptionSpec> memberSpecs = new HashMap<>();
+        Map<String, Map<Uuid, Set<Integer>>> currentTargetAssignment = new 
HashMap<>(members.size());

Review Comment:
   For the time being, I wonder if we could keep the assignment into the 
`MemberSubscriptionSpecImpl` (not in the interface) and pass 
`MemberSubscriptionSpecImpl` to the `GroupSpecImpl`. Would it work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to