[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14132: -- Description: {color:#de350b}Some of the tests below use EasyMock as well. For those migrate b

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

vamossagar12 commented on code in PR #13127: URL: https://github.com/apache/kafka/pull/13127#discussion_r1083769752 ## build.gradle: ## @@ -1757,6 +1757,7 @@ project(':tools') { archivesBaseName = "kafka-tools" dependencies { +implementation project(':core') Review

[GitHub] [kafka] vamossagar12 commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

vamossagar12 commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1399976298 Thanks @fvaleri . LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679729#comment-17679729 ] A. Sophie Blee-Goldman commented on KAFKA-14533: Not sure why this is ha

[GitHub] [kafka] ableegoldman commented on pull request #13147: MINOR: temporarily disable the 'false' parameter of SmokeTestDriverIntegrationTest

ableegoldman commented on PR #13147: URL: https://github.com/apache/kafka/pull/13147#issuecomment-1400043590 cc @lucasbru @guozhangwang @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679735#comment-17679735 ] A. Sophie Blee-Goldman commented on KAFKA-14533: https://github.com/apac

[GitHub] [kafka] ableegoldman opened a new pull request, #13147: MINOR: temporarily disable the 'false' parameter of SmokeTestDriverIntegrationTest

ableegoldman opened a new pull request, #13147: URL: https://github.com/apache/kafka/pull/13147 Need to get a clean build for 3.4 and this test has been extremely flaky. I'm looking into the failure as well, and want to pinpoint whether it's the `true` build that's broken or it's the parame

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1083847838 ## clients/src/main/java/org/apache/kafka/common/compress/ZstdFactory.java: ## @@ -26,21 +26,25 @@ import org.apache.kafka.common.utils.ByteBufferInputStream; imp

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1083831592 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java: ## @@ -273,20 +272,32 @@ public int partitionLeaderEpoch() { public DataInputS

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1083852068 ## clients/src/main/java/org/apache/kafka/common/record/CompressionType.java: ## @@ -47,6 +47,11 @@ public OutputStream wrapForOutput(ByteBufferOutputStream buffer

[jira] [Commented] (KAFKA-14583) Move ReplicaVerificationTool to tools

[ https://issues.apache.org/jira/browse/KAFKA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679749#comment-17679749 ] Federico Valeri commented on KAFKA-14583: - I think we should migrate TopicFilter

[GitHub] [kafka] clolov commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

clolov commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083906152 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] clolov commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

clolov commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083909966 ## core/src/main/scala/kafka/tools/ConsoleConsumer.scala: ## @@ -352,9 +353,11 @@ object ConsoleConsumer extends Logging { } else if (options.has(offsetOpt))

[GitHub] [kafka] clolov commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

clolov commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083920980 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] clolov commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

clolov commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083920980 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] clolov commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

clolov commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083920980 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] clolov commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

clolov commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083906152 ## server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java: ## @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] mimaison commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

mimaison commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r1083928100 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -169,6 +172,7 @@ public String version() { return listConsume

[GitHub] [kafka] clolov commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

clolov commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1083908982 ## core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala: ## @@ -100,6 +101,7 @@ object ZkSecurityMigrator extends Logging { false case _ =>

[GitHub] [kafka] clolov commented on pull request #10826: KAFKA-7632: Support Compression Level

clolov commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1400189273 Hello @dongjinleekr! What is the current state of this pull request? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] mimaison merged pull request #13059: MINOR: KafkaConfig should not expose internal config when queried for non-internal values

mimaison merged PR #13059: URL: https://github.com/apache/kafka/pull/13059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mimaison merged pull request #13094: MINOR: Various cleanups in client tests

mimaison merged PR #13094: URL: https://github.com/apache/kafka/pull/13094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] fvaleri commented on a diff in pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

fvaleri commented on code in PR #13131: URL: https://github.com/apache/kafka/pull/13131#discussion_r1084030517 ## core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala: ## @@ -100,6 +101,7 @@ object ZkSecurityMigrator extends Logging { false case _ =>

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1084093810 ## clients/src/main/java/org/apache/kafka/common/compress/ZstdFactory.java: ## @@ -62,10 +68,11 @@ public void release(ByteBuffer buffer) { }

[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

[ https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679805#comment-17679805 ] Mickael Maison commented on KAFKA-14579: Since this depends on a bunch of log la

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1084097512 ## clients/src/main/java/org/apache/kafka/common/compress/ZstdFactory.java: ## @@ -62,10 +68,11 @@ public void release(ByteBuffer buffer) { }

[GitHub] [kafka] divijvaidya commented on pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on PR #13135: URL: https://github.com/apache/kafka/pull/13135#issuecomment-1400407941 TODO (will update PR in a short while) - 1. Add benchmark for case when batch contains single 10 byte message 2. Test consumer performance -- This is an automated mess

[jira] [Comment Edited] (KAFKA-14579) Move DumpLogSegments to tools

[ https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679147#comment-17679147 ] Federico Valeri edited comment on KAFKA-14579 at 1/23/23 2:32 PM:

[GitHub] [kafka] C0urante commented on pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

C0urante commented on PR #12561: URL: https://github.com/apache/kafka/pull/12561#issuecomment-1400491466 @vamossagar12 I don't think it's necessary to call this out anywhere unless it's caused unexpected issues with our users. The intention behind the exponential backoff is to avoid rebalan

[jira] [Created] (KAFKA-14645) Plugin classloader not used when retrieving connector plugin config defs via REST API

Chris Egerton created KAFKA-14645: - Summary: Plugin classloader not used when retrieving connector plugin config defs via REST API Key: KAFKA-14645 URL: https://issues.apache.org/jira/browse/KAFKA-14645

[GitHub] [kafka] C0urante opened a new pull request, #13148: KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions

C0urante opened a new pull request, #13148: URL: https://github.com/apache/kafka/pull/13148 [Jira](https://issues.apache.org/jira/browse/KAFKA-14645) If we don't switch to the classloader of a plugin before loading its `ConfigDef`, then classloading bugs can appear for, e.g., properti

[GitHub] [kafka] C0urante commented on a diff in pull request #13148: KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions

C0urante commented on code in PR #13148: URL: https://github.com/apache/kafka/pull/13148#discussion_r1084283540 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -821,13 +827,14 @@ public List connectorPluginConfig(String pluginName) {

[jira] [Commented] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679899#comment-17679899 ] Bojan Blagojevic commented on KAFKA-14639: -- Thank you [~ableegoldman] for the q

[GitHub] [kafka] ijuma commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

ijuma commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1084344515 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java: ## @@ -273,20 +272,32 @@ public int partitionLeaderEpoch() { public DataInputStream

[GitHub] [kafka] ijuma commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

ijuma commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1084344515 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java: ## @@ -273,20 +272,32 @@ public int partitionLeaderEpoch() { public DataInputStream

[GitHub] [kafka] ijuma commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

ijuma commented on code in PR #12781: URL: https://github.com/apache/kafka/pull/12781#discussion_r1084369349 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java: ## @@ -98,7 +98,7 @@ private Optional> producer; private TopicAdmin admin;

[jira] [Created] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

Jochen Schalanda created KAFKA-14646: Summary: SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2) Key: KAFKA-14646 URL: https://issues.apache.org/jira/browse/KAFKA-14646

[jira] [Updated] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Schalanda updated KAFKA-14646: - Description: Hey folks,   we've just updated an application from *_Kafka Streams 3.2.3 t

[jira] [Updated] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Schalanda updated KAFKA-14646: - Description: Hey folks,   we've just updated an application from *_Kafka Streams 3.2.3 t

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1082994727 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -0,0 +1,523 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] erichaagdev opened a new pull request, #13149: Remove unnecessary asCollection causing eager dependency resolution

erichaagdev opened a new pull request, #13149: URL: https://github.com/apache/kafka/pull/13149 The call to `asCollection()` causes several configurations to be resolved eagerly, and potentially unnecessarily. Dropping `asCollection()` ensures the configurations are only resolved when they a

[GitHub] [kafka] cmccabe commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

cmccabe commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1084419497 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -392,14 +394,36 @@ class ControllerApis(val requestChannel: RequestChannel, val describableTopicNam

[GitHub] [kafka] cmccabe commented on pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

cmccabe commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1400816232 > Also note that I didn't implement the full logic -- QuorumController has additional checks that could in fact cause a specific topic request to be rejected (e.g. explicit assignments no

[GitHub] [kafka] C0urante commented on a diff in pull request #13144: KAFKA-14463 Invoke of ConnectorClientConfigOverridePolicy#close

C0urante commented on code in PR #13144: URL: https://github.com/apache/kafka/pull/13144#discussion_r1084433485 ## connect/runtime/src/test/java/org/apache/kafka/connect/connector/policy/BaseConnectorClientConfigOverridePolicyTest.java: ## @@ -27,7 +27,7 @@ public abstract cl

[GitHub] [kafka] C0urante merged pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

C0urante merged PR #12802: URL: https://github.com/apache/kafka/pull/12802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-14311) Connect Worker clean shutdown does not cleanly stop connectors/tasks

[ https://issues.apache.org/jira/browse/KAFKA-14311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14311: -- Fix Version/s: 3.5.0 > Connect Worker clean shutdown does not cleanly stop connectors/tasks >

[jira] [Resolved] (KAFKA-14311) Connect Worker clean shutdown does not cleanly stop connectors/tasks

[ https://issues.apache.org/jira/browse/KAFKA-14311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14311. --- Resolution: Fixed > Connect Worker clean shutdown does not cleanly stop connectors/tasks > -

[jira] [Commented] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679991#comment-17679991 ] Matthias J. Sax commented on KAFKA-14646: - Did you upgrade with two rolling boun

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13137: KAFKA-15086: Intra-cluster communication for Mirror Maker 2

gharris1727 commented on code in PR #13137: URL: https://github.com/apache/kafka/pull/13137#discussion_r1084435808 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -228,12 +229,17 @@ public class DistributedHerder extend

[jira] [Comment Edited] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679991#comment-17679991 ] Matthias J. Sax edited comment on KAFKA-14646 at 1/23/23 7:21 PM:

[jira] [Commented] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679993#comment-17679993 ] Chris Egerton commented on KAFKA-14565: --- [~beardt] It's close, but the {{AbstractC

[GitHub] [kafka] C0urante commented on a diff in pull request #13137: KAFKA-15086: Intra-cluster communication for Mirror Maker 2

C0urante commented on code in PR #13137: URL: https://github.com/apache/kafka/pull/13137#discussion_r1084460160 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -228,12 +229,17 @@ public class DistributedHerder extends A

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13138: MINOR: Small cleanups in refactored consumer implementation

guozhangwang commented on code in PR #13138: URL: https://github.com/apache/kafka/pull/13138#discussion_r1084463267 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -149,11 +156,14 @@ private void onSuccessfulResponse(fin

[GitHub] [kafka] philipnee commented on pull request #13125: KAFKA-14626: Kafka Consumer Coordinator does not cleanup all metrics after shutdown

philipnee commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1400882904 hey @cmccabe - would you have time to take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Commented] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680003#comment-17680003 ] Terry Beard commented on KAFKA-14565: - [~ChrisEgerton]  I'm a noob when it comes to

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1084484753 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -0,0 +1,523 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] nizhikov closed pull request #12574: KAFKA-13908 Rethrow ExecutionException to preserve original cause

nizhikov closed pull request #12574: KAFKA-13908 Rethrow ExecutionException to preserve original cause URL: https://github.com/apache/kafka/pull/12574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

vcrfxia commented on code in PR #13126: URL: https://github.com/apache/kafka/pull/13126#discussion_r1084488305 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -0,0 +1,523 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] vcrfxia commented on pull request #13126: KAFKA-14491: [1/N] Add segment value format for RocksDB versioned store

vcrfxia commented on PR #13126: URL: https://github.com/apache/kafka/pull/13126#issuecomment-1400904752 Thanks for your reviews, @mjsax ! I pushed another commit just now to incorporate your latest suggestions (javadocs changes only) and responded inline to the main points of discussion. Th

[GitHub] [kafka] nizhikov commented on a diff in pull request #13144: KAFKA-14463 Invoke of ConnectorClientConfigOverridePolicy#close

nizhikov commented on code in PR #13144: URL: https://github.com/apache/kafka/pull/13144#discussion_r1084491140 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -227,9 +227,14 @@ public class DistributedHerderTest {

[GitHub] [kafka] nizhikov commented on pull request #13144: KAFKA-14463 Invoke of ConnectorClientConfigOverridePolicy#close

nizhikov commented on PR #13144: URL: https://github.com/apache/kafka/pull/13144#issuecomment-1400908925 @C0urante Thanks for the review. I've applied your suggestions. Please, take a look one more time. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: The Consumer and Producer interceptor interfaces and their corresponding Kafka Consu

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13120: MINOR: Connect Javadocs improvements

gharris1727 commented on code in PR #13120: URL: https://github.com/apache/kafka/pull/13120#discussion_r1084469223 ## connect/api/src/main/java/org/apache/kafka/connect/connector/policy/ConnectorClientConfigOverridePolicy.java: ## @@ -23,25 +23,25 @@ import java.util.List; /

[jira] [Commented] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680019#comment-17680019 ] Jochen Schalanda commented on KAFKA-14646: -- {quote}Did you upgrade with two rol

[GitHub] [kafka] hachikuji commented on a diff in pull request #13138: MINOR: Small cleanups in refactored consumer implementation

hachikuji commented on code in PR #13138: URL: https://github.com/apache/kafka/pull/13138#discussion_r1084522285 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -149,11 +156,14 @@ private void onSuccessfulResponse(final

[jira] [Comment Edited] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680019#comment-17680019 ] Jochen Schalanda edited comment on KAFKA-14646 at 1/23/23 8:39 PM: ---

[GitHub] [kafka] hachikuji commented on a diff in pull request #13138: MINOR: Small cleanups in refactored consumer implementation

hachikuji commented on code in PR #13138: URL: https://github.com/apache/kafka/pull/13138#discussion_r1084522285 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -149,11 +156,14 @@ private void onSuccessfulResponse(final

[GitHub] [kafka] hachikuji merged pull request #13138: MINOR: Small cleanups in refactored consumer implementation

hachikuji merged PR #13138: URL: https://github.com/apache/kafka/pull/13138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: The Consumer and Producer interceptor interfaces and their corresponding Kafka Consu

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Labels: (was: needs-kip) > Improve Interceptor Resource Leakage Prevention > ---

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: The Consumer and Producer interceptor interfaces and their corresponding Kafka Consu

[jira] [Updated] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Terry Beard updated KAFKA-14565: Description: The Consumer and Producer interceptor interfaces and their corresponding Kafka Consu

[GitHub] [kafka] C0urante commented on a diff in pull request #12984: KAFKA-14455: Kafka Connect create and update REST APIs should surface failures while writing to the config topic

C0urante commented on code in PR #12984: URL: https://github.com/apache/kafka/pull/12984#discussion_r1084555816 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -711,9 +742,9 @@ KafkaBasedLog setupAndCreateKafkaBasedLog(Strin

[GitHub] [kafka] anshvnm opened a new pull request, #13150: MINOR: Add new functions to client example Producer for sending messages to multiple topics, with key, and timestamp

anshvnm opened a new pull request, #13150: URL: https://github.com/apache/kafka/pull/13150 This pull request adds new functions to the Producer.java file in the examples directory to provide more flexibility for clients using Kafka. The `sendToMultipleTopics` method allows clients to send a

[GitHub] [kafka] rondagostino merged pull request #13118: MINOR: fix some typos in comments/docs/variable names

rondagostino merged PR #13118: URL: https://github.com/apache/kafka/pull/13118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Commented] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680042#comment-17680042 ] Matthias J. Sax commented on KAFKA-14646: - Thanks for following up – glad to hea

[GitHub] [kafka] ahuang98 opened a new pull request, #13151: Fail broker and controller startup on authorizer failure

ahuang98 opened a new pull request, #13151: URL: https://github.com/apache/kafka/pull/13151 If any authorizer fails to start up, we should also fail to start up the broker or controller *More detailed description of your change, if necessary. The PR title and PR message become t

[GitHub] [kafka] rondagostino commented on pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1401088949 Thanks, Colin. That all makes sense. The KIP indicates that `validateOnly` is not throttled because it does not load the controller (https://cwiki.apache.org/confluence/display/KAF

[GitHub] [kafka] kirktrue opened a new pull request, #13152: KAFKA-14365 refactor fetcher, take 4

kirktrue opened a new pull request, #13152: URL: https://github.com/apache/kafka/pull/13152 WIP. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] cmccabe opened a new pull request, #13153: MINOR: startup timeouts for KRaft integration tests

cmccabe opened a new pull request, #13153: URL: https://github.com/apache/kafka/pull/13153 When running junit tests, it is not good to block forever on CompletableFuture objects. When there are bugs, this can lead to junit tests hanging forever. Jenkins does not deal with this well -- it o

[GitHub] [kafka] jsancio opened a new pull request, #13154: MINOR; Make granting voter immutable

jsancio opened a new pull request, #13154: URL: https://github.com/apache/kafka/pull/13154 Make LeaderState's grantingVoters field explicitly immutable. The set of voters that granted their voter to the current leader was already immutable. This change makes that explicit. ### Commit

[GitHub] [kafka] ableegoldman merged pull request #13147: KAFKA-14533: temporarily disable the 'false' parameter of SmokeTestDriverIntegrationTest

ableegoldman merged PR #13147: URL: https://github.com/apache/kafka/pull/13147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[GitHub] [kafka] ableegoldman opened a new pull request, #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest

ableegoldman opened a new pull request, #13155: URL: https://github.com/apache/kafka/pull/13155 Doing the PR to re-enable the test build that I temporarily disabled in https://github.com/apache/kafka/pull/13147 in order to help with debugging and to stabilize the 3.4 release branch.

[GitHub] [kafka] ableegoldman commented on a diff in pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest

ableegoldman commented on code in PR #13155: URL: https://github.com/apache/kafka/pull/13155#discussion_r1084678438 ## streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java: ## @@ -96,9 +96,8 @@ SmokeTestDriver.VerificationResult result()

[GitHub] [kafka] ableegoldman commented on pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest

ableegoldman commented on PR #13155: URL: https://github.com/apache/kafka/pull/13155#issuecomment-1401152718 cc @lucasbru @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Comment Edited] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679735#comment-17679735 ] A. Sophie Blee-Goldman edited comment on KAFKA-14533 at 1/23/23 11:37 PM:

[GitHub] [kafka] philipnee commented on pull request #13125: KAFKA-14626: Kafka Consumer Coordinator does not cleanup all metrics after shutdown

philipnee commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1401162257 Thanks @guozhangwang - A comment I have here is, would it be more convenient to close/remove all the metrics and sensors in the Metrics class upon closing instead of relying on these su

[GitHub] [kafka] guozhangwang commented on pull request #13125: KAFKA-14626: Kafka Consumer Coordinator does not cleanup all metrics after shutdown

guozhangwang commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1401212144 The concern I had is that, the same metrics registry object is used across multiple nested classes, while some of those classes may be closed and re-created along the lifetime of the

[GitHub] [kafka] C0urante merged pull request #13144: KAFKA-14463 Invoke of ConnectorClientConfigOverridePolicy#close

C0urante merged PR #13144: URL: https://github.com/apache/kafka/pull/13144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-14647) Move TopicFilter shared class

[ https://issues.apache.org/jira/browse/KAFKA-14647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14647: - Assignee: Sagar Rao (was: Federico Valeri) > Move TopicFilter shared class > -

[jira] [Created] (KAFKA-14647) Move TopicFilter shared class

Sagar Rao created KAFKA-14647: - Summary: Move TopicFilter shared class Key: KAFKA-14647 URL: https://issues.apache.org/jira/browse/KAFKA-14647 Project: Kafka Issue Type: Sub-task Repo

[jira] [Commented] (KAFKA-14647) Move TopicFilter shared class

[ https://issues.apache.org/jira/browse/KAFKA-14647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680081#comment-17680081 ] Sagar Rao commented on KAFKA-14647: --- Move TopicFilter in core/kafka/utils to server-co

[jira] [Commented] (KAFKA-14583) Move ReplicaVerificationTool to tools

[ https://issues.apache.org/jira/browse/KAFKA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680082#comment-17680082 ] Sagar Rao commented on KAFKA-14583: --- Thanks Federico. Created this ticket for tracking

[GitHub] [kafka] mjsax commented on a diff in pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest

mjsax commented on code in PR #13155: URL: https://github.com/apache/kafka/pull/13155#discussion_r1084789144 ## streams/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java: ## @@ -96,9 +96,8 @@ SmokeTestDriver.VerificationResult result() {

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680083#comment-17680083 ] ASF GitHub Bot commented on KAFKA-13882: mjsax commented on PR #410: URL: https:

[jira] [Commented] (KAFKA-12360) Improve documentation of max.task.idle.ms (kafka-streams)

[ https://issues.apache.org/jira/browse/KAFKA-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680086#comment-17680086 ] ASF GitHub Bot commented on KAFKA-12360: mjsax commented on PR #333: URL: https:

[jira] [Commented] (KAFKA-12360) Improve documentation of max.task.idle.ms (kafka-streams)

[ https://issues.apache.org/jira/browse/KAFKA-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680087#comment-17680087 ] ASF GitHub Bot commented on KAFKA-12360: mjsax closed pull request #333: Added d

[GitHub] [kafka] mjsax commented on a diff in pull request #13142: KAFKA-14491: [2/N] Refactor RocksDB store open iterator management

mjsax commented on code in PR #13142: URL: https://github.com/apache/kafka/pull/13142#discussion_r1084826103 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java: ## @@ -114,6 +114,7 @@ public class RocksDBStore implements KeyValueStore, BatchWriti

[GitHub] [kafka] mjsax commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

mjsax commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1084834388 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (AS