C0urante opened a new pull request, #13148:
URL: https://github.com/apache/kafka/pull/13148

   [Jira](https://issues.apache.org/jira/browse/KAFKA-14645)
   
   If we don't switch to the classloader of a plugin before loading its 
`ConfigDef`, then classloading bugs can appear for, e.g., properties with the 
`CLASS` type. See https://github.com/kcctl/kcctl/issues/266 for an instance of 
this kind of bug.
   
   This PR adds a classloader swap in the part of the code base that's 
responsible for servicing requests to the `GET 
/connector-plugins/<type>/config` endpoint.
   
   The existing monolithic unit test for this logic is broken out into 
dedicated individual unit tests for each kind of connector plugin; this is done 
to avoid having to reset expectations on the mocked `Plugins` object when 
verifying calls to `withClassLoader`, since in the unit testing environment the 
same classloader may be used for multiple different plugin types.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to