gharris1727 commented on code in PR #13137:
URL: https://github.com/apache/kafka/pull/13137#discussion_r1084435808
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -228,12 +229,17 @@ public class DistributedHerder extends AbstractHerder
implements Runnable {
* @param kafkaClusterId the identifier of the Kafka cluster to use
for internal topics; may not be null
* @param statusBackingStore the backing store for statuses; may not be
null
* @param configBackingStore the backing store for connector
configurations; may not be null
- * @param restUrl the URL of this herder's REST API; may not be
null
+ * @param restUrl the URL of this herder's REST API; may not be
null, but may be an arbitrary placeholder
+ * value if this worker does not expose a REST
API
+ * @param restClient a REST client that can be used to issue
requests to other workers in the cluster; may
+ * be null if inter-worker communication is not
enabled
* @param connectorClientConfigOverridePolicy the policy specifying the
client configuration properties that may be overridden
* in connector configurations;
may not be null
+ * @param restNamespace zero or more path elements to prepend to the
paths of forwarded REST requests; may be empty, but not null
* @param uponShutdown any {@link AutoCloseable} objects that should
be closed when this herder is {@link #stop() stopped},
* after all services and resources owned by
this herder are stopped
*/
+ // TODO: Do we really need two separate public constructors?
Review Comment:
interesting, the for-testing constructor appears unused, and has been for as
long as it's existed (ever since #321).
We can push this refactor out to a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
