philipnee commented on PR #13125: URL: https://github.com/apache/kafka/pull/13125#issuecomment-1401162257
Thanks @guozhangwang - A comment I have here is, would it be more convenient to close/remove all the metrics and sensors in the Metrics class upon closing instead of relying on these sub metrics to remove the metrics/sensors? It seems fine to just remove the registered sensros and metrics upon closing the Metrics obj. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org