[GitHub] [kafka] cadonna commented on a diff in pull request #12583: KAFKA-10199: Separate state updater from old restore

2022-09-07 Thread GitBox
cadonna commented on code in PR #12583: URL: https://github.com/apache/kafka/pull/12583#discussion_r964458919 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -685,6 +691,7 @@ private void recycleTask(final Task task,

[GitHub] [kafka] showuon commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
showuon commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r964493272 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -520,6 +554,9 @@ protected void handleLostAssign

[GitHub] [kafka] divijvaidya commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-07 Thread GitBox
divijvaidya commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1239064326 Test failures are unrelated. @showuon this is ready for your review. Test failures: ``` [2022-09-06T16:49:33.427Z] org.apache.kafka.controller.QuorumControllerTest.testEar

[GitHub] [kafka] cadonna commented on a diff in pull request #12492: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-07 Thread GitBox
cadonna commented on code in PR #12492: URL: https://github.com/apache/kafka/pull/12492#discussion_r964500209 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatTransformTest.java: ## @@ -68,71 +76,59 @@ public void shouldTransformInputRecordToMultip

[GitHub] [kafka] cadonna commented on pull request #12492: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-07 Thread GitBox
cadonna commented on PR #12492: URL: https://github.com/apache/kafka/pull/12492#issuecomment-1239066227 Build failures are unrelated: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders() Build / JDK 8 and Scala 2.12 / or

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-07 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r964537055 ## clients/src/main/java/org/apache/kafka/common/requests/FetchMetadata.java: ## @@ -114,9 +114,21 @@ public boolean equals(Object o) { } /** - * Ret

[GitHub] [kafka] cadonna merged pull request #12492: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-09-07 Thread GitBox
cadonna merged PR #12492: URL: https://github.com/apache/kafka/pull/12492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-07 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r964541075 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1798,15 +1802,27 @@ private void consumerCloseTest(final long closeTimeout

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-07 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r964546851 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1933,11 +1941,76 @@ private Map topicPartitionTags(TopicPartition tp) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

2022-09-07 Thread GitBox
divijvaidya commented on code in PR #12590: URL: https://github.com/apache/kafka/pull/12590#discussion_r964548929 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2403,17 +2404,40 @@ private ClusterResourceListeners configureClusterResourceL

[GitHub] [kafka] dajac opened a new pull request, #12598: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID

2022-09-07 Thread GitBox
dajac opened a new pull request, #12598: URL: https://github.com/apache/kafka/pull/12598 The consumer group instance ID is used to support a notion of "static" consumer groups. The idea is to be able to identify the same group instance across restarts so that a rebalance is not needed. Howe

[GitHub] [kafka] dajac commented on pull request #12598: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID

2022-09-07 Thread GitBox
dajac commented on PR #12598: URL: https://github.com/apache/kafka/pull/12598#issuecomment-1239094026 @hachikuji What do you think about doing something like this? I was debating wether ignoring the member id as well is a good thing or not in this case. That seems to be acceptable. -- T

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r964585809 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -520,6 +554,9 @@ protected void handleLostA

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r964585809 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -520,6 +554,9 @@ protected void handleLostA

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r964585809 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -520,6 +554,9 @@ protected void handleLostA

[GitHub] [kafka] dajac opened a new pull request, #12599: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID

2022-09-07 Thread GitBox
dajac opened a new pull request, #12599: URL: https://github.com/apache/kafka/pull/12599 The consumer group instance ID is used to support a notion of "static" consumer groups. The idea is to be able to identify the same group instance across restarts so that a rebalance is not needed. Howe

[GitHub] [kafka] showuon commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
showuon commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r964643605 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -520,6 +554,9 @@ protected void handleLostAssign

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r964690356 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -118,6 +118,152 @@ public void testTask

[GitHub] [kafka] cadonna commented on pull request #12583: KAFKA-10199: Separate state updater from old restore

2022-09-07 Thread GitBox
cadonna commented on PR #12583: URL: https://github.com/apache/kafka/pull/12583#issuecomment-1239316670 Build failures are unrelated: ``` Build / JDK 17 and Scala 2.13 / testLegacyAlterConfigs() – kafka.server.KRaftClusterTest Build / JDK 11 and Scala 2.13 / shouldNotMakeStoreAvail

[GitHub] [kafka] cadonna merged pull request #12583: KAFKA-10199: Separate state updater from old restore

2022-09-07 Thread GitBox
cadonna merged PR #12583: URL: https://github.com/apache/kafka/pull/12583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Assigned] (KAFKA-13631) Warning "Ignoring await stop request for non-present connector..." when shutting down connector via API in distributed mode

2022-09-07 Thread Anupam Aggarwal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anupam Aggarwal reassigned KAFKA-13631: --- Assignee: (was: Anupam Aggarwal) > Warning "Ignoring await stop request for non

[GitHub] [kafka] cadonna opened a new pull request, #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-07 Thread GitBox
cadonna opened a new pull request, #12600: URL: https://github.com/apache/kafka/pull/12600 In the first attempt to handle revoked tasks in the state updater we removed the revoked tasks from the state updater and added it to the set of pending tasks to close cleanly. This is not correct sin

[GitHub] [kafka] cadonna commented on pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-07 Thread GitBox
cadonna commented on PR #12600: URL: https://github.com/apache/kafka/pull/12600#issuecomment-1239332591 Call for review: @wcarlson5 @lihaosky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-07 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r964788770 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,120 @@ private void classifyTasksWithoutStateUpdater(final Ma

[jira] [Created] (KAFKA-14206) Upgrade zookeeper to 3.7.1 to address security vulnerabilities

2022-09-07 Thread Valeriy Kassenbayev (Jira)
Valeriy Kassenbayev created KAFKA-14206: --- Summary: Upgrade zookeeper to 3.7.1 to address security vulnerabilities Key: KAFKA-14206 URL: https://issues.apache.org/jira/browse/KAFKA-14206 Project:

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-07 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r964789596 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -786,17 +833,20 @@ private void handleRemovedTasksFromStateUpdater() {

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-07 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r964790082 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -817,14 +867,17 @@ private boolean handleRestoredTasksFromStateUpdater(fina

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-07 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r964790734 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TasksRegistry.java: ## @@ -55,6 +55,10 @@ public interface TasksRegistry { void addPendingTa

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-07 Thread GitBox
cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r964791407 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -250,32 +250,502 @@ public void shouldClassifyExistingTasksWithoutStat

[GitHub] [kafka] vamossagar12 commented on pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
vamossagar12 commented on PR #12561: URL: https://github.com/apache/kafka/pull/12561#issuecomment-1239339745 > LGTM! Thanks for the improvement! Thank you ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] cadonna commented on a diff in pull request #12465: KAFKA-12950: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

2022-09-07 Thread GitBox
cadonna commented on code in PR #12465: URL: https://github.com/apache/kafka/pull/12465#discussion_r964580803 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -252,10 +252,15 @@ State setState(final State newState) { public bo

[jira] [Commented] (KAFKA-13202) KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2022-09-07 Thread Kouame (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601314#comment-17601314 ] Kouame commented on KAFKA-13202: Hi how, can i add custom claim check, like strimzi-oaut

[GitHub] [kafka] mumrah commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
mumrah commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r964883785 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long, v

[GitHub] [kafka] mumrah commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
mumrah commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r964889986 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long, v

[GitHub] [kafka] vvcephei commented on a diff in pull request #12594: MINOR: Include all hosts in metadata for topology

2022-09-07 Thread GitBox
vvcephei commented on code in PR #12594: URL: https://github.com/apache/kafka/pull/12594#discussion_r964920274 ## streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java: ## @@ -924,8 +926,10 @@ private void verifyPartitionsAndStoresForTopolo

[GitHub] [kafka] C0urante commented on a diff in pull request #12478: KAFKA-13952 fix RetryWithToleranceOperator to respect infinite retries configuration

2022-09-07 Thread GitBox
C0urante commented on code in PR #12478: URL: https://github.com/apache/kafka/pull/12478#discussion_r964923239 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -199,116 +202,182 @@ private RetryWithToleranceOpera

[GitHub] [kafka] C0urante commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
C0urante commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r964939766 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -285,18 +292,13 @@ ClusterAssignment performTas

[GitHub] [kafka] C0urante commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
C0urante commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r964939766 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -285,18 +292,13 @@ ClusterAssignment performTas

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #12594: MINOR: Include all hosts in metadata for topology

2022-09-07 Thread GitBox
wcarlson5 commented on code in PR #12594: URL: https://github.com/apache/kafka/pull/12594#discussion_r964950624 ## streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java: ## @@ -422,6 +422,8 @@ public void shouldAddAndRemoveNamedTopologiesB

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #12594: MINOR: Include all hosts in metadata for topology

2022-09-07 Thread GitBox
wcarlson5 commented on code in PR #12594: URL: https://github.com/apache/kafka/pull/12594#discussion_r964956521 ## streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java: ## @@ -924,8 +926,10 @@ private void verifyPartitionsAndStoresForTopol

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #12594: MINOR: Include all hosts in metadata for topology

2022-09-07 Thread GitBox
wcarlson5 commented on code in PR #12594: URL: https://github.com/apache/kafka/pull/12594#discussion_r964956521 ## streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java: ## @@ -924,8 +926,10 @@ private void verifyPartitionsAndStoresForTopol

[GitHub] [kafka] jsancio commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
jsancio commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965006213 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long,

[GitHub] [kafka] mumrah commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
mumrah commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965015865 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long, v

[GitHub] [kafka] jsancio commented on pull request #12414: KAFKA-14073 Logging the reason for Snapshot

2022-09-07 Thread GitBox
jsancio commented on PR #12414: URL: https://github.com/apache/kafka/pull/12414#issuecomment-1239588238 > Hi @jsancio could you please review this PR? Sorry for the multiple changes this has required. Thanks for the changes and excuse the delays. LGTM in general. Restarted the build

[GitHub] [kafka] cmccabe merged pull request #12586: KAFKA-14200: kafka-features.sh must exit with non-zero error code on error

2022-09-07 Thread GitBox
cmccabe merged PR #12586: URL: https://github.com/apache/kafka/pull/12586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-14200) kafka-features.sh must exit with non-zero error code on error

2022-09-07 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14200. -- Reviewer: David Arthur Resolution: Fixed > kafka-features.sh must exit with non-zero err

[jira] [Commented] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-07 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601379#comment-17601379 ] Philip Nee commented on KAFKA-14196: Thanks Luke and GW, it looks like we could just

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
vamossagar12 commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r965066363 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -285,18 +292,13 @@ ClusterAssignment perfor

[GitHub] [kafka] ijuma opened a new pull request, #12601: MINOR: Retry on test failure for branch builds and increase max test retry to 10

2022-09-07 Thread GitBox
ijuma opened a new pull request, #12601: URL: https://github.com/apache/kafka/pull/12601 Originally, we only enabled retries for PR builds to avoid hiding timing related issues. In practice, however, the results are too noisy without any retry due to various environmental issues. Ena

[GitHub] [kafka] C0urante commented on a diff in pull request #12561: KAFKA-12495: Exponential backoff retry to prevent rebalance storms when worker joins after revoking rebalance

2022-09-07 Thread GitBox
C0urante commented on code in PR #12561: URL: https://github.com/apache/kafka/pull/12561#discussion_r965099882 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -285,18 +292,13 @@ ClusterAssignment performTas

[GitHub] [kafka] jsancio commented on a diff in pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

2022-09-07 Thread GitBox
jsancio commented on code in PR #12595: URL: https://github.com/apache/kafka/pull/12595#discussion_r965048542 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -844,6 +855,72 @@ public String toString() { } } +/** + * Appe

[GitHub] [kafka] jsancio commented on pull request #11783: KAFKA-14143: Exactly-once source connector system tests (KIP-618)

2022-09-07 Thread GitBox
jsancio commented on PR #11783: URL: https://github.com/apache/kafka/pull/11783#issuecomment-1239718375 @showuon I tried running the system tests twice in Confluent's infrastructure and we got some infrastructure issues in both cases. Feel free to merge this change and cherry pick it to 3.3

[jira] [Commented] (KAFKA-14198) Release package contains snakeyaml 1.30

2022-09-07 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601456#comment-17601456 ] Jose Armando Garcia Sancio commented on KAFKA-14198: Thanks. I'll ma

[jira] [Updated] (KAFKA-14198) Release package contains snakeyaml 1.30

2022-09-07 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14198: --- Fix Version/s: 3.3.0 > Release package contains snakeyaml 1.30 > ---

[jira] [Created] (KAFKA-14207) Add a 6.10 section for KRaft

2022-09-07 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-14207: -- Summary: Add a 6.10 section for KRaft Key: KAFKA-14207 URL: https://issues.apache.org/jira/browse/KAFKA-14207 Project: Kafka Issu

[GitHub] [kafka] mumrah commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
mumrah commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965211745 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -147,7 +160,9 @@ class BrokerMetadataListener( private def maybeStartSnapshot(): Uni

[GitHub] [kafka] jsancio commented on pull request #12601: MINOR: Retry on test failure for branch builds and increase max test retry to 10

2022-09-07 Thread GitBox
jsancio commented on PR #12601: URL: https://github.com/apache/kafka/pull/12601#issuecomment-1239805413 Restarted the build. Gradle exited with an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] cmccabe commented on a diff in pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

2022-09-07 Thread GitBox
cmccabe commented on code in PR #12595: URL: https://github.com/apache/kafka/pull/12595#discussion_r965237423 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -844,6 +855,72 @@ public String toString() { } } +/** + * Appe

[GitHub] [kafka] cmccabe commented on a diff in pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

2022-09-07 Thread GitBox
cmccabe commented on code in PR #12595: URL: https://github.com/apache/kafka/pull/12595#discussion_r965238094 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1148,19 +1225,12 @@ private void renounce() { controllerMetrics.setActiv

[GitHub] [kafka] cmccabe commented on a diff in pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

2022-09-07 Thread GitBox
cmccabe commented on code in PR #12595: URL: https://github.com/apache/kafka/pull/12595#discussion_r965239405 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -844,6 +855,72 @@ public String toString() { } } +/** + * Appe

[GitHub] [kafka] cmccabe commented on pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

2022-09-07 Thread GitBox
cmccabe commented on PR #12595: URL: https://github.com/apache/kafka/pull/12595#issuecomment-1239838222 test failures don't seem related and don't reproduce locally (and also seem to be about the ZK variants of both tests, oddly) ``` kafka.test.ClusterTestExtensionsTest.testClusterTemp

[GitHub] [kafka] cmccabe commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
cmccabe commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965315234 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -147,7 +160,9 @@ class BrokerMetadataListener( private def maybeStartSnapshot(): Un

[GitHub] [kafka] cmccabe commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
cmccabe commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965316100 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long,

[GitHub] [kafka] cmccabe commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
cmccabe commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965316100 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long,

[GitHub] [kafka] cmccabe commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
cmccabe commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965318258 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long,

[GitHub] [kafka] cmccabe commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
cmccabe commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965318258 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long,

[GitHub] [kafka] cmccabe commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
cmccabe commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965319916 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -322,16 +322,22 @@ class BrokerMetadataListener( private def publish(publisher: Met

[GitHub] [kafka] rgroothuijsen opened a new pull request, #12602: KAFKA-13985: Skip committing MirrorSourceTask records without metadata

2022-09-07 Thread GitBox
rgroothuijsen opened a new pull request, #12602: URL: https://github.com/apache/kafka/pull/12602 This adds an additional check if there is any metadata before MirrorSourceTask commits a record, to avoid a potential null pointer exception. This can happen, for example, if the record was filt

[GitHub] [kafka] rgroothuijsen commented on pull request #12602: KAFKA-13985: Skip committing MirrorSourceTask records without metadata

2022-09-07 Thread GitBox
rgroothuijsen commented on PR #12602: URL: https://github.com/apache/kafka/pull/12602#issuecomment-1239941258 There are a couple of things I'm not certain about yet, the first being how much logging should be produced in this case, since the possibility of having null metadata appears to be

[jira] [Assigned] (KAFKA-13985) MirrorSourceTask commitRecord throws NPE if SMT is filtering out source record

2022-09-07 Thread Rens Groothuijsen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rens Groothuijsen reassigned KAFKA-13985: - Assignee: Rens Groothuijsen > MirrorSourceTask commitRecord throws NPE if SMT i

[GitHub] [kafka] philipnee opened a new pull request, #12603: Pausing partition to prevent duplication

2022-09-07 Thread GitBox
philipnee opened a new pull request, #12603: URL: https://github.com/apache/kafka/pull/12603 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testi

[jira] [Commented] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-07 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601523#comment-17601523 ] Philip Nee commented on KAFKA-14196: [~showuon] and [~guozhang] - I think pausing sh

[GitHub] [kafka] jsancio commented on a diff in pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

2022-09-07 Thread GitBox
jsancio commented on code in PR #12595: URL: https://github.com/apache/kafka/pull/12595#discussion_r965357907 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -844,6 +855,72 @@ public String toString() { } } +/** + * Appe

[GitHub] [kafka] jsancio commented on pull request #12601: MINOR: Retry on test failure for branch builds and increase max test retry to 10

2022-09-07 Thread GitBox
jsancio commented on PR #12601: URL: https://github.com/apache/kafka/pull/12601#issuecomment-1239985861 @ijuma the jenkins build keeps exiting with an error. Reran the build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] jsancio opened a new pull request, #12604: KAFKA-14188; Getting started for Kafka with KRaft

2022-09-07 Thread GitBox
jsancio opened a new pull request, #12604: URL: https://github.com/apache/kafka/pull/12604 Update the quickstart HTML page to include how to quickly start and experiment with a Kafka cluster using KRaft instead of ZooKeeper. ### Committer Checklist (excluded from commit message) -

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

2022-09-07 Thread GitBox
guozhangwang commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r965355508 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,120 @@ private void classifyTasksWithoutStateUpdater(fina

[GitHub] [kafka] jsancio opened a new pull request, #12605: MINOR; Remove end html tag from upgrade

2022-09-07 Thread GitBox
jsancio opened a new pull request, #12605: URL: https://github.com/apache/kafka/pull/12605 The doesn't have a matching tag. Those tags are added by the server side include and are not needed in docs/upgrade.html ### Committer Checklist (excluded from commit message) - [ ] Verify

[jira] [Comment Edited] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-07 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601523#comment-17601523 ] Philip Nee edited comment on KAFKA-14196 at 9/7/22 11:54 PM: -

[GitHub] [kafka] jsancio merged pull request #12605: MINOR; Remove end html tag from upgrade

2022-09-07 Thread GitBox
jsancio merged PR #12605: URL: https://github.com/apache/kafka/pull/12605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on a diff in pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

2022-09-07 Thread GitBox
showuon commented on code in PR #12595: URL: https://github.com/apache/kafka/pull/12595#discussion_r965436525 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1148,19 +1225,12 @@ private void renounce() { controllerMetrics.setActiv

[GitHub] [kafka] showuon commented on pull request #11783: KAFKA-14143: Exactly-once source connector system tests (KIP-618)

2022-09-07 Thread GitBox
showuon commented on PR #11783: URL: https://github.com/apache/kafka/pull/11783#issuecomment-1240135796 Let's wait for the result. Otherwise, this merge will also block 3.3 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] showuon commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

2022-09-07 Thread GitBox
showuon commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r965458057 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long,

[GitHub] [kafka] showuon commented on a diff in pull request #12604: KAFKA-14188; Getting started for Kafka with KRaft

2022-09-07 Thread GitBox
showuon commented on code in PR #12604: URL: https://github.com/apache/kafka/pull/12604#discussion_r965462196 ## docs/quickstart.html: ## @@ -64,6 +72,28 @@ Once all services have successfully launched, you will have a basic Kafka environment running and

[GitHub] [kafka] showuon commented on a diff in pull request #12604: KAFKA-14188; Getting started for Kafka with KRaft

2022-09-07 Thread GitBox
showuon commented on code in PR #12604: URL: https://github.com/apache/kafka/pull/12604#discussion_r965459701 ## docs/quickstart.html: ## @@ -46,6 +46,14 @@ NOTE: Your local environment must have Java 8+ installed. + +Apache Kafka ca

[jira] [Commented] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601609#comment-17601609 ] Luke Chen commented on KAFKA-14196: --- # Should we consider the difference between coope

[jira] [Comment Edited] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

2022-09-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601609#comment-17601609 ] Luke Chen edited comment on KAFKA-14196 at 9/8/22 3:30 AM: --- #

[GitHub] [kafka] yashmayya commented on a diff in pull request #12478: KAFKA-13952 fix RetryWithToleranceOperator to respect infinite retries configuration

2022-09-07 Thread GitBox
yashmayya commented on code in PR #12478: URL: https://github.com/apache/kafka/pull/12478#discussion_r965493011 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -199,116 +202,182 @@ private RetryWithToleranceOper

[GitHub] [kafka] yashmayya opened a new pull request, #12606: MINOR: Fix usage of @see in IncrementalCooperativeAssignor doc comments

2022-09-07 Thread GitBox
yashmayya opened a new pull request, #12606: URL: https://github.com/apache/kafka/pull/12606 Rendered doc comments before this change: https://user-images.githubusercontent.com/23502577/189043808-e8bcd06f-b85c-47c3-83a0-20875c9b0c18.png";> https://user-images.githubusercontent.c