mumrah commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r965211745
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##########
@@ -147,7 +160,9 @@ class BrokerMetadataListener(
private def maybeStartSnapshot(): Unit = {
snapshotter.foreach { snapshotter =>
- if (snapshotter.maybeStartSnapshot(_highestTimestamp, _delta.apply())) {
+ if (metadataFaultOccurred.get()) {
+ trace("Not starting metadata snapshot since we previously had an
error")
Review Comment:
My concern is that in an emergency scenario when things are going badly, we
could lose important logs due to log rotation if we're spamming a bunch of the
same error/warn messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
