[GitHub] [kafka] jsancio commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

Wed, 07 Sep 2022 08:41:07 -0700 


jsancio commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r965006213


##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##########
@@ -41,8 +43,19 @@ class BrokerMetadataListener(
   val maxBytesBetweenSnapshots: Long,
   val snapshotter: Option[MetadataSnapshotter],
   brokerMetrics: BrokerServerMetrics,
-  metadataLoadingFaultHandler: FaultHandler
+  _metadataLoadingFaultHandler: FaultHandler

Review Comment:
   Failures in this code seems to be fatal given the latest code:
   
https://github.com/apache/kafka/blob/cc185807591e54c7abb9af91fbb847ab9a9acc8a/core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala#L323-L330



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to