cmccabe commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r965318258
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##########
@@ -41,8 +43,19 @@ class BrokerMetadataListener(
val maxBytesBetweenSnapshots: Long,
val snapshotter: Option[MetadataSnapshotter],
brokerMetrics: BrokerServerMetrics,
- metadataLoadingFaultHandler: FaultHandler
+ _metadataLoadingFaultHandler: FaultHandler
Review Comment:
yes, the apply errors should be handled by `metadataLoadingFaultHandler` as
well. If apply fails we obviously cannot apply the update at all, so we should
have a catch block with something like `throw
metadataLoadingFaultHandler.handleFault("delta apply error", ...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
