wcarlson5 commented on code in PR #12594:
URL: https://github.com/apache/kafka/pull/12594#discussion_r964956521
##########
streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java:
##########
@@ -924,8 +926,10 @@ private void verifyPartitionsAndStoresForTopology(final
String topologyName, fin
.collect(Collectors.toList())),
is(true));
- // then verify that only this topology's one store appears
- assertThat(metadata.stateStoreNames(), equalTo(singleton("store-" +
topologyName)));
+ // then verify that only this topology's one store appears if the host
has partitions assigned
+ if (!metadata.topicPartitions().isEmpty()) {
+ assertThat(metadata.stateStoreNames(), equalTo(singleton("store-"
+ topologyName)));
+ }
Review Comment:
Well, not all named topology topics are going to be in all the source
metadata, we can check the stores are limited to the relevant topics. Though I
am not sure how useful that is as the method for getting the metadata is
filtering the store by if they contain the topology name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
