mjsax merged PR #18814:
URL: https://github.com/apache/kafka/pull/18814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on PR #18814:
URL: https://github.com/apache/kafka/pull/18814#issuecomment-2638909570
\cc @bbejeck @dajac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
mjsax commented on PR #18778:
URL: https://github.com/apache/kafka/pull/18778#issuecomment-2638909289
Follow up PR for 4.0 backport (for actual JavaDocs changes only):
https://github.com/apache/kafka/pull/18814
--
This is an automated message from the Apache Git Service.
To respond to the
mjsax opened a new pull request, #18814:
URL: https://github.com/apache/kafka/pull/18814
JavaDocs changes extracted from
https://github.com/apache/kafka/pull/18778 for 4.0 backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax merged PR #18778:
URL: https://github.com/apache/kafka/pull/18778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1943854473
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNode.java:
##
@@ -103,13 +103,16 @@ public void writeToTopology(final InternalTopolog
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940567499
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -423,10 +423,8 @@ public void process(final Record record) {
}
}
}
-@Depre
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940564999
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940563796
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940552054
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -677,10 +662,10 @@ public synchronized Topology
addProcessor(final String na
*
* @thr
bbejeck commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1943825510
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -701,6 +679,8 @@ public final void addGlobalStore(final Strin
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940562488
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -640,10 +606,11 @@ public final void addStateStore(final StoreFa
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940567499
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -423,10 +423,8 @@ public void process(final Record record) {
}
}
}
-@Depre
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549926
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -476,22 +483,22 @@ public synchronized Topology addSink(final String name,
/**
* See {@l
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940567798
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -423,10 +423,8 @@ public void process(final Record record) {
}
}
}
-@Depre
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940566642
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -1963,7 +1924,6 @@ public String toString() {
+
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940565584
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -729,13 +707,21 @@ public boolean isStoreVersioned(final String
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940564999
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940564189
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940563796
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -655,21 +622,32 @@ public final void addGlobalStore(final Strin
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940563422
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -507,46 +510,23 @@ public final void addSink(final String name,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940561921
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -587,31 +550,34 @@ public final void addProcessor(final String n
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940558829
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -507,46 +510,23 @@ public final void addSink(final String name,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554776
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -447,18 +449,23 @@ public final synchronized InternalTopologyBui
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554776
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -447,18 +449,23 @@ public final synchronized InternalTopologyBui
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554541
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -368,7 +370,7 @@ private SinkNodeFactory(final String name,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549273
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -135,7 +139,7 @@ public synchronized Topology addSource(final String name,
/**
* See {@l
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940554151
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -74,6 +74,8 @@ public InternalTopologyBuilder() {
}
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940553801
##
streams/src/main/java/org/apache/kafka/streams/internals/ApiUtils.java:
##
@@ -81,6 +82,8 @@ public static String prepareMillisCheckFailMsgPrefix(final
Object value,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940553477
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -677,10 +662,10 @@ public synchronized Topology
addProcessor(final String na
*
* @thr
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940552054
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -677,10 +662,10 @@ public synchronized Topology
addProcessor(final String na
*
* @thr
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940551476
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -617,7 +600,9 @@ public synchronized Topology addSink(final String
name,
*
* @throws
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940550708
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -510,62 +517,38 @@ public synchronized Topology addSink(final String
name,
}
/**
-
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549926
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -476,22 +483,22 @@ public synchronized Topology addSink(final String name,
/**
* See {@l
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940548959
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -119,10 +119,14 @@ private static AutoOffsetResetInternal
convertOldToNew(final Topology.AutoOffse
bbejeck commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940199139
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -662,87 +418,30 @@ public synchronized Topology addSink(final String name,
}
/**
-
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397250
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -146,8 +146,7 @@ public void shouldNotAllowNullNameWhenAddingProcessor() {
@Test
pu
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397352
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -2338,7 +2338,6 @@ private TopologyDescription.Sink addSink(final String
sinkName,
re
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938398492
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -662,87 +418,30 @@ public synchronized Topology addSink(final String name,
}
/**
-
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938398492
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -662,87 +418,30 @@ public synchronized Topology addSink(final String name,
}
/**
-
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938398744
##
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##
@@ -918,38 +630,96 @@ public synchronized Topology addStateStore(final
StoreBuilder storeBuilder,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397250
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -146,8 +146,7 @@ public void shouldNotAllowNullNameWhenAddingProcessor() {
@Test
pu
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397352
##
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##
@@ -2338,7 +2338,6 @@ private TopologyDescription.Sink addSink(final String
sinkName,
re
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397118
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -668,8 +668,7 @@ public final void addGlobalStore(final String
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397209
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -878,7 +875,7 @@ private void connectProcessorAndStateStore(fina
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938396902
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -554,9 +554,9 @@ public final void addSink(final String name,
mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938396810
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNode.java:
##
@@ -103,13 +103,16 @@ public void writeToTopology(final InternalTopolog
mjsax opened a new pull request, #18778:
URL: https://github.com/apache/kafka/pull/18778
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
48 matches
Mail list logo
