mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940552054
##########
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##########
@@ -677,10 +662,10 @@ public synchronized <KIn, VIn, KOut, VOut> Topology
addProcessor(final String na
*
* @throws TopologyException
* if the {@link StoreBuilder#name() state store} was already
added, or
- * if a processor name is unknown
+ * if a processor name is unknown or specifies a source or sink
*/
- public synchronized Topology addStateStore(final StoreBuilder<?>
storeBuilder,
- final String... processorNames)
{
+ public synchronized <S extends StateStore> Topology addStateStore(final
StoreBuilder<S> storeBuilder,
Review Comment:
Decided to move off `<?>` for the store type, too... Does not add real
value, but for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
