mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397118
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##########
@@ -668,8 +668,7 @@ public final <KIn, VIn> void addGlobalStore(final String
sourceName,
topic,
processorName,
stateUpdateSupplier,
- storeFactory.storeName(),
- storeFactory.loggingEnabled());
+ storeFactory.storeName());
Review Comment:
Change this to not fail if state-store-logging is enabled, but instead just
disable it. This align to what we do for "read-only stores".
Noticed the difference between read-only vs global and though it better to
align both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
