mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1938397250
##########
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##########
@@ -146,8 +146,7 @@ public void shouldNotAllowNullNameWhenAddingProcessor() {
@Test
public void shouldNotAllowNullProcessorSupplierWhenAddingProcessor() {
- assertThrows(NullPointerException.class, () ->
topology.addProcessor("name",
- (ProcessorSupplier<Object, Object, Object, Object>) null));
+ assertThrows(NullPointerException.class, () ->
topology.addProcessor("name", null));
Review Comment:
more side cleanup
##########
streams/src/test/java/org/apache/kafka/streams/TopologyTest.java:
##########
@@ -2257,16 +2257,16 @@ private Topology topologyWithStaticTopicName() {
private TopologyDescription.Source addSource(final String sourceName,
final String... sourceTopic) {
- topology.addSource((Topology.AutoOffsetReset) null, sourceName, null,
null, null, sourceTopic);
- final StringBuilder allSourceTopics = new
StringBuilder(sourceTopic[0]);
Review Comment:
`allSourceTopics` is unused -- removing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
