mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940563796
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##########
@@ -655,21 +622,32 @@ public final <KIn, VIn> void addGlobalStore(final String
sourceName,
final String processorName,
final ProcessorSupplier<KIn,
VIn, Void, Void> stateUpdateSupplier,
final boolean
reprocessOnRestore) {
- ApiUtils.checkSupplier(stateUpdateSupplier);
+ verifyName(sourceName);
+
+ Objects.requireNonNull(topic, "topic cannot be null");
Review Comment:
Add missing `null` check...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
