chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2586347959
@trnguyencflt we have resolved the issue in #18472. If you have some free
time, could you please test it on your project?
Please don't hesitate to provide any feedback if you think som
frankvicky commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2581610985
Hi @trnguyencflt
Thanks for report.
I have filed KAFKA-18466 to track this issue.
I will filed a PR for this issue soon.
--
This is an automated message from the Apache Git
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2581051461
@trnguyencflt thanks for your response. `log4j-1.2-api` is used to convert
log4j.properties at runtime, and hence maybe we can remove it from gradle
runtime scope and then add it into di
trnguyencflt commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2580893706
@chia7712 we include kafka_2.13 as dependency via maven
https://github.com/confluentinc/kafka-rest/blob/d6405f714e0e453d6eb5b9a496faac4202c89cab/kafka-rest/pom.xml#L42,
and it brings
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2578035232
@trnguyencflt thanks for your report. I'd like to reduce the gap of
upgrading to kafka 4.0 as much as possible, so please share the details to me
--
This is an automated message from t
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2578032374
> This PR breaks downstream project that depends on kafka_2.13 and reload4j
I assume the scenario you describe is to add "kafka_2.13" as dependency for
the downstream project. The
ijuma commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2577897980
The point is that kafka was including `reload4j` before and hence many other
projects aligned with that. It's one thing to cause logging to change, it's
another to cause projects not to sta
ppkarwasz commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2577875259
> This PR breaks downstream project that depends on kafka_2.13 and reload4j
because there is clashing in class LoggingEvent, which exists in `reload4j` and
`log4j-1.2-api` jars.
trnguyencflt commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2577813317
This PR breaks downstream project that depends on kafka_2.13 and reload4j
because there is clashing in class LoggingEvent, which exists in reload4j and
log4j-1.2-api jars. The applic
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1899049780
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modul
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898983229
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modu
ijuma commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898950768
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module:
ijuma commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898950768
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module:
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898534270
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modul
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898478552
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modu
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898365578
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modul
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898357031
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modu
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898356316
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modu
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898313661
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modul
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1898304621
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modu
ijuma commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1894553658
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module:
ijuma commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1894553658
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module:
ijuma commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1894553541
##
build.gradle:
##
@@ -2441,13 +2459,18 @@ project(':tools') {
implementation libs.jacksonDataformatCsv
implementation libs.jacksonJDK8Datatypes
implement
jolshan commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2557623349
Here's the result.
http://ducktape-open-source-results.confluent.io.s3-website-us-west-2.amazonaws.com/confluent-open-source-kafka-branch-builder-system-test-results/?prefix=trunk/2024-12-
jolshan commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2557576698
@chia7712 sure. I will run it and post the results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1894238151
##
build.gradle:
##
@@ -2441,13 +2459,18 @@ project(':tools') {
implementation libs.jacksonDataformatCsv
implementation libs.jacksonJDK8Datatypes
imple
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2557479743
There are many tests which are failed quickly.
```
[DEBUG - 2024-12-18 22:36:58,718 - remoteaccount - _log - lineno:180]:
ubuntu@worker47: Running ssh command: tail -c +1
/mnt/kaf
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1894164970
##
config/log4j2.yaml:
##
@@ -0,0 +1,158 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE fi
jolshan commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2557355489
> @jolshan thanks for your report. the known issue caused by this PR is the
"logger" of connect. And I run the one of test (transactions_upgrade_test.py)
on my local:
Interesting.
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2557311234
@frankvicky Could you please open minor to address following items?
1. move the deprecation warnings to `kafka-run-class`
https://github.com/apache/kafka/pull/17373#discussion_r189
frankvicky commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2557302557
I will open a PR adding upgrade notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1894124425
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modul
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1894121803
##
build.gradle:
##
@@ -2441,13 +2459,18 @@ project(':tools') {
implementation libs.jacksonDataformatCsv
implementation libs.jacksonJDK8Datatypes
impl
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1894092841
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude modul
ijuma commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2557032193
I don't see any upgrade notes - did I miss something or did we forget to add
that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1893947193
##
config/log4j2.yaml:
##
@@ -0,0 +1,158 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file
ijuma commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1893939705
##
build.gradle:
##
@@ -2441,13 +2459,18 @@ project(':tools') {
implementation libs.jacksonDataformatCsv
implementation libs.jacksonJDK8Datatypes
implement
ijuma commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1893938757
##
build.gradle:
##
@@ -1099,15 +1103,17 @@ project(':core') {
implementation libs.dropwizardMetrics
exclude module: 'slf4j-log4j12'
exclude module:
ijuma commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1893936536
##
bin/connect-distributed.sh:
##
@@ -22,8 +22,12 @@ fi
base_dir=$(dirname $0)
-if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
-export
KAFKA_LOG4J_OPTS="-Dlog4j.config
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2556229381
@jolshan thanks for your report. the known issue caused by this PR is the
"logger" of connect. And I run the one of test (`transactions_upgrade_test.py`)
on my local:
```
[INFO:202
jolshan commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2556096026
Hey -- not sure if there is something up with my setup, but after this PR, I
see many tests failing due to kafka server not starting up (in the logs I see `
Port already in use: 9192; nes
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2543435727
I am currently testing this patch, and all related issues are tracked under
[KAFKA-18161](https://issues.apache.org/jira/browse/KAFKA-18161). Please feel
free to report any issues if I o
frankvicky commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2542607479
Thank you all for your patience in reviewing.
I truly appreciate all your help. 🙇🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
chia7712 merged PR #17373:
URL: https://github.com/apache/kafka/pull/17373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2541895357
@dongjinleekr I add you to the co-author. see
https://github.com/apache/kafka/commit/b37b89c6686f5270b37d39cf3144bccb4f5bceb2
--
This is an automated message from the Apache Git Servic
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2541679409
> Should we consider merging this and disabling the broken system test for
now? WDYT?
Let me perform a final review later, and then I will merge it!
--
This is an automated mess
mimaison commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2540936116
@chia7712 Should we consider merging this and disabling the broken system
test for now? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2518956077
The last (maybe) Connect end-to-end issue is
[KAFKA-18160](https://issues.apache.org/jira/browse/KAFKA-18160). We can
revisit this PR after the existing Connect end-to-end issues are res
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2510857877
@frankvicky could you please rebase code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
frankvicky commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2510443802
Failed CI is handled by #17996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1864898855
##
tests/kafkatest/services/connect.py:
##
@@ -421,7 +423,7 @@ def start_node(self, node, **kwargs):
if self.external_config_template_func:
node.
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1864435870
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -805,7 +805,7 @@ def start_cmd(self, node):
kafka_mode = self.context.globals.get("kafka_mode", "")
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2508981008
>
MetadataSchemaCheckerToolTest#testVerifyEvolutionGit keep failing in CI, I
think it's not related to this PR.
the root cause is the test assumes the repo has ref "refs/heads/
frankvicky commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2508957854
[Develocity](https://ge.apache.org/scans/tests?search.rootProjectNames=kafka&search.timeZoneId=Asia%2FTaipei&tests.container=org.apache.kafka.message.checker.MetadataSchemaCheckerToolTe
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2508123859
@frankvicky In the end-to-end tests, you must use the correct file extension
when passing the log4j2 YAML configuration. If you use an incorrect extension -
for example - the output of `
mimaison commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2507855608
Thanks @frankvicky for investigating. I ran the system tests in our CI and
confirm most the Connect tests are currently failing with your branch (I've not
tried running other tests yet).
frankvicky commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2507753807
Since this issue is quite tricky for me, I went through a process of
elimination to locate the bug.
I found this line might be the root cause:
https://github.com/apache/kafka
showuon commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2506901731
@frankvicky , we ran system tests on connect related tests based on this PR,
it failed quite a lot.
[Here](https://gist.github.com/showuon/03b4586624ca6c7be95b8d4cc803d3af) is the
result
frankvicky commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2505169162
Hi @mimaison,
Unfortunately, I don't have the resources to perform the full test suite as
it would take a very long time 😬.
Instead, I selected a test related to this PR. The
mimaison commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2504369138
I just tested the Connect REST API with
https://github.com/apache/kafka/pull/17373/commits/6d41bcd92758c7bc02c173b98dc4c53f88633ba0
and it worked fine.
You mentioned issues with t
mimaison commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2504207669
Apart if the changes to fix the system tests are very large, I'd rather do
them in this PR as well. We typically don't merge PRs that we know will break
tests.
--
This is an automated
frankvicky commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2504196849
Hi @mimaison,
I have filed a JIRA for the issue with the Connect API:
https://issues.apache.org/jira/browse/KAFKA-18104
BTW, I’m aware that this PR is expected to break
mimaison commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1860858017
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -174,43 +178,46 @@ private synchronized List
loggers(String namespace) {
}
mimaison commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2503451783
@frankvicky Can you rebase to fix the conflicts? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
mimaison commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2488600707
I'm having issues with the latest code.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1850570634
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -874,7 +874,7 @@ def start_node(self, node, timeout_sec=60, **kwargs):
self.logger.info("kafka.properties:
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1850545236
##
config/log4j2.yaml:
##
@@ -0,0 +1,164 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1850514477
##
config/log4j2.yaml:
##
@@ -0,0 +1,164 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE f
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1850378074
##
tests/kafkatest/services/templates/connect_log4j2.yaml:
##
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor lic
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1850373880
##
tests/kafkatest/services/connect.py:
##
@@ -364,7 +364,7 @@ def start_node(self, node, **kwargs):
if self.external_config_template_func:
node.
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1850375006
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -874,7 +874,7 @@ def start_node(self, node, timeout_sec=60, **kwargs):
self.logger.info("kafka.properties:")
mimaison commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2486208765
> When you merge this PR, please don't omit mentioning my credit. 🙇♂️
Yes you totally deserve being marked as a co-author. Thanks!
--
This is an automated message from the Apach
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1848672753
##
tests/kafkatest/services/connect.py:
##
@@ -364,7 +364,7 @@ def start_node(self, node, **kwargs):
if self.external_config_template_func:
node.
dongjinleekr commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1848323271
##
build.gradle:
##
@@ -941,13 +942,15 @@ project(':server') {
implementation libs.slf4jApi
-compileOnly libs.reload4j
+compileOnly libs.log4j2Api
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2485801878
> When you merge this PR, please don't omit mentioning my credit. 🙇♂️
will roger that :)
--
This is an automated message from the Apache Git Service.
To respond to the message,
dongjinleekr commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2485719308
ALL //
To clearly state the reasoning for root logger's name, I just updated the
[KIP
document](https://cwiki.apache.org/confluence/display/KAFKA/KIP-653%3A+Upgrade+log4j+to+l
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1847964777
##
build.gradle:
##
@@ -941,13 +942,15 @@ project(':server') {
implementation libs.slf4jApi
-compileOnly libs.reload4j
+compileOnly libs.log4j2Api
+
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1847704612
##
core/src/main/scala/kafka/utils/Log4jController.scala:
##
@@ -17,83 +17,90 @@
package kafka.utils
-import java.util
-import java.util.Locale
-
import org.apac
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1847874109
##
gradle/dependencies.gradle:
##
@@ -220,15 +226,15 @@ libs += [
pcollections: "org.pcollections:pcollections:$versions.pcollections",
opentelemetryProto:
"io.
mimaison commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1846332278
##
config/connect-log4j2.properties:
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
Should we remove con
chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1846550136
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -174,43 +179,50 @@ private synchronized List
loggers(String namespace) {
}
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1846355549
##
config/log4j2.properties:
##
@@ -0,0 +1,158 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
I think that it's ok now
mimaison commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1846417125
##
config/log4j2.properties:
##
@@ -0,0 +1,158 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
Yes because otherwise we de
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1846355549
##
config/log4j2.properties:
##
@@ -0,0 +1,158 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review Comment:
I think it's fine now sin
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1845315796
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -45,9 +50,9 @@ public class Loggers {
private static final Logger log = Lo
dongjinleekr commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1845315012
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##
@@ -45,9 +50,9 @@ public class Loggers {
private static final Logger log =
dongjinleekr commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2480966246
@mimaison @frankvicky
FYI: I just moved from #7898 and Reviewing the differences between our 3.6.X
in-house fork. It was already applied to our implementation and is actively
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1844099567
##
core/src/test/scala/other/kafka.log4j.properties:
##
@@ -19,4 +19,4 @@ log4j.appender.KAFKA=kafka.log4j.KafkaAppender
log4j.appender.KAFKA.Port=9092
log4j.appen
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1844097109
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -3569,6 +3584,13 @@ object PlaintextAdminIntegrationTest {
assertEquals(
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1844089662
##
README.md:
##
@@ -54,9 +54,9 @@ Follow instructions in https://kafka.apache.org/quickstart
./gradlew clients:test --tests
org.apache.kafka.clients.MetadataT
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1844010558
##
config/connect-log4j2.properties:
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. Se
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1843981241
##
build.gradle:
##
@@ -2386,7 +2394,11 @@ project(':tools') {
implementation libs.jacksonDataformatCsv
implementation libs.jacksonJDK8Datatypes
imple
mimaison commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1843599782
##
bin/connect-distributed.sh:
##
@@ -22,8 +22,15 @@ fi
base_dir=$(dirname $0)
-if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
+if [ -f "$base_dir/../config/connect-log4
showuon commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1843502542
##
bin/connect-distributed.sh:
##
@@ -22,8 +22,15 @@ fi
base_dir=$(dirname $0)
-if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
+if [ -f "$base_dir/../config/connect-log4j
ppkarwasz commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1843491362
##
bin/connect-distributed.sh:
##
@@ -22,8 +22,15 @@ fi
base_dir=$(dirname $0)
-if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
+if [ -f "$base_dir/../config/connect-log
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1843393551
##
bin/connect-distributed.sh:
##
@@ -22,8 +22,15 @@ fi
base_dir=$(dirname $0)
-if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
+if [ -f "$base_dir/../config/connect-lo
showuon commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2478290150
@mimaison @mumrah @ppkarwasz , do you have any other comments? I'll merge it
tomorrow if no other comments. Thanks.
--
This is an automated message from the Apache Git Service.
To respo
showuon commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1843386874
##
bin/connect-distributed.sh:
##
@@ -22,8 +22,15 @@ fi
base_dir=$(dirname $0)
-if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
+if [ -f "$base_dir/../config/connect-log4j
frankvicky commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2472887781
Hello @mimaison,@showuon,
Since this PR modifies a large number of files, particularly `build.gradle`,
it’s highly susceptible to conflicts with other PRs, making it rather
exha
frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1833673224
##
clients/src/test/java/org/apache/kafka/common/utils/LogCaptureAppender.java:
##
@@ -74,29 +80,51 @@ public Optional getThrowableClassName() {
}
}
1 - 100 of 156 matches
Mail list logo
