chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2581051461

   @trnguyencflt thanks for your response. `log4j-1.2-api` is used to convert 
log4j.properties at runtime, and hence maybe we can remove it from gradle 
runtime scope and then add it into distribution directly. With that change, 
`log4j-1.2-api` gets removed from published pom file but it remains in the 
distribution.
   
   this is the pom file with above approach and there is not `log4j-1.2-api` 
   ```
   
chia7712@chia7712-ubuntu:~/.m2/repository/org/apache/kafka/kafka_2.13/4.1.0-SNAPSHOT$
 cat kafka_2.13-4.1.0-SNAPSHOT.pom | grep log4j
         <groupId>org.apache.logging.log4j</groupId>
         <artifactId>log4j-slf4j-impl</artifactId>
         <groupId>org.apache.logging.log4j</groupId>
         <artifactId>log4j-api</artifactId>
         <groupId>org.apache.logging.log4j</groupId>
         <artifactId>log4j-core</artifactId>
   ```
   
   By contrast,  `log4j-1.2-api` is still included by distribution.
   ```
   
chia7712@chia7712-ubuntu:~/project/kafka/core/build/distributions/kafka_2.13-4.1.0-SNAPSHOT$
 ls libs | grep log4j
   log4j-1.2-api-2.24.1.jar
   log4j-api-2.24.1.jar
   log4j-core-2.24.1.jar
   log4j-slf4j-impl-2.24.1.jar
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to