chia7712 commented on code in PR #17373: URL: https://github.com/apache/kafka/pull/17373#discussion_r1847874109
########## gradle/dependencies.gradle: ########## @@ -220,15 +226,15 @@ libs += [ pcollections: "org.pcollections:pcollections:$versions.pcollections", opentelemetryProto: "io.opentelemetry.proto:opentelemetry-proto:$versions.opentelemetryProto", protobuf: "com.google.protobuf:protobuf-java:$versions.protobuf", - reload4j: "ch.qos.reload4j:reload4j:$versions.reload4j", re2j: "com.google.re2j:re2j:$versions.re2j", rocksDBJni: "org.rocksdb:rocksdbjni:$versions.rocksDB", scalaLibrary: "org.scala-lang:scala-library:$versions.scala", scalaLogging: "com.typesafe.scala-logging:scala-logging_$versions.baseScala:$versions.scalaLogging", scalaReflect: "org.scala-lang:scala-reflect:$versions.scala", slf4jApi: "org.slf4j:slf4j-api:$versions.slf4j", - slf4jReload4j: "org.slf4j:slf4j-reload4j:$versions.slf4j", + slf4jLog4j2: "org.apache.logging.log4j:log4j-slf4j-impl:$versions.log4j2", Review Comment: please add it to `LICENSE-binary` file ########## gradle/dependencies.gradle: ########## @@ -220,15 +226,15 @@ libs += [ pcollections: "org.pcollections:pcollections:$versions.pcollections", opentelemetryProto: "io.opentelemetry.proto:opentelemetry-proto:$versions.opentelemetryProto", protobuf: "com.google.protobuf:protobuf-java:$versions.protobuf", - reload4j: "ch.qos.reload4j:reload4j:$versions.reload4j", re2j: "com.google.re2j:re2j:$versions.re2j", rocksDBJni: "org.rocksdb:rocksdbjni:$versions.rocksDB", scalaLibrary: "org.scala-lang:scala-library:$versions.scala", scalaLogging: "com.typesafe.scala-logging:scala-logging_$versions.baseScala:$versions.scalaLogging", scalaReflect: "org.scala-lang:scala-reflect:$versions.scala", slf4jApi: "org.slf4j:slf4j-api:$versions.slf4j", - slf4jReload4j: "org.slf4j:slf4j-reload4j:$versions.slf4j", Review Comment: ditto https://github.com/apache/kafka/blob/trunk/LICENSE-binary#L316 ########## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ########## @@ -89,18 +90,11 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrationTest { @BeforeEach override def setUp(testInfo: TestInfo): Unit = { super.setUp(testInfo) + Configurator.reconfigure(); brokerLoggerConfigResource = new ConfigResource( ConfigResource.Type.BROKER_LOGGER, brokers.head.config.brokerId.toString) } - @AfterEach - override def tearDown(): Unit = { - // Due to the fact that log4j is not re-initialized across tests, changing a logger's log level persists - // across test classes. We need to clean up the changes done after testing. - resetLogging() Review Comment: `ReplicationQuotasTestRig` has similar code https://github.com/apache/kafka/blob/trunk/tools/src/test/java/org/apache/kafka/tools/other/ReplicationQuotasTestRig.java#L98 Could we delete it in this PR too? ########## gradle/dependencies.gradle: ########## @@ -220,15 +226,15 @@ libs += [ pcollections: "org.pcollections:pcollections:$versions.pcollections", opentelemetryProto: "io.opentelemetry.proto:opentelemetry-proto:$versions.opentelemetryProto", protobuf: "com.google.protobuf:protobuf-java:$versions.protobuf", - reload4j: "ch.qos.reload4j:reload4j:$versions.reload4j", Review Comment: please remove it from https://github.com/apache/kafka/blob/trunk/LICENSE-binary#L257 too ########## build.gradle: ########## @@ -941,13 +942,15 @@ project(':server') { implementation libs.slf4jApi - compileOnly libs.reload4j + compileOnly libs.log4j2Api + compileOnly libs.log4j2Core + compileOnly libs.log4j1Bridge2Api Review Comment: Do we really need `log4j1Bridge2Api`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
