chia7712 commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1848672753
##########
tests/kafkatest/services/connect.py:
##########
@@ -364,7 +364,7 @@ def start_node(self, node, **kwargs):
if self.external_config_template_func:
node.account.create_file(self.EXTERNAL_CONFIGS_FILE,
self.external_config_template_func(node))
node.account.create_file(self.CONFIG_FILE,
self.config_template_func(node))
- node.account.create_file(self.LOG4J_CONFIG_FILE,
self.render('connect_log4j.properties', log_file=self.LOG_FILE))
+ node.account.create_file(self.LOG4J_CONFIG_FILE,
self.render('connect_log4j2.properties', log_file=self.LOG_FILE))
Review Comment:
in the e2e we could run kafak on different version, so we must check the
version before applying the config file.
##########
tests/kafkatest/services/connect.py:
##########
@@ -421,7 +421,7 @@ def start_node(self, node, **kwargs):
if self.external_config_template_func:
node.account.create_file(self.EXTERNAL_CONFIGS_FILE,
self.external_config_template_func(node))
node.account.create_file(self.CONFIG_FILE,
self.config_template_func(node))
- node.account.create_file(self.LOG4J_CONFIG_FILE,
self.render('connect_log4j.properties', log_file=self.LOG_FILE))
+ node.account.create_file(self.LOG4J_CONFIG_FILE,
self.render('connect_log4j2.properties', log_file=self.LOG_FILE))
Review Comment:
ditto
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -874,7 +874,7 @@ def start_node(self, node, timeout_sec=60, **kwargs):
self.logger.info("kafka.properties:")
self.logger.info(prop_file)
node.account.create_file(KafkaService.CONFIG_FILE, prop_file)
- node.account.create_file(self.LOG4J_CONFIG,
self.render('log4j.properties', log_dir=KafkaService.OPERATIONAL_LOG_DIR))
+ node.account.create_file(self.LOG4J_CONFIG,
self.render('log4j2.properties', log_dir=KafkaService.OPERATIONAL_LOG_DIR))
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
