Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-22 Thread via GitHub
AndrewJSchofield merged PR #19378: URL: https://github.com/apache/kafka/pull/19378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037973763 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknow

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037943935 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknow

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037944799 ## clients/src/main/resources/common/message/ShareFetchRequest.json: ## @@ -48,6 +47,8 @@ "about": "The partitions to fetch.", "fields": [ { "n

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037943935 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknow

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037938413 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAckn

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037929838 ## clients/src/main/resources/common/message/ShareFetchRequest.json: ## @@ -48,6 +47,8 @@ "about": "The partitions to fetch.", "fields": [ {

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037892822 ## clients/src/main/resources/common/message/ShareFetchRequest.json: ## @@ -48,6 +47,8 @@ "about": "The partitions to fetch.", "fields": [ { "n

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037882487 ## clients/src/main/resources/common/message/ShareAcknowledgeResponse.json: ## @@ -17,7 +17,10 @@ "apiKey": 79, "type": "response", "name": "ShareAcknow

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037371932 ## clients/src/main/resources/common/message/ShareAcknowledgeRequest.json: ## @@ -18,34 +18,33 @@ "type": "request", "listeners": ["broker"], "name":

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
AndrewJSchofield commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037776176 ## clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsRequest.java: ## @@ -41,7 +41,7 @@ public static class Builder extends Abstrac

Re: [PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-10 Thread via GitHub
apoorvmittal10 commented on code in PR #19378: URL: https://github.com/apache/kafka/pull/19378#discussion_r2037272992 ## clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsRequest.java: ## @@ -41,7 +41,7 @@ public static class Builder extends AbstractR

[PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-04 Thread via GitHub
AndrewJSchofield opened a new pull request, #19378: URL: https://github.com/apache/kafka/pull/19378 This PR removes the unstable API flag for the KIP-932 RPCs. The 4 RPCs which were exposed for the early access release in AK 4.0 are stabilised at v1. This is because the RPCs have evol