Re: [PR] MINOR: Fix unchecked type warnings in several test classes [kafka]

2025-05-12 Thread via GitHub
chia7712 merged PR #19679: URL: https://github.com/apache/kafka/pull/19679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19274) Group Coordinator Shards are not unloaded when __consumer_offsets topic is deleted

2025-05-12 Thread David Jacot (Jira)
David Jacot created KAFKA-19274: --- Summary: Group Coordinator Shards are not unloaded when __consumer_offsets topic is deleted Key: KAFKA-19274 URL: https://issues.apache.org/jira/browse/KAFKA-19274 Proj

Re: [PR] KAFKA-19269: `Unexpected error ..` should not happen when the delete.topic.enable is false [kafka]

2025-05-12 Thread via GitHub
chia7712 commented on PR #19698: URL: https://github.com/apache/kafka/pull/19698#issuecomment-2875248898 @xijiu thanks for this patch. Have you consider returning CompletableFuture instead of throwing exception? ```java if (!config.deleteTopicEnable) { if (apiVersion <

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-12 Thread via GitHub
chia7712 commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2086042662 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2994,35 +2992,4 @@ private void waitForAssignment(S

[PR] KAFKA-19202: Enable KIP-1071 in streams_eos_test [kafka]

2025-05-12 Thread via GitHub
lucasbru opened a new pull request, #19700: URL: https://github.com/apache/kafka/pull/19700 Enable next system test with KIP-1071. Some of the validation inside the test does not make sense for KIP-1071. This is because in KIP-1071, if a member leaves or joins the group, not all

[jira] [Commented] (KAFKA-19273) Ensure the delete policy is configured when the tiered storage is enabled

2025-05-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1795#comment-1795 ] Chia-Ping Tsai commented on KAFKA-19273: see https://lists.apache.org/thread/5mr

Re: [PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-12 Thread via GitHub
chia7712 commented on PR #19696: URL: https://github.com/apache/kafka/pull/19696#issuecomment-2875173208 @ahuang98 thanks for those backports, however, I guess there is no more release for those branches, and hence maybe those backports are unnecessary. WDYT? -- This is an automated mess

[jira] [Created] (KAFKA-19273) Ensure the delete policy is configured when the tiered storage is enabled

2025-05-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19273: -- Summary: Ensure the delete policy is configured when the tiered storage is enabled Key: KAFKA-19273 URL: https://issues.apache.org/jira/browse/KAFKA-19273 Project

[jira] [Resolved] (KAFKA-13224) broker.id does not appear in config's originals map when setting just node.id

2025-05-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-13224. Fix Version/s: 3.1.0 Assignee: Colin McCabe (was: Ron Dagostino) Resolutio

[jira] [Resolved] (KAFKA-13192) broker.id and node.id can be specified inconsistently

2025-05-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-13192. Resolution: Won't Fix see KAFKA-13224 > broker.id and node.id can be specified inconsiste

[PR] KAFKA-18884: Move TransactionMetadata to transaction-coordinator module (wip) [kafka]

2025-05-12 Thread via GitHub
FrankYang0529 opened a new pull request, #19699: URL: https://github.com/apache/kafka/pull/19699 1. Move TransactionMetadata to transaction-coordinator module. 2. Rewrite TransactionMetadata in Java. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] KAFKA-19269: `Unexpected error ..` should not happen when the delete.topic.enable is false [kafka]

2025-05-12 Thread via GitHub
xijiu opened a new pull request, #19698: URL: https://github.com/apache/kafka/pull/19698 Do not print the `"Unexpected error .."` log when the config `delete.topic.enable` is false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [WIP] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-05-12 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2874950686 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-05-12 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2874950649 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] KAFKA-19271: Add internal ConsumerWrapper [kafka]

2025-05-12 Thread via GitHub
mjsax opened a new pull request, #19697: URL: https://github.com/apache/kafka/pull/19697 With KIP-1071 enabled, the main consumer is created differently, side stepping `KafkaClientSupplier`. To allow injection test wrappers, we add an internal ConsumerWrapper, until we define a n

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-12 Thread via GitHub
FrankYang0529 commented on PR #19678: URL: https://github.com/apache/kafka/pull/19678#issuecomment-2874927815 @squah-confluent Why RangeSet doesn't throw IllegalArgumentException when to < from? Is any case may give this kind of input and we need it to ignore the error? Thanks. -- This i

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-12 Thread via GitHub
m1a2st commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2085742892 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeSetTest.java: ## @@ -32,16 +32,30 @@ public class RangeSetTest { +@Test +

Re: [PR] KAFKA-19082:[3/4] Add prepare txn method (KIP-939) [kafka]

2025-05-12 Thread via GitHub
rreddy-22 commented on code in PR #19539: URL: https://github.com/apache/kafka/pull/19539#discussion_r2085687333 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1904,5 +1933,15 @@ private PendingStateTransition( }

Re: [PR] KAFKA-19256: Only send IQ metadata on assignment changes [kafka]

2025-05-12 Thread via GitHub
mjsax commented on code in PR #19691: URL: https://github.com/apache/kafka/pull/19691#discussion_r2085659458 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsRebalanceData.java: ## @@ -355,6 +357,9 @@ public Map subtopologies() { return subtop

[jira] [Commented] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-12 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951069#comment-17951069 ] Travis Bischel commented on KAFKA-19233: I rewired the guts of the client to del

Re: [PR] KAFKA-19116, KAFKA-19258: Handling share group member change events [kafka]

2025-05-12 Thread via GitHub
apoorvmittal10 commented on code in PR #19666: URL: https://github.com/apache/kafka/pull/19666#discussion_r2085659033 ## core/src/main/java/kafka/server/share/SharePartitionCache.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19116, KAFKA-19258: Handling share group member change events [kafka]

2025-05-12 Thread via GitHub
apoorvmittal10 commented on code in PR #19666: URL: https://github.com/apache/kafka/pull/19666#discussion_r2085658297 ## core/src/main/java/kafka/server/share/SharePartitionCache.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19116, KAFKA-19258: Handling share group member change events [kafka]

2025-05-12 Thread via GitHub
apoorvmittal10 commented on code in PR #19666: URL: https://github.com/apache/kafka/pull/19666#discussion_r2085658136 ## core/src/main/java/kafka/server/share/SharePartitionCache.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19082:[3/4] Add prepare txn method (KIP-939) [kafka]

2025-05-12 Thread via GitHub
rreddy-22 commented on code in PR #19539: URL: https://github.com/apache/kafka/pull/19539#discussion_r2085651776 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1904,5 +1933,15 @@ private PendingStateTransition( }

[jira] [Commented] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951065#comment-17951065 ] Lianet Magrans commented on KAFKA-19233: Hey [~twmb] , sorry busy lately but cat

Re: [PR] [WIP] KAFKA-19042: move GroupAuthorizerIntegrationTest to clients-integration-tests module [kafka]

2025-05-12 Thread via GitHub
keemsisi commented on code in PR #19685: URL: https://github.com/apache/kafka/pull/19685#discussion_r2085622584 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/security/GroupAuthorizerIntegrationTest.java: ## @@ -0,0 +1,464 @@ +/* + * Licensed to the

[PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-12 Thread via GitHub
ahuang98 opened a new pull request, #19696: URL: https://github.com/apache/kafka/pull/19696 Reviewers: Colin P. McCabe ``` Conflicts: checkstyle/import-control.xml - different surrounding imports clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCreden

[PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-12 Thread via GitHub
ahuang98 opened a new pull request, #19695: URL: https://github.com/apache/kafka/pull/19695 Reviewers: Colin P. McCabe ``` Conflicts: checkstyle/import-control.xml - different surrounding imports clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCreden

[PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-12 Thread via GitHub
ahuang98 opened a new pull request, #19693: URL: https://github.com/apache/kafka/pull/19693 Reviewers: Colin P. McCabe ``` Conflicts: checkstyle/import-control.xml - different surrounding imports clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCreden

[PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-12 Thread via GitHub
ahuang98 opened a new pull request, #19694: URL: https://github.com/apache/kafka/pull/19694 Reviewers: Colin P. McCabe ``` Conflicts: checkstyle/import-control.xml - different surrounding imports clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCreden

[jira] [Updated] (KAFKA-19272) Handling different scenarios for initPid(keepPrepared=true)

2025-05-12 Thread Ritika Reddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritika Reddy updated KAFKA-19272: - Description: When initPid(keepPrepared = true) is called when a client crashes, there are quite

Re: [PR] KAFKA-19082:[3/4] Add prepare txn method (KIP-939) [kafka]

2025-05-12 Thread via GitHub
rreddy-22 commented on code in PR #19539: URL: https://github.com/apache/kafka/pull/19539#discussion_r2085600309 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1453,7 +1481,15 @@ public void handleResponse(AbstractResponse re

[jira] [Created] (KAFKA-19272) Handling different scenarios for initPid(keepPrepared=true)

2025-05-12 Thread Ritika Reddy (Jira)
Ritika Reddy created KAFKA-19272: Summary: Handling different scenarios for initPid(keepPrepared=true) Key: KAFKA-19272 URL: https://issues.apache.org/jira/browse/KAFKA-19272 Project: Kafka

[jira] [Commented] (KAFKA-19233) Members cannot rejoin with epoch=0 for KIP-848

2025-05-12 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951059#comment-17951059 ] Travis Bischel commented on KAFKA-19233: I've released franz-go v1.19 opting out

[jira] [Updated] (KAFKA-16394) ForeignKey LEFT join propagates null value on foreignKey change

2025-05-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16394: Priority: Minor (was: Major) > ForeignKey LEFT join propagates null value on foreignKey c

[PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-12 Thread via GitHub
ahuang98 opened a new pull request, #19692: URL: https://github.com/apache/kafka/pull/19692 Reviewers: Colin P. McCabe ``` Conflicts: clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java - import statement clients/src/main/java/

[jira] [Updated] (KAFKA-18345) Investigate if binaryExponentialElectionBackoffMs can be removed or improved

2025-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18345: --- Fix Version/s: 3.8.2 3.9.2 4.0.

Re: [PR] KAFKA-18345; Prevent livelocked elections [kafka]

2025-05-12 Thread via GitHub
jsancio merged PR #19658: URL: https://github.com/apache/kafka/pull/19658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19256: Only send IQ metadata on assignment changes [kafka]

2025-05-12 Thread via GitHub
bbejeck commented on code in PR #19691: URL: https://github.com/apache/kafka/pull/19691#discussion_r2085379528 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1983,8 +1984,16 @@ private CoordinatorResult stream Str

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-12 Thread via GitHub
lianetm commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2085329910 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/DefaultJwtValidator.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache So

Re: [PR] KAFKA-19256: Only send IQ metadata on assignment changes [kafka]

2025-05-12 Thread via GitHub
bbejeck commented on code in PR #19691: URL: https://github.com/apache/kafka/pull/19691#discussion_r2085305508 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1993,6 +2002,7 @@ private CoordinatorResult stream

Re: [PR] KAFKA-19034: [1/N] Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module [kafka]

2025-05-12 Thread via GitHub
apalan60 commented on PR #19681: URL: https://github.com/apache/kafka/pull/19681#issuecomment-2873812003 > Thank @apalan60 for this patch, left some comments @m1a2st Thanks for your review. I’ve made the corresponding changes. PTAL! -- This is an automated message from the A

Re: [PR] KAFKA-19034: [1/N] Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module [kafka]

2025-05-12 Thread via GitHub
apalan60 commented on code in PR #19681: URL: https://github.com/apache/kafka/pull/19681#discussion_r2085347732 ## storage/src/test/java/org/apache/kafka/admin/RemoteTopicCrudTest.java: ## @@ -0,0 +1,833 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

Re: [PR] KAFKA-19034: [1/N] Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module [kafka]

2025-05-12 Thread via GitHub
apalan60 commented on code in PR #19681: URL: https://github.com/apache/kafka/pull/19681#discussion_r2085346384 ## storage/src/test/java/org/apache/kafka/admin/RemoteTopicCrudTest.java: ## @@ -0,0 +1,833 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[jira] [Commented] (KAFKA-9199) Improve handling of out of sequence errors lower than last acked sequence

2025-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951044#comment-17951044 ] José Armando García Sancio commented on KAFKA-9199: --- When fixing the is

[jira] [Updated] (KAFKA-9199) Improve handling of out of sequence errors lower than last acked sequence

2025-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-9199: -- Component/s: clients > Improve handling of out of sequence errors lower

[jira] [Commented] (KAFKA-18905) Avoid out of order sequence errors from multiple in-flight batches

2025-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951043#comment-17951043 ] José Armando García Sancio commented on KAFKA-18905: When fixing the

Re: [PR] KAFKA-18905; Disable idempotent producer to remove test flakiness [kafka]

2025-05-12 Thread via GitHub
jsancio merged PR #19644: URL: https://github.com/apache/kafka/pull/19644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19256: Only send IQ metadata on assignment changes [kafka]

2025-05-12 Thread via GitHub
bbejeck commented on PR #19691: URL: https://github.com/apache/kafka/pull/19691#issuecomment-2873740208 @aliehsaeedii PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-19256: Only send IQ metadata on assignment changes [kafka]

2025-05-12 Thread via GitHub
bbejeck commented on code in PR #19691: URL: https://github.com/apache/kafka/pull/19691#discussion_r2085303970 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1983,8 +1984,16 @@ private CoordinatorResult stream Str

[jira] [Assigned] (KAFKA-13447) Consumer should not reuse committed offset after topic recreation

2025-05-12 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-13447: --- Assignee: David Jacot (was: Philip Nee) > Consumer should not reuse committed offset after

[PR] KAFKA-19256: Only send iq on assignment changes [kafka]

2025-05-12 Thread via GitHub
bbejeck opened a new pull request, #19691: URL: https://github.com/apache/kafka/pull/19691 This PR adds changes, so the IQ endpoint information is only sent to streams group members when there has been a change in the assignments requiring an update in the streams client host-partition owne

Re: [PR] KAFKA-14691; Add TopicId to OffsetFetch API [kafka]

2025-05-12 Thread via GitHub
dajac commented on code in PR #19515: URL: https://github.com/apache/kafka/pull/19515#discussion_r2085294443 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java: ## @@ -52,13 +54,37 @@ public static class Builder extends AbstractRequest.Builder

Re: [PR] KAFKA-14691; Add TopicId to OffsetFetch API [kafka]

2025-05-12 Thread via GitHub
dajac commented on code in PR #19515: URL: https://github.com/apache/kafka/pull/19515#discussion_r2085263820 ## core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala: ## @@ -1197,15 +1201,17 @@ class ConsumerProtocolMigrationTest(cluster: ClusterInstance) ex

Re: [PR] KAFKA-14691; Add TopicId to OffsetFetch API [kafka]

2025-05-12 Thread via GitHub
dajac commented on code in PR #19515: URL: https://github.com/apache/kafka/pull/19515#discussion_r2085262516 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -8349,23 +8377,168 @@ class KafkaApisTest extends Logging { .setGroupId("group-4") .

Re: [PR] KAFKA-14691; Add TopicId to OffsetFetch API [kafka]

2025-05-12 Thread via GitHub
dajac commented on code in PR #19515: URL: https://github.com/apache/kafka/pull/19515#discussion_r2085256581 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -8269,6 +8276,7 @@ class KafkaApisTest extends Logging { .setGroupId("group-1")

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-12 Thread via GitHub
kirktrue commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2085243526 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerLoginCallbackHandler.java: ## @@ -179,55 +180,45 @@ public class OAuthBearerLoginCallb

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-12 Thread via GitHub
kirktrue commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2085243145 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerLoginCallbackHandler.java: ## @@ -179,55 +180,45 @@ public class OAuthBearerLoginCallb

Re: [PR] MINOR: Fix version in 4.0 branch [kafka]

2025-05-12 Thread via GitHub
dajac merged PR #19686: URL: https://github.com/apache/kafka/pull/19686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-12 Thread via GitHub
ahuang98 opened a new pull request, #19690: URL: https://github.com/apache/kafka/pull/19690 Reviewers: Colin P. McCabe ``` Conflicts: clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java - import statement clients/src/main/java/

Re: [PR] KAFKA-18666: Controller-side monitoring for broker shutdown and startup [kafka]

2025-05-12 Thread via GitHub
cmccabe commented on code in PR #19586: URL: https://github.com/apache/kafka/pull/19586#discussion_r2085194087 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1781,6 +1782,7 @@ public CompletableFuture unregisterBroker( ControllerRequ

Re: [PR] KAFKA-18666: Controller-side monitoring for broker shutdown and startup [kafka]

2025-05-12 Thread via GitHub
cmccabe commented on code in PR #19586: URL: https://github.com/apache/kafka/pull/19586#discussion_r2085194087 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1781,6 +1782,7 @@ public CompletableFuture unregisterBroker( ControllerRequ

Re: [PR] KAFKA-18666: Controller-side monitoring for broker shutdown and startup [kafka]

2025-05-12 Thread via GitHub
cmccabe commented on code in PR #19586: URL: https://github.com/apache/kafka/pull/19586#discussion_r2085194500 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1928,6 +1930,7 @@ public CompletableFuture processBrokerHeartbeat( Control

[PR] MINOR: Fix some Request toString methods (#19655) [kafka]

2025-05-12 Thread via GitHub
ahuang98 opened a new pull request, #19689: URL: https://github.com/apache/kafka/pull/19689 Reviewers: Colin P. McCabe ``` Conflicts: clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java - import statement clients/src/main/java/o

[jira] [Commented] (KAFKA-18961) Consider time-based refresh for server-side RE2J regex

2025-05-12 Thread Sean Quah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17951026#comment-17951026 ] Sean Quah commented on KAFKA-18961: --- It looks like the metadata image mechanism also l

[jira] [Created] (KAFKA-19271) Private interface for injecting test wrappers for KIP-1071 enabled consumers

2025-05-12 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19271: -- Summary: Private interface for injecting test wrappers for KIP-1071 enabled consumers Key: KAFKA-19271 URL: https://issues.apache.org/jira/browse/KAFKA-19271 Proj

Re: [PR] KAFKA-19208: KStream-GlobalKTable join should not drop left-null-key record [kafka]

2025-05-12 Thread via GitHub
mjsax commented on code in PR #19580: URL: https://github.com/apache/kafka/pull/19580#discussion_r2085137272 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKTableLeftJoinTest.java: ## @@ -45,7 +47,13 @@ import java.util.Random; import java.util.Set;

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-12 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2085136665 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -176,8 +178,18 @@ public boolean equals(Object o) { @

Re: [PR] KAFKA-19208: KStream-GlobalKTable join should not drop left-null-key record [kafka]

2025-05-12 Thread via GitHub
mjsax commented on code in PR #19580: URL: https://github.com/apache/kafka/pull/19580#discussion_r2085135474 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -150,7 +150,7 @@ private boolean maybeDropRecord(final Record r

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-12 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2085132731 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -44,6 +44,7 @@ public RangeSet(int from, int to) { @O

Re: [PR] MINOR: Minor updates to RangeSet [kafka]

2025-05-12 Thread via GitHub
squah-confluent commented on code in PR #19678: URL: https://github.com/apache/kafka/pull/19678#discussion_r2085134123 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeSet.java: ## @@ -44,6 +44,7 @@ public RangeSet(int from, int to) { @O

[jira] [Resolved] (KAFKA-19051) Fix implicit acknowledgement cannot be overridden when RecordDeserializationException occurs

2025-05-12 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19051. -- Resolution: Won't Fix Reviewing this issue, it is clear that the behaviour suggested i

Re: [PR] KAFKA-14691; Add TopicId to OffsetFetch API [kafka]

2025-05-12 Thread via GitHub
lianetm commented on code in PR #19515: URL: https://github.com/apache/kafka/pull/19515#discussion_r2084965325 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java: ## @@ -52,13 +54,37 @@ public static class Builder extends AbstractRequest.Builder

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-12 Thread via GitHub
junrao commented on code in PR #19635: URL: https://github.com/apache/kafka/pull/19635#discussion_r2085112789 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -923,8 +925,56 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegrat

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-12 Thread via GitHub
jsancio commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2085093925 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2771,16 +2776,17 @@ private RequestSendResult maybeSendRequest( Supplier requestSuppli

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-12 Thread via GitHub
kevin-wu24 commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2085111709 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2771,16 +2776,17 @@ private RequestSendResult maybeSendRequest( Supplier requestSup

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-12 Thread via GitHub
chia7712 commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2085105937 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -154,40 +157,40 @@ class RemoteLeaderEndPoint(logPrefix: String, val tp = new TopicPar

Re: [PR] MINOR: Add deprecation of listConsumerGroups to upgrade.html [kafka]

2025-05-12 Thread via GitHub
AndrewJSchofield merged PR #19684: URL: https://github.com/apache/kafka/pull/19684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19255: KRaft request manager should support one in-flight request per request type [kafka]

2025-05-12 Thread via GitHub
jsancio commented on code in PR #19668: URL: https://github.com/apache/kafka/pull/19668#discussion_r2085093925 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2771,16 +2776,17 @@ private RequestSendResult maybeSendRequest( Supplier requestSuppli

Re: [PR] MINOR: Fix unchecked type warnings in several test classes [kafka]

2025-05-12 Thread via GitHub
chia7712 commented on code in PR #19679: URL: https://github.com/apache/kafka/pull/19679#discussion_r2085087191 ## clients/src/test/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandlerTest.java: ## @@ -158,7 +158,7 @@ public void testBuildRequestWithMult

Re: [PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-12 Thread via GitHub
junrao commented on code in PR #19661: URL: https://github.com/apache/kafka/pull/19661#discussion_r2085075108 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -54,33 +54,52 @@ public class FileRecords extends AbstractRecords implements Closeable {

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-12 Thread via GitHub
jsancio commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2085061929 ## raft/src/main/java/org/apache/kafka/raft/RaftUtil.java: ## @@ -755,4 +756,18 @@ static boolean hasValidTopicPartition(DescribeQuorumRequestData data, TopicParti

[PR] MINOR: Improve client error messages for share groups not enabled [kafka]

2025-05-12 Thread via GitHub
AndrewJSchofield opened a new pull request, #19688: URL: https://github.com/apache/kafka/pull/19688 As mentioned in https://github.com/apache/kafka/pull/19378#pullrequestreview-2775598123, the error messages for a 4.1 share consumer could be clearer for the different cases for when it cann

[jira] [Assigned] (KAFKA-19270) Remove optional from ClusterInstance#controllerListenerName

2025-05-12 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ming-Yen Chung reassigned KAFKA-19270: -- Assignee: Ming-Yen Chung (was: Chia-Ping Tsai) > Remove optional from ClusterInstanc

[jira] [Created] (KAFKA-19270) Remove optional from ClusterInstance#controllerListenerName

2025-05-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19270: -- Summary: Remove optional from ClusterInstance#controllerListenerName Key: KAFKA-19270 URL: https://issues.apache.org/jira/browse/KAFKA-19270 Project: Kafka

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-12 Thread via GitHub
m1a2st commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2085007139 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerValidatorCallbackHandler.java: ## @@ -135,37 +134,36 @@ public void configure(Map config

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-12 Thread via GitHub
m1a2st commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2085006260 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerLoginCallbackHandler.java: ## @@ -179,55 +180,45 @@ public class OAuthBearerLoginCallbac

[PR] KAFKA-19260: Move LoggingController to server module [kafka]

2025-05-12 Thread via GitHub
yunchipang opened a new pull request, #19687: URL: https://github.com/apache/kafka/pull/19687 jira: [KAFKA-19260](https://issues.apache.org/jira/browse/KAFKA-19260) Move `LoggingController` to server module and rewrite it in java. -- This is an automated message from the Apache Git

Re: [PR] [KAFKA-18905] Reduce ReassignPartitionTest flakiness [kafka]

2025-05-12 Thread via GitHub
jsancio commented on code in PR #19644: URL: https://github.com/apache/kafka/pull/19644#discussion_r2084990240 ## tests/kafkatest/tests/core/reassign_partitions_test.py: ## @@ -163,7 +163,8 @@ def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, me

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-12 Thread via GitHub
omkreddy commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2084977349 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerLoginCallbackHandler.java: ## @@ -179,55 +180,45 @@ public class OAuthBearerLoginCallb

Re: [PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-12 Thread via GitHub
jsancio commented on code in PR #19661: URL: https://github.com/apache/kafka/pull/19661#discussion_r2084959860 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -54,33 +54,55 @@ public class FileRecords extends AbstractRecords implements Closeable

Re: [PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-12 Thread via GitHub
jsancio commented on code in PR #19661: URL: https://github.com/apache/kafka/pull/19661#discussion_r2084959174 ## clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java: ## @@ -149,10 +144,29 @@ public void testIterator(Args args) { new SimpleRe

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-12 Thread via GitHub
jsancio commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2082461965 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState state, long currentTimeM

Re: [PR] KAFKA-19242: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-12 Thread via GitHub
ejba commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2873000657 Thanks @chickenchickenlove @dajac @injae-kim -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] MINOR: Fix version in 4.0 branch [kafka]

2025-05-12 Thread via GitHub
dajac opened a new pull request, #19686: URL: https://github.com/apache/kafka/pull/19686 This patch fixes the version used in the `4.0` branch. It should be `4.0.1` instead of `4.1.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] KAFKA-19242: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-12 Thread via GitHub
dajac commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2872964388 Merged to trunk, 4.0 and 3.9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Resolved] (KAFKA-19242) Fix commit bugs caused by race condition during rebalancing.

2025-05-12 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-19242. - Fix Version/s: 3.9.2 4.0.1 4.1.0 Resolution: Fixed

[jira] [Commented] (KAFKA-19267) the min version used by ListOffsetsRequest should be 1 rather than 0

2025-05-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950992#comment-17950992 ] Chia-Ping Tsai commented on KAFKA-19267: {quote} We should replace the hardcoded

Re: [PR] KAFKA-19242: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-12 Thread via GitHub
dajac merged PR #19631: URL: https://github.com/apache/kafka/pull/19631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] MINOR: Add deprecation of listConsumerGroups to upgrade.html [kafka]

2025-05-12 Thread via GitHub
AndrewJSchofield opened a new pull request, #19684: URL: https://github.com/apache/kafka/pull/19684 As part of KIP-1043, `Admin.listConsumerGroups()` and variants have been deprecated. This is because there are now 4 types of group and listing has been consolidated under `Admin.listGroups()

  1   2   >