cmccabe commented on code in PR #19586:
URL: https://github.com/apache/kafka/pull/19586#discussion_r2085194087
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1781,6 +1782,7 @@ public CompletableFuture<Void> unregisterBroker(
ControllerRequestContext context,
int brokerId
) {
+ controllerMetrics.removeTimeSinceLastHeartbeatMetric(brokerId);
Review Comment:
In order to prevent the wrong thing getting unregistered, it seems like we
should check the broker epoch here.
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1928,6 +1930,7 @@ public CompletableFuture<BrokerHeartbeatReply>
processBrokerHeartbeat(
ControllerRequestContext context,
BrokerHeartbeatRequestData request
) {
+ controllerMetrics.updateBrokerContactTime(request.brokerId());
Review Comment:
This should include the broker epoch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
