mjsax commented on code in PR #19580:
URL: https://github.com/apache/kafka/pull/19580#discussion_r2085135474
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java:
##########
@@ -150,7 +150,7 @@ private boolean maybeDropRecord(final Record<StreamKey,
StreamValue> record) {
// furthermore, on left/outer joins 'null' in ValueJoiner#apply()
indicates a missing record --
// thus, to be consistent and to avoid ambiguous null semantics, null
values are ignored
final TableKey mappedKey = keyMapper.apply(record.key(),
record.value());
- if (leftJoin && record.key() == null && record.value() != null) {
+ if (leftJoin && mappedKey == null && record.value() != null) {
Review Comment:
What other join types do you have in mind? Can you elaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
