jsancio commented on code in PR #19668:
URL: https://github.com/apache/kafka/pull/19668#discussion_r2085093925
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2771,16 +2776,17 @@ private RequestSendResult maybeSendRequest(
Supplier<ApiMessage> requestSupplier
) {
var requestSent = false;
+ final var request = requestSupplier.get();
+ final var api = ApiKeys.forId(request.apiKey());
Review Comment:
In the past, KRaft only constructed the request when it was guarantee that
they would be sent. This changes that. Can we keep the previous logic which
only creates a request when the request will be sent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
