sjhajharia opened a new pull request, #19380:
URL: https://github.com/apache/kafka/pull/19380
Now that Kafka Brokers support Java 17, this PR makes some changes in core
module. The changes in this PR are limited to only the Scala files in the Core
module's tests. The unit tests module is st
chia7712 merged PR #19072:
URL: https://github.com/apache/kafka/pull/19072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield commented on code in PR #19247:
URL: https://github.com/apache/kafka/pull/19247#discussion_r2005360228
##
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##
@@ -6648,6 +6648,15 @@ public void
testAcquireWhenBatchesRemovedForFetchOffsetForSameCach
[
https://issues.apache.org/jira/browse/KAFKA-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939589#comment-17939589
]
Daniel Fonai commented on KAFKA-18874:
--
I think we might have found the root cause.
adixitconfluent commented on code in PR #19261:
URL: https://github.com/apache/kafka/pull/19261#discussion_r2026362292
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2484,6 +2505,174 @@ private long startOffsetDuringInitialization(long
partitionDataStartOf
github-actions[bot] commented on PR #15009:
URL: https://github.com/apache/kafka/pull/15009#issuecomment-2780176518
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #16220:
URL: https://github.com/apache/kafka/pull/16220#issuecomment-2780176568
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #15876:
URL: https://github.com/apache/kafka/pull/15876#issuecomment-2780176549
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #15693:
URL: https://github.com/apache/kafka/pull/15693#issuecomment-2780176545
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #15929:
URL: https://github.com/apache/kafka/pull/15929#issuecomment-2780176557
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2780176535
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #15020:
URL: https://github.com/apache/kafka/pull/15020#issuecomment-2780176526
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #19220:
URL: https://github.com/apache/kafka/pull/19220#issuecomment-2780168765
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19236:
URL: https://github.com/apache/kafka/pull/19236#issuecomment-2780168744
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19306:
URL: https://github.com/apache/kafka/pull/19306#issuecomment-2780168709
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
PoAn Yang created KAFKA-19092:
-
Summary: Flaky test
QuorumControllerTest#testBalancePartitionLeaders
Key: KAFKA-19092
URL: https://issues.apache.org/jira/browse/KAFKA-19092
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941188#comment-17941188
]
PoAn Yang commented on KAFKA-19091:
---
Failed pipeline:
https://github.com/apache/kafka
PoAn Yang created KAFKA-19091:
-
Summary: Flaky test DelayedFutureTest#testDelayedFuture
Key: KAFKA-19091
URL: https://issues.apache.org/jira/browse/KAFKA-19091
Project: Kafka
Issue Type: Test
Rancho-7 commented on code in PR #19347:
URL: https://github.com/apache/kafka/pull/19347#discussion_r2029669057
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -38,12 +34,6 @@
import java.util.function.Consumer;
import jav
PoAn Yang created KAFKA-19090:
-
Summary: Move DelayedFuture and DelayedFuturePurgatory to server
module
Key: KAFKA-19090
URL: https://issues.apache.org/jira/browse/KAFKA-19090
Project: Kafka
Iss
Rancho-7 commented on code in PR #19347:
URL: https://github.com/apache/kafka/pull/19347#discussion_r2029669057
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -38,12 +34,6 @@
import java.util.function.Consumer;
import jav
[
https://issues.apache.org/jira/browse/KAFKA-18997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang updated KAFKA-18997:
--
Parent: KAFKA-15852
Issue Type: Sub-task (was: Improvement)
> Move ConfigHelper to server mod
[
https://issues.apache.org/jira/browse/KAFKA-18998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang updated KAFKA-18998:
--
Parent: KAFKA-15852
Issue Type: Sub-task (was: Improvement)
> Move AuthHelper to server modul
Chia-Ping Tsai created KAFKA-19004:
--
Summary: Move DelayedDeleteRecords to server-common module
Key: KAFKA-19004
URL: https://issues.apache.org/jira/browse/KAFKA-19004
Project: Kafka
Issue T
mimaison commented on code in PR #19050:
URL: https://github.com/apache/kafka/pull/19050#discussion_r2028335989
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/metadata/KRaftMetadataRequestBenchmark.java:
##
@@ -94,8 +94,8 @@
@State(Scope.Benchmark)
@Fork(value = 1)
-@W
m1a2st commented on PR #18930:
URL: https://github.com/apache/kafka/pull/18930#issuecomment-2780157473
> I don't know exactly how config.provider works from top of my head. Can
you give a TL;DR? Would like to understand to what extend it applies to KS and
if it would work as expected w/o an
m1a2st commented on PR #18930:
URL: https://github.com/apache/kafka/pull/18930#issuecomment-2780153869
Hi @mjsax, thanks for your review, I believe this change is simply updating
the documentation for something we've been missing. I wrote a simple demo using
a Kafka consumer with `config.pr
ableegoldman commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r2029660460
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##
@@ -469,8 +493,17 @@ public int joinGroupEpoch() {
*/
chia7712 commented on PR #19167:
URL: https://github.com/apache/kafka/pull/19167#issuecomment-2780150409
@frankvicky this PR is not urgent, so it can be your first "merged" PR by
yourself 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ableegoldman commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r2029656317
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManager.java:
##
@@ -469,8 +493,17 @@ public int joinGroupEpoch() {
*/
ableegoldman commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r2029654165
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerHeartbeatRequestManager.java:
##
@@ -211,6 +214,29 @@ public ConsumerMembershipManager
ableegoldman commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r2029652347
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerHeartbeatRequestManager.java:
##
@@ -211,6 +214,29 @@ public ConsumerMembershipManager
FrankYang0529 commented on code in PR #19345:
URL: https://github.com/apache/kafka/pull/19345#discussion_r2029643749
##
core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala:
##
@@ -441,7 +441,29 @@ class RemoteTopicCrudTest extends IntegrationTestHarness {
m1a2st commented on code in PR #19068:
URL: https://github.com/apache/kafka/pull/19068#discussion_r2029637899
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/server/quota/CustomQuotaCallbackTest.java:
##
@@ -69,10 +70,42 @@ public void testCustomQuotaCallback
ijuma commented on code in PR #19316:
URL: https://github.com/apache/kafka/pull/19316#discussion_r2021657292
##
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##
@@ -161,15 +157,6 @@ class ReplicaFetcherThread(name: String,
}
}
- private def maybeWarnIfO
mjsax commented on code in PR #18930:
URL: https://github.com/apache/kafka/pull/18930#discussion_r2029612516
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1236,7 +1236,11 @@ public class StreamsConfig extends AbstractConfig {
T
mjsax commented on PR #18371:
URL: https://github.com/apache/kafka/pull/18371#issuecomment-2779997645
Seems we need to revert all KS related changed, as KS is still on Java 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
mjsax commented on PR #16554:
URL: https://github.com/apache/kafka/pull/16554#issuecomment-2779989694
@abhi-ksolves -- What is the status of this PR? Are you still interested to
finish it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
mjsax commented on code in PR #18816:
URL: https://github.com/apache/kafka/pull/18816#discussion_r2029593389
##
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java:
##
@@ -89,8 +95,81 @@ public class ChangeLoggingKeyValueBytesS
[
https://issues.apache.org/jira/browse/KAFKA-19006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941108#comment-17941108
]
oshione gabriel esiemokhai commented on KAFKA-19006:
do you have any
chia7712 commented on code in PR #19316:
URL: https://github.com/apache/kafka/pull/19316#discussion_r2022845482
##
core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala:
##
@@ -203,7 +203,7 @@ class RemoteLeaderEndPoint(logPrefix: String,
None
} else {
v
bbejeck merged PR #18953:
URL: https://github.com/apache/kafka/pull/18953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
chia7712 commented on code in PR #19366:
URL: https://github.com/apache/kafka/pull/19366#discussion_r2027523376
##
clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java:
##
@@ -34,6 +34,7 @@
* The callback may be executed in any thread call
mjsax commented on code in PR #19219:
URL: https://github.com/apache/kafka/pull/19219#discussion_r2029560159
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8148,7 +8174,10 @@ private TaskAssignor streamsGroupAssignor(Strin
mjsax commented on code in PR #19219:
URL: https://github.com/apache/kafka/pull/19219#discussion_r2029562373
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -18070,6 +18241,101 @@ public void testShareGroupDynamicConfigs
[
https://issues.apache.org/jira/browse/KAFKA-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940129#comment-17940129
]
Lianet Magrans commented on KAFKA-19067:
Hey [~yangpoan] , thanks for filing! I'
mjsax commented on code in PR #19219:
URL: https://github.com/apache/kafka/pull/19219#discussion_r2029559949
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -8148,7 +8174,10 @@ private TaskAssignor streamsGroupAssignor(Strin
mjsax commented on code in PR #19219:
URL: https://github.com/apache/kafka/pull/19219#discussion_r2029561158
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -17848,6 +17921,104 @@ public void testStreamsRebalanceTimeoutE
mjsax commented on code in PR #19303:
URL: https://github.com/apache/kafka/pull/19303#discussion_r2029558102
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplierTest.java:
##
@@ -316,6 +367,21 @@ public void innerJo
mjsax commented on code in PR #19303:
URL: https://github.com/apache/kafka/pull/19303#discussion_r2029556963
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java:
##
@@ -143,28 +143,25 @@ private void leftJoinI
[
https://issues.apache.org/jira/browse/KAFKA-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940498#comment-17940498
]
黃竣陽 commented on KAFKA-19080:
-
Hello [~junrao], If you won't work on this, may I take it?
>
[
https://issues.apache.org/jira/browse/KAFKA-18276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18276.
Resolution: Fixed
> Migrate ProducerRebootstrapTest to new test infra
> --
[
https://issues.apache.org/jira/browse/KAFKA-19056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming-Yen Chung reassigned KAFKA-19056:
--
Assignee: Ming-Yen Chung (was: Chia-Ping Tsai)
> Move EndToEndClusterIdTest to serve
[
https://issues.apache.org/jira/browse/KAFKA-12410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
TaiJuWu reassigned KAFKA-12410:
---
Assignee: TaiJuWu (was: Chia-Ping Tsai)
> KafkaAPis ought to group fetch data before generating fe
github-actions[bot] closed pull request #18006: Change testing for git command
in Compatibility Checker
URL: https://github.com/apache/kafka/pull/18006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941095#comment-17941095
]
oshione gabriel esiemokhai commented on KAFKA-19079:
okay so how do
AndrewJSchofield merged PR #19339:
URL: https://github.com/apache/kafka/pull/19339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
m1a2st commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2028861881
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -349,8 +348,8 @@ class RequestChannel(val queueSize: Int,
private val requestQueue = new ArrayBlock
AyoubOm commented on code in PR #15607:
URL: https://github.com/apache/kafka/pull/15607#discussion_r2029522029
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##
@@ -203,26 +206,26 @@ public void doJ
AyoubOm commented on code in PR #19303:
URL: https://github.com/apache/kafka/pull/19303#discussion_r2029469412
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java:
##
@@ -143,28 +143,25 @@ private void leftJoi
mumrah commented on PR #19242:
URL: https://github.com/apache/kafka/pull/19242#issuecomment-2743356688
> btw, do you plan to set PR Linter as blocker?
Eventually, yes. We'll want it to be a required check before we switch on
the merge queue.
> would it be feasible to extend it
[
https://issues.apache.org/jira/browse/KAFKA-13747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-13747.
-
Fix Version/s: 4.1.0
Resolution: Fixed
> refactor TopologyTest to test different
mjsax merged PR #19323:
URL: https://github.com/apache/kafka/pull/19323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
Tombert commented on code in PR #19366:
URL: https://github.com/apache/kafka/pull/19366#discussion_r2027530949
##
clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java:
##
@@ -34,6 +34,7 @@
* The callback may be executed in any thread calli
mjsax commented on code in PR #19234:
URL: https://github.com/apache/kafka/pull/19234#discussion_r2025460966
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNodePunctuator.java:
##
@@ -19,6 +19,7 @@
import org.apache.kafka.streams.processor.Punctu
chia7712 commented on code in PR #19030:
URL: https://github.com/apache/kafka/pull/19030#discussion_r2024799982
##
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##
@@ -55,6 +113,2288 @@ public class UnifiedLog {
public static final String STR
akonopko closed pull request #19350: Nexla kafka 2.8.1
URL: https://github.com/apache/kafka/pull/19350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j
bbejeck closed pull request #19326: MINOR: Improve error logging for task
commit failures
URL: https://github.com/apache/kafka/pull/19326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
AndrewJSchofield commented on code in PR #19329:
URL: https://github.com/apache/kafka/pull/19329#discussion_r2026942159
##
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##
@@ -885,6 +897,23 @@ class GroupCoordinatorBaseRequestTest(cluster:
Cluster
FrankYang0529 opened a new pull request, #19349:
URL: https://github.com/apache/kafka/pull/19349
There are lot of xyzRpcVersion which returning value by checking
RaftProtocol. It's better to include these functions in RaftProtocol itself.
--
This is an automated message from the Apache G
[
https://issues.apache.org/jira/browse/KAFKA-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936805#comment-17936805
]
Jakhongir Sabirovь edited comment on KAFKA-6333 at 3/19/25 12:12 PM:
--
smjn commented on code in PR #19339:
URL: https://github.com/apache/kafka/pull/19339#discussion_r2024659495
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -533,15 +555,38 @@ private
CompletableFuture performShareGroupSt
jeffkbkim commented on code in PR #17981:
URL: https://github.com/apache/kafka/pull/17981#discussion_r2029393164
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataStore.java:
##
@@ -0,0 +1,688 @@
+/*
+ * Licensed to the Apache Software Foundation
Rancho-7 commented on code in PR #19207:
URL: https://github.com/apache/kafka/pull/19207#discussion_r2006682952
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -875,7 +872,7 @@ public boolean cleanupExpiredOffsets(String gr
[
https://issues.apache.org/jira/browse/KAFKA-19004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-19004.
Fix Version/s: 4.1.0
Resolution: Fixed
> Move DelayedDeleteRecords to server-common
soondenana commented on code in PR #19353:
URL: https://github.com/apache/kafka/pull/19353#discussion_r2029411205
##
clients/src/main/java/org/apache/kafka/common/protocol/ReadableBuf.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
soondenana commented on code in PR #19353:
URL: https://github.com/apache/kafka/pull/19353#discussion_r2029411205
##
clients/src/main/java/org/apache/kafka/common/protocol/ReadableBuf.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
soondenana commented on code in PR #19353:
URL: https://github.com/apache/kafka/pull/19353#discussion_r2029411205
##
clients/src/main/java/org/apache/kafka/common/protocol/ReadableBuf.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
soondenana commented on code in PR #19353:
URL: https://github.com/apache/kafka/pull/19353#discussion_r2029411205
##
clients/src/main/java/org/apache/kafka/common/protocol/ReadableBuf.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-19011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-19011:
---
Labels: need-kip (was: )
> Improve EndToEndLatency
> ---
>
>
chia7712 merged PR #19259:
URL: https://github.com/apache/kafka/pull/19259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #18842:
URL: https://github.com/apache/kafka/pull/18842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-6416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen A updated KAFKA-6416:
-
Affects Version/s: 4.0.0
(was: 1.0.0)
> Create an official Kafka Helm chart fo
josefk31 commented on PR #19362:
URL: https://github.com/apache/kafka/pull/19362#issuecomment-2779688358
@FrankYang0529 Thanks for review - I've updated the code with suggestion.
Tests are still green. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the me
FrankYang0529 commented on code in PR #19376:
URL: https://github.com/apache/kafka/pull/19376#discussion_r2029047486
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##
@@ -3663,8 +3663,7 @@ public void testFetcherDontCacheAnyData() {
adixitconfluent opened a new pull request, #19261:
URL: https://github.com/apache/kafka/pull/19261
Delete this text and replace it with a detailed description of your change.
The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add s
[
https://issues.apache.org/jira/browse/KAFKA-18991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937467#comment-17937467
]
José Armando GarcÃa Sancio commented on KAFKA-18991:
Let's make sure
jeffkbkim commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2029386900
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupTest.java:
##
@@ -1106,4 +1106,33 @@ public void testIsSubscribedToTopic() {
[
https://issues.apache.org/jira/browse/KAFKA-19004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936388#comment-17936388
]
xuanzhang gong commented on KAFKA-19004:
hello , i will hanle this issue,plz ass
chia7712 commented on code in PR #19214:
URL: https://github.com/apache/kafka/pull/19214#discussion_r2005987706
##
clients/src/main/java/org/apache/kafka/common/record/FileRecords.java:
##
@@ -292,17 +292,43 @@ public int writeTo(TransferableChannel destChannel, int
offset, int
github-actions[bot] commented on PR #17830:
URL: https://github.com/apache/kafka/pull/17830#issuecomment-2774400201
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
TaiJuWu commented on code in PR #19286:
URL: https://github.com/apache/kafka/pull/19286#discussion_r2022583314
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -413,24 +418,19 @@ void
testRemoteLogMetadataManagerWithEndpointConfigOverridden() throws IOExc
[
https://issues.apache.org/jira/browse/KAFKA-18042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940838#comment-17940838
]
Justine Olshan commented on KAFKA-18042:
Hey [~taijuwu] if you would like to wor
TaiJuWu commented on code in PR #19286:
URL: https://github.com/apache/kafka/pull/19286#discussion_r2027851831
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -413,24 +418,19 @@ void
testRemoteLogMetadataManagerWithEndpointConfigOverridden() throws IOExc
chia7712 commented on PR #19320:
URL: https://github.com/apache/kafka/pull/19320#issuecomment-2768656521
> OffsetFetcherUtils also contains logic related to 0.10.x support. However,
I’m not sure if it aligns with the scope of the [JIRA
issue](https://issues.apache.org/jira/browse/KAFKA-1905
ijuma opened a new pull request, #19316:
URL: https://github.com/apache/kafka/pull/19316
The `metadataVersionSupplier` is unused after this - remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on PR #17871:
URL: https://github.com/apache/kafka/pull/17871#issuecomment-2746802035
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
[
https://issues.apache.org/jira/browse/KAFKA-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Dixit resolved KAFKA-19085.
---
Fix Version/s: 4.1.0
Resolution: Fixed
> SharePartitionManagerTest testMultipleConcur
m1a2st commented on code in PR #19345:
URL: https://github.com/apache/kafka/pull/19345#discussion_r2024038450
##
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##
@@ -81,7 +81,8 @@ public class TopicConfig {
public static final String REMOTE_LOG_ST
mjsax commented on code in PR #19269:
URL: https://github.com/apache/kafka/pull/19269#discussion_r2025427298
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java:
##
@@ -70,6 +70,7 @@ public class StreamsProducer {
private Producer prod
1 - 100 of 239 matches
Mail list logo
