m1a2st commented on code in PR #19374:
URL: https://github.com/apache/kafka/pull/19374#discussion_r2028861881
##########
core/src/main/scala/kafka/network/RequestChannel.scala:
##########
@@ -349,8 +348,8 @@ class RequestChannel(val queueSize: Int,
private val requestQueue = new ArrayBlockingQueue[BaseRequest](queueSize)
private val processors = new ConcurrentHashMap[Int, Processor]()
- private val requestQueueSizeMetricName =
metricNamePrefix.concat(RequestQueueSizeMetric)
- private val responseQueueSizeMetricName =
metricNamePrefix.concat(ResponseQueueSizeMetric)
+ private val requestQueueSizeMetricName = RequestQueueSizeMetric
+ private val responseQueueSizeMetricName = ResponseQueueSizeMetric
Review Comment:
We can merge these properties with `RequestChannel` L47, L48
```
private val RequestQueueSizeMetric = "RequestQueueSize"
private val ResponseQueueSizeMetric = "ResponseQueueSize"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
