ijuma commented on code in PR #19316:
URL: https://github.com/apache/kafka/pull/19316#discussion_r2021657292
##########
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##########
@@ -161,15 +157,6 @@ class ReplicaFetcherThread(name: String,
}
}
- private def maybeWarnIfOversizedRecords(records: MemoryRecords,
topicPartition: TopicPartition): Unit = {
- // oversized messages don't cause replication to fail from fetch request
version 3 (KIP-74)
- if (metadataVersionSupplier().fetchRequestVersion <= 2 &&
records.sizeInBytes > 0 && records.validBytes <= 0)
Review Comment:
I think you're saying that IBP 3.3 implies fetch request 13 or higher. That
makes sense, I pushed a commit that removes that check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
