mjsax commented on code in PR #19269:
URL: https://github.com/apache/kafka/pull/19269#discussion_r2025427298
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java:
##########
@@ -70,6 +70,7 @@ public class StreamsProducer {
private Producer<byte[], byte[]> producer;
private boolean transactionInFlight = false;
private boolean transactionInitialized = false;
+ private boolean resetDisabled = false;
Review Comment:
Let's hear from Sophie.
To me, "disabling the reset" is not really a feature of the producer, but a
feature of the `TaskManager` (and in transition the `ActiveTaskCreator` as a
helper class used by `TaskManager`). -- Given that only the `TaskManager`
decides if it wants to skip the re-initialization or not (and the `TaskManager`
does already skip the call by checking `streamsProducer.isResetDisabled()`),
it's unclear to my why we would push this flag inside `StreamsProducer`. It
seems to be an unnecessary "de-tour", and boilerplate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
