m1a2st commented on code in PR #19345:
URL: https://github.com/apache/kafka/pull/19345#discussion_r2024038450
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -81,7 +81,8 @@ public class TopicConfig {
public static final String REMOTE_LOG_STORAGE_ENABLE_CONFIG =
"remote.storage.enable";
public static final String REMOTE_LOG_STORAGE_ENABLE_DOC = "To enable
tiered storage for a topic, set this configuration as true. " +
- "You can not disable this config once it is enabled. It will be
provided in future versions.";
+ "Disable tiered storage by setting this configuration to false for
a tiered storage enabled topic. Setting this configuration to false " +
+ "must be accompanied by setting `remote.log.delete.on.disable` to
true";
Review Comment:
Maybe we can make it clearer like this:
To enable tiered storage for a topic, set this configuration to true. To
disable tiered storage for a topic that has it enabled, set this configuration
to false. When disabling, you must also set
<code>remote.log.delete.on.disable</code> to true."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
