Re: [PR] KAFKA-18396: Migrate log4j1 configuration to log4j2 in KafkaDockerWrapper [kafka]

2025-02-10 Thread via GitHub
omkreddy merged PR #18394: URL: https://github.com/apache/kafka/pull/18394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] (KAFKA-16996) The leastLoadedNode() function in kafka-client may choose a faulty node during the consumer thread starting and meanwhile one of the KAFKA server node is dead.

2025-02-10 Thread R Dheeraj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16996 ] R Dheeraj deleted comment on KAFKA-16996: --- was (Author: JIRAUSER307619): Hi [~chia7712], I'm new to Kafka open source.    > The leastLoadedNode() function in kafka-client may choose a faulty

[jira] [Commented] (KAFKA-16996) The leastLoadedNode() function in kafka-client may choose a faulty node during the consumer thread starting and meanwhile one of the KAFKA server node is dead.

2025-02-10 Thread R Dheeraj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925884#comment-17925884 ] R Dheeraj commented on KAFKA-16996: --- Hi [~chia7712], I'm new to Kafka open source.   

Re: [PR] KAFKA-18769: Improve leadership changes handling in ShareConsumeRequestManager. [kafka]

2025-02-10 Thread via GitHub
AndrewJSchofield commented on code in PR #18851: URL: https://github.com/apache/kafka/pull/18851#discussion_r1950358289 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -630,6 +665,21 @@ public CompletableFuture acknowle

[jira] [Commented] (KAFKA-18771) Flaky test KRaftClusterTest .testDescribeQuorumRequestToControllers

2025-02-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925877#comment-17925877 ] PoAn Yang commented on KAFKA-18771: --- Hi [~showuon], the test case was introduced by yo

[jira] [Assigned] (KAFKA-18031) Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt

2025-02-10 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18031: --- Assignee: TaiJuWu > Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt > -

[PR] MINOR: Fix log compaction system test [kafka]

2025-02-10 Thread via GitHub
dajac opened a new pull request, #18857: URL: https://github.com/apache/kafka/pull/18857 `log.segment.bytes` must be greater or equals to 1MB (KIP-1030). ``` SESSION REPORT (ALL TESTS) ducktape v

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-10 Thread via GitHub
frankvicky commented on code in PR #18737: URL: https://github.com/apache/kafka/pull/18737#discussion_r1950275122 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -818,6 +818,8 @@ void maybeReconcile() { retu

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on PR #18845: URL: https://github.com/apache/kafka/pull/18845#issuecomment-2649831949 @junrao Thanks for the review. I addressed your comments and/or replied within the relevant thread. I also pushed a couple of commits for changes I had in progress: (1) Use `MINIMUM_VERSION

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950222735 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -1524,31 +1507,6 @@ public void close() throws Exception {

[jira] [Commented] (KAFKA-17537) Remove deprecates methods from Joined class

2025-02-10 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925846#comment-17925846 ] TengYao Chi commented on KAFKA-17537: - HI [~dheerajr]  Thanks for being interested

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950212652 ## core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java: ## @@ -380,7 +380,7 @@ public void testUpdateBrokerConfigNotAffectedByInvalidConfig() { @Cluste

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950212078 ## metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadataTest.java: ## @@ -126,13 +126,13 @@ public void testFeatureLevelForFeature() { static

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950210926 ## metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectoryTest.java: ## @@ -81,18 +81,17 @@ public void testReadFromEmptyConfiguration() throws Exc

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950210516 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIntegrationTest.scala: ## @@ -55,7 +55,7 @@ import scala.jdk.CollectionConverters._ class Produc

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950208594 ## core/src/test/scala/unit/kafka/server/AlterPartitionManagerTest.scala: ## @@ -552,24 +535,10 @@ class AlterPartitionManagerTest { } object AlterPartitionManagerTes

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950206038 ## server-common/src/main/java/org/apache/kafka/server/common/Feature.java: ## @@ -155,18 +155,16 @@ public FeatureVersion fromFeatureLevel(short level, * For examp

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950205574 ## metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java: ## @@ -56,7 +53,7 @@ public FeaturesImage( public boolean isEmpty() { return finalize

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950204878 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -137,10 +137,10 @@ static ControllerResult recordsForNonEmptyLog(

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950200566 ## metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectoryTest.java: ## @@ -81,18 +81,18 @@ public void testReadFromEmptyConfiguration() throws Exc

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950199486 ## server-common/src/main/java/org/apache/kafka/server/common/UnitTestFeatureVersion.java: ## @@ -321,7 +321,7 @@ public Map dependencies() { * The feature is used

[jira] [Commented] (KAFKA-17537) Remove deprecates methods from Joined class

2025-02-10 Thread R Dheeraj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925838#comment-17925838 ] R Dheeraj commented on KAFKA-17537: --- [~mjsax], have a look through the parent ticket.

Re: [PR] KAFKA-17937: Use ValueSource to refactor AbstractFetcherThreadTest to eliminate unnecessary skip tests [kafka]

2025-02-10 Thread via GitHub
github-actions[bot] commented on PR #17776: URL: https://github.com/apache/kafka/pull/17776#issuecomment-2649733070 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-02-10 Thread via GitHub
github-actions[bot] commented on PR #18789: URL: https://github.com/apache/kafka/pull/18789#issuecomment-2649711887 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-16717 [1/2]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-02-10 Thread via GitHub
JimmyWang6 commented on code in PR #18819: URL: https://github.com/apache/kafka/pull/18819#discussion_r1950131858 ## server/src/main/java/org/apache/kafka/network/RequestConvertToJson.java: ## @@ -559,6 +563,8 @@ public static JsonNode request(AbstractRequest request) {

[jira] [Resolved] (KAFKA-18441) Fix flaky KafkaAdminClientTest#testAdminClientApisAuthenticationFailure

2025-02-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-18441. --- Resolution: Fixed > Fix flaky KafkaAdminClientTest#testAdminClientApisAuthenticationFailure > --

[jira] [Commented] (KAFKA-18768) Backport KAFKA-806 to 4.0

2025-02-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925819#comment-17925819 ] PoAn Yang commented on KAFKA-18768: --- PR: https://github.com/apache/kafka/pull/18842 >

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-02-10 Thread via GitHub
kirktrue commented on PR #18795: URL: https://github.com/apache/kafka/pull/18795#issuecomment-2649651500 In the logs for the [latest Java 23 run](https://github.com/apache/kafka/actions/runs/13247421515/job/36977911422?pr=18795), I see this: ``` 2025-02-10T18:20:35.6249558Z 113 te

Re: [PR] KAFKA-16717 [1/2]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-02-10 Thread via GitHub
JimmyWang6 commented on PR #18819: URL: https://github.com/apache/kafka/pull/18819#issuecomment-2649648525 Hi @apoorvmittal10, I have Addressed all the comments. Please take a look when you get a chance. Much thanks. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-16717 [1/2]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-02-10 Thread via GitHub
JimmyWang6 commented on code in PR #18819: URL: https://github.com/apache/kafka/pull/18819#discussion_r1950126080 ## docs/security.html: ## @@ -2271,6 +2271,12 @@

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
junrao commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949804134 ## metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectoryTest.java: ## @@ -81,18 +81,18 @@ public void testReadFromEmptyConfiguration() throws Ex

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950100652 ## metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectoryTest.java: ## @@ -74,39 +73,21 @@ public void testReadFromEmptyConfiguration() throws Exc

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on PR #18845: URL: https://github.com/apache/kafka/pull/18845#issuecomment-2649590091 @chia7712 I addressed your comments except one (and left a reply explaining why). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
chia7712 commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950095803 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1652,9 +1652,7 @@ private void registerWriteNoOpRecord(long maxIdleIntervalNs) {

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950087565 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -86,12 +84,7 @@ BootstrapMetadata readFromConfiguration() { retu

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950090651 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1652,9 +1652,7 @@ private void registerWriteNoOpRecord(long maxIdleIntervalNs) {

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
chia7712 commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950084465 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java: ## @@ -128,18 +126,6 @@ public void testReassignment() throws Exception {

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950084549 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -86,12 +84,7 @@ BootstrapMetadata readFromConfiguration() { retu

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1950083279 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java: ## @@ -128,18 +126,6 @@ public void testReassignment() throws Exception {

Re: [PR] MINOR: upgrade ubuntu from trusty to bionic [kafka]

2025-02-10 Thread via GitHub
chia7712 closed pull request #18286: MINOR: upgrade ubuntu from trusty to bionic URL: https://github.com/apache/kafka/pull/18286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-18298;KAFKA-18297: Fix flaky testConsumerGroupsDeprecatedConsumerGroupState and testConsumerGroups in PlaintextAdminIntegrationTest [kafka]

2025-02-10 Thread via GitHub
chia7712 commented on PR #18513: URL: https://github.com/apache/kafka/pull/18513#issuecomment-2649496197 @chenyulin0719 could you please rebase code to include latest test fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Resolved] (KAFKA-18770) Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak)

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18770. Resolution: Fixed > Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTes

Re: [PR] KAFKA-18770: Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak) [kafka]

2025-02-10 Thread via GitHub
chia7712 merged PR #18853: URL: https://github.com/apache/kafka/pull/18853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18366) Remove KafkaConfig.interBrokerProtocolVersion

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18366. Resolution: Fixed trunk: [https://github.com/apache/kafka/commit/581e94840fd0503d46c36eb8

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-02-10 Thread via GitHub
junrao commented on PR #18795: URL: https://github.com/apache/kafka/pull/18795#issuecomment-2649488913 @kirktrue : Thanks for triaging the tests. In .github/actions/run-gradle/action.yml, it seems that we allow a max of 10 flaky failures. There were only 7 failed tests for java 23. Do you k

[jira] [Commented] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-02-10 Thread Nil Madhab (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925770#comment-17925770 ] Nil Madhab commented on KAFKA-18713: slack thread for [bug|https://confluentcommuni

Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Versioned Connector Creation and related changes) [kafka]

2025-02-10 Thread via GitHub
gharris1727 commented on code in PR #17743: URL: https://github.com/apache/kafka/pull/17743#discussion_r1949998656 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1210,6 +1217,30 @@ public void connectorOffsets(String connName, Map connecto

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-02-10 Thread via GitHub
kirktrue commented on PR #18795: URL: https://github.com/apache/kafka/pull/18795#issuecomment-2649451285 @junrao—here's a breakdown of the flaky tests from the latest run: * `AbstractCoordinatorTest.testWakeupAfterSyncGroupReceivedExternalCompletion()`: [35% flaky](https://develocit

Re: [PR] KAFKA-17298: Update upgrade notes for 4.0 KIP-848 [kafka]

2025-02-10 Thread via GitHub
lianetm commented on code in PR #18756: URL: https://github.com/apache/kafka/pull/18756#discussion_r1947203398 ## docs/upgrade.html: ## @@ -89,6 +89,27 @@ Notable changes in 4 Broker +The new Consum

Re: [PR] KAFKA-18764: Throttle on share state RPCs auth failure. [kafka]

2025-02-10 Thread via GitHub
AndrewJSchofield commented on code in PR #18855: URL: https://github.com/apache/kafka/pull/18855#discussion_r1949980516 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3130,7 +3137,14 @@ class KafkaApis(val requestChannel: RequestChannel, def handleWriteShareGroup

Re: [PR] KAFKA-17298: Update upgrade notes for 4.0 KIP-848 [kafka]

2025-02-10 Thread via GitHub
lianetm commented on code in PR #18756: URL: https://github.com/apache/kafka/pull/18756#discussion_r1949989344 ## docs/upgrade.html: ## @@ -89,6 +89,29 @@ Notable changes in 4 Broker +The new group

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
edoardocomar commented on code in PR #18833: URL: https://github.com/apache/kafka/pull/18833#discussion_r1949986081 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -803,7 +807,7 @@ class BrokerServer( if (clientToControllerChannelManager != null) Co

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
edoardocomar commented on PR #18833: URL: https://github.com/apache/kafka/pull/18833#issuecomment-2649382280 thanks @AndrewJSchofield and @apoorvmittal10 I also removed a few braces to match the style of nearby if statements -- This is an automated message from the Apache Git Servi

[jira] [Resolved] (KAFKA-18658) add import control for examples module

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18658. Resolution: Fixed > add import control for examples module > -

Re: [PR] KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion [kafka]

2025-02-10 Thread via GitHub
chia7712 merged PR #18820: URL: https://github.com/apache/kafka/pull/18820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Comment Edited] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-02-10 Thread tuna b (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925758#comment-17925758 ] tuna b edited comment on KAFKA-18713 at 2/10/25 10:14 PM: -- "If

Re: [PR] KAFKA-18366 Remove KafkaConfig.interBrokerProtocolVersion [kafka]

2025-02-10 Thread via GitHub
ijuma commented on PR #18820: URL: https://github.com/apache/kafka/pull/18820#issuecomment-2649362039 @chia7712 Feel free to merge, I can resolve the conflicts on my PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949971600 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -328,15 +314,10 @@ private ApiError updateMetadataVersion( try {

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949970524 ## metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadataTest.java: ## @@ -126,7 +125,7 @@ public void testFeatureLevelForFeature() { static fi

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949970524 ## metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadataTest.java: ## @@ -126,7 +125,7 @@ public void testFeatureLevelForFeature() { static fi

[jira] [Commented] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-02-10 Thread tuna b (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925758#comment-17925758 ] tuna b commented on KAFKA-18713: "If I don't create 10 partition, will the issue still o

[jira] [Assigned] (KAFKA-18658) add import control for examples module

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18658: -- Assignee: xuanzhang gong (was: Chia-Ping Tsai) > add import control for examples mod

[jira] [Updated] (KAFKA-18658) add import control for examples module

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18658: --- Fix Version/s: 4.1.0 > add import control for examples module >

Re: [PR] KAFKA-18658: add import control for examples module [kafka]

2025-02-10 Thread via GitHub
chia7712 merged PR #18812: URL: https://github.com/apache/kafka/pull/18812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18522: Slice records for share fetch [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on PR #18804: URL: https://github.com/apache/kafka/pull/18804#issuecomment-2649349794 Hi @junrao, can you please re-review the simplified solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
chia7712 commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949874774 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -328,15 +314,10 @@ private ApiError updateMetadataVersion( try {

Re: [PR] KAFKA-18522: Slice records for share fetch [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18804: URL: https://github.com/apache/kafka/pull/18804#discussion_r1949965157 ## server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTestUtils.java: ## @@ -74,4 +87,62 @@ public static void validateRotatedMapEquals(

Re: [PR] KAFKA-18522: Slice records for share fetch [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18804: URL: https://github.com/apache/kafka/pull/18804#discussion_r1949964577 ## core/src/main/java/kafka/server/share/ShareFetchUtils.java: ## @@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager, TopicPartition

Re: [PR] KAFKA-18522: Slice records for share fetch [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18804: URL: https://github.com/apache/kafka/pull/18804#discussion_r1949964577 ## core/src/main/java/kafka/server/share/ShareFetchUtils.java: ## @@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager, TopicPartition

Re: [PR] KAFKA-18522: Slice records for share fetch [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18804: URL: https://github.com/apache/kafka/pull/18804#discussion_r1949962995 ## core/src/main/java/kafka/server/share/ShareFetchUtils.java: ## @@ -187,4 +185,78 @@ static Partition partition(ReplicaManager replicaManager, TopicPartition

Re: [PR] KAFKA-15995: Adding KIP-877 support to Connect [kafka]

2025-02-10 Thread via GitHub
gharris1727 commented on code in PR #17804: URL: https://github.com/apache/kafka/pull/17804#discussion_r1949869360 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java: ## @@ -585,19 +590,37 @@ public void raiseError(Exception e) { }

[jira] [Comment Edited] (KAFKA-18031) Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt

2025-02-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925753#comment-17925753 ] Lianet Magrans edited comment on KAFKA-18031 at 2/10/25 9:53 PM: -

[jira] [Commented] (KAFKA-18031) Flaky PlaintextConsumerTest testCloseLeavesGroupOnInterrupt

2025-02-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925753#comment-17925753 ] Lianet Magrans commented on KAFKA-18031: Hey [~taijuwu] , sorry I missed this co

Re: [PR] KAFKA-18654[2/2]: Transction V2 retry add partitions on the server side when handling produce request. [kafka]

2025-02-10 Thread via GitHub
jolshan commented on code in PR #18810: URL: https://github.com/apache/kafka/pull/18810#discussion_r1949930232 ## transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/AddPartitionsToTxnConfig.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

2025-02-10 Thread via GitHub
bbejeck commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1949922615 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -454,6 +454,15 @@ public Map members() { return Collecti

Re: [PR] KAFKA-18758: NullPointerException in shutdown following InvalidConfigurationException [kafka]

2025-02-10 Thread via GitHub
AndrewJSchofield commented on code in PR #18833: URL: https://github.com/apache/kafka/pull/18833#discussion_r1949925944 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -803,7 +807,7 @@ class BrokerServer( if (clientToControllerChannelManager != null)

[PR] Add integration test for IQv2 in KIP-1071 [kafka]

2025-02-10 Thread via GitHub
bbejeck opened a new pull request, #18856: URL: https://github.com/apache/kafka/pull/18856 Adds a parameterized integration test ensuring that the same host->partitions information is sent in both `classic` and `streams` group mode. This is a stacked PR only review the last commit.

[PR] KAFKA-18764: Throttle on share state RPCs. [kafka]

2025-02-10 Thread via GitHub
smjn opened a new pull request, #18855: URL: https://github.com/apache/kafka/pull/18855 * Currently, share group state RPCs (read, write, delete, readSummary) simply raise an APIException on authorization errors. * This might result in overwhelming the broker by a malicious user or by a

[jira] [Commented] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925742#comment-17925742 ] Colin McCabe commented on KAFKA-18762: -- As [~dajac] said, this isn't really about K

[jira] [Comment Edited] (KAFKA-18762) 'Acks=all' not working correctly in Kafka Kraft mode.

2025-02-10 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925742#comment-17925742 ] Colin McCabe edited comment on KAFKA-18762 at 2/10/25 9:09 PM: ---

Re: [PR] KAFKA-18767: Add client side config check [kafka]

2025-02-10 Thread via GitHub
TaiJuWu commented on PR #18850: URL: https://github.com/apache/kafka/pull/18850#issuecomment-2649204228 Error will fix tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-10 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1949883386 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -170,41 +140,17 @@ public void testPrevious() { @Test public voi

[jira] [Updated] (KAFKA-18767) Add client side config check

2025-02-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18767: --- Component/s: clients consumer > Add client side config check >

[jira] [Updated] (KAFKA-18767) Add client side config check

2025-02-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-18767: --- Labels: queues-for-kafka (was: ) > Add client side config check > -

[jira] [Commented] (KAFKA-18767) Add client side config check

2025-02-10 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17925729#comment-17925729 ] TaiJuWu commented on KAFKA-18767: - [~lianetm] Thanks for confirm! > Add client side con

Re: [PR] KAFKA-18653: Fix mocks and potential thread leak issues causing silent RejectedExecutionException in share group broker tests [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18725: URL: https://github.com/apache/kafka/pull/18725#discussion_r1949839653 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -5977,6 +5980,67 @@ class ReplicaManagerTest { ) } + @Test + def testDelayed

Re: [PR] KAFKA-18770: Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak) [kafka]

2025-02-10 Thread via GitHub
TaiJuWu commented on PR #18853: URL: https://github.com/apache/kafka/pull/18853#issuecomment-2649165726 Before ``` Gradle Test Run :core:test > Gradle Test Executor 9 > RequestQuotaTest > initializationError FAILED org.opentest4j.AssertionFailedError: Found 1 unexpected threads

Re: [PR] KAFKA-18770: Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak) [kafka]

2025-02-10 Thread via GitHub
TaiJuWu commented on PR #18853: URL: https://github.com/apache/kafka/pull/18853#issuecomment-2649154277 > I've been seeing the problem that this is meant to address - do we know which change introduced the problem? Is it only in trunk? Here is reference https://github.com/apache/kafk

Re: [PR] KAFKA-18653: Fix mocks and potential thread leak issues causing silent RejectedExecutionException in share group broker tests [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on code in PR #18725: URL: https://github.com/apache/kafka/pull/18725#discussion_r1949830538 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -5977,6 +5980,67 @@ class ReplicaManagerTest { ) } + @Test + def testDelayed

Re: [PR] MINOR: Java version and TLS documentation improvements [kafka]

2025-02-10 Thread via GitHub
ijuma commented on PR #18822: URL: https://github.com/apache/kafka/pull/18822#issuecomment-2649155049 I will also cherry-pick this to the 4.0 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: Java version and TLS documentation improvements [kafka]

2025-02-10 Thread via GitHub
ijuma merged PR #18822: URL: https://github.com/apache/kafka/pull/18822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] [IGNORE] Dummy PR to test flakiness [kafka]

2025-02-10 Thread via GitHub
kirktrue opened a new pull request, #18854: URL: https://github.com/apache/kafka/pull/18854 IGNORE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-18770: Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak) [kafka]

2025-02-10 Thread via GitHub
apoorvmittal10 commented on PR #18853: URL: https://github.com/apache/kafka/pull/18853#issuecomment-2649153011 > I've been seeing the problem that this is meant to address - do we know which change introduced the problem? Is it only in trunk? Yes it should only be in trunk, the test w

Re: [PR] KAFKA-18770: Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak) [kafka]

2025-02-10 Thread via GitHub
ijuma commented on PR #18853: URL: https://github.com/apache/kafka/pull/18853#issuecomment-2649149569 I've been seeing the problem that this is meant to address - do we know which change introduced the problem? Is it only in trunk? -- This is an automated message from the Apache Git Servi

[PR] KAFKA-18770: Fix flaky initializationError in ReplicationQuotasTest/RequestQuotaTest (thread leak) [kafka]

2025-02-10 Thread via GitHub
TaiJuWu opened a new pull request, #18853: URL: https://github.com/apache/kafka/pull/18853 jira: https://issues.apache.org/jira/browse/KAFKA-18770 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI buil

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-10 Thread via GitHub
mjsax commented on PR #18760: URL: https://github.com/apache/kafka/pull/18760#issuecomment-2649137966 Thanks for highlighting this issue (and thanks for the PR to fix it). The build for this PR did not surface this issue (otherwise we would not have merged it). I agree, that it might be goo

[jira] [Resolved] (KAFKA-18743) leader.imbalance.per.broker.percentage is not supported by Kraft

2025-02-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18743. Resolution: Fixed trunk: [https://github.com/apache/kafka/commit/4e36368d08e107d83431dbda

Re: [PR] MINOR: cleanup KStream JavaDocs (11/N) - stream-stream-left-join [kafka]

2025-02-10 Thread via GitHub
mjsax commented on PR #18836: URL: https://github.com/apache/kafka/pull/18836#issuecomment-2649114528 Java 17: ``` Found 4 flaky test failures: FLAKY ⚠️ CooperativeConsumerCoordinatorTest > testOutdatedCoordinatorAssignment() FLAKY ⚠️ AbstractCoordinatorTest > testWakeupAfterS

Re: [PR] MINOR: cleanup KStream JavaDocs (12/N) - process[Values] [kafka]

2025-02-10 Thread via GitHub
mjsax commented on PR #18839: URL: https://github.com/apache/kafka/pull/18839#issuecomment-2649112998 Java 17: ``` Found 3 flaky test failures: FLAKY ⚠️ CooperativeConsumerCoordinatorTest > testOutdatedCoordinatorAssignment() FLAKY ⚠️ KRaftClusterTest > testDescribeQuorumReques

Re: [PR] KAFKA-18743: leader.imbalance.per.broker.percentage is not supported by Kraft [kafka]

2025-02-10 Thread via GitHub
chia7712 merged PR #18821: URL: https://github.com/apache/kafka/pull/18821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

  1   2   3   >