lianetm commented on code in PR #18756:
URL: https://github.com/apache/kafka/pull/18756#discussion_r1949989344
##########
docs/upgrade.html:
##########
@@ -89,6 +89,29 @@ <h5><a id="upgrade_400_notable"
href="#upgrade_400_notable">Notable changes in 4
</li>
<li><b>Broker</b>
<ul>
+ <li>The new group coordinator (<a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+Next+Generation+of+the+Consumer+Rebalance+Protocol";>KIP-848</a>)
is now production ready.
+ <ul>
+ <li>New config
<code>group.coordinator.new.enable=true</code> is added, enabling it by
default.</li>
+ <li>New config
<code>group.coordinator.rebalance.protocols=classic,consumer</code> is added.
Both protocols supported by default.</li>
+ <li>New config
<code>group.coordinator.threads=1</code> to control the number of threads the
coordinator uses. It defaults to 1, and it should be adjusted as needed.</li>
+ You can check <a
href="https://cwiki.apache.org/confluence/display/KAFKA/The+Next+Generation+of+the+Consumer+Rebalance+Protocol+%28KIP-848%29+-+GA+Release+Notes";>New
Rebalance Protocol GA Release Notes</a> for more details.
+ </ul>
+ </li>
+ <li>The new rebalance protocol (<a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+Next+Generation+of+the+Consumer+Rebalance+Protocol";>KIP-848</a>)
is now production ready.
+ <ul>
+ <li>In addition to the new coordinator config
for the supported protocols, a new feature flag group.version has been added.
It is set automatically to support the new protocol when upgrading to 4.0.</li>
+ <li>The consumer heartbeat interval and
session timeout are controlled by the broker now with the new configs:
+ <ul>
+
<li><code>group.consumer.heartbeat.interval.ms</code></li>
+
<li><code>group.consumer.session.timeout.ms</code></li>
+ </ul>
+ </li>
+ <li>The <code>group.consumer.assignors</code>
configuration is added to the broker with the supported partition assignment
strategies.
+ It defaults to
<code>org.apache.kafka.coordinator.group.assignor.UniformAssignor</code>, so
this will be the assignor used unless the Consumer selects a different one.
Review Comment:
oh thanks for the info, I wasn't aware of that improvement.
Updated the notes on the upgrade.html here, but also the description of the
consumer config, I think we need to keep it in sync with the broker changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
