ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1949883386
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -170,41 +140,17 @@ public void testPrevious() {
@Test
public void testMetadataChanged() {
- assertFalse(MetadataVersion.checkIfMetadataChanged(IBP_3_2_IV0,
IBP_3_2_IV0));
- assertTrue(MetadataVersion.checkIfMetadataChanged(IBP_3_2_IV0,
IBP_3_1_IV0));
- assertTrue(MetadataVersion.checkIfMetadataChanged(IBP_3_2_IV0,
IBP_3_0_IV1));
- assertTrue(MetadataVersion.checkIfMetadataChanged(IBP_3_2_IV0,
IBP_3_0_IV1));
- assertTrue(MetadataVersion.checkIfMetadataChanged(IBP_3_3_IV1,
IBP_3_3_IV0));
+ assertTrue(MetadataVersion.checkIfMetadataChanged(IBP_3_4_IV0,
IBP_3_3_IV3));
+ assertFalse(MetadataVersion.checkIfMetadataChanged(IBP_3_5_IV0,
IBP_3_4_IV0));
+ assertFalse(MetadataVersion.checkIfMetadataChanged(IBP_3_5_IV1,
IBP_3_5_IV0));
+ assertTrue(MetadataVersion.checkIfMetadataChanged(IBP_3_6_IV0,
IBP_3_5_IV1));
+ assertTrue(MetadataVersion.checkIfMetadataChanged(IBP_3_6_IV1,
IBP_3_6_IV0));
// Check that argument order doesn't matter
- assertTrue(MetadataVersion.checkIfMetadataChanged(IBP_3_1_IV0,
IBP_3_2_IV0));
- assertTrue(MetadataVersion.checkIfMetadataChanged(IBP_3_0_IV1,
IBP_3_2_IV0));
- }
-
- @Test
- public void testKRaftVersions() {
Review Comment:
This did not seem to add much value after the changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
