ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1950200566


##########
metadata/src/test/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectoryTest.java:
##########
@@ -81,18 +81,18 @@ public void testReadFromEmptyConfiguration() throws 
Exception {
     @Test
     public void testReadFromConfigurationWithAncientVersion() throws Exception 
{
         try (BootstrapTestDirectory testDirectory = new 
BootstrapTestDirectory().createDirectory()) {
-            
assertEquals(BootstrapMetadata.fromVersion(MetadataVersion.MINIMUM_BOOTSTRAP_VERSION,
-                    "the minimum version bootstrap with metadata.version 
3.3-IV0"),
+            
assertEquals(BootstrapMetadata.fromVersion(MetadataVersion.MINIMUM_VERSION,
+                    "the minimum version bootstrap with metadata.version 
3.3-IV3"),

Review Comment:
   Subsequent commits simplified this file and I think the issue you outlined 
is no longer present.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to