AndrewJSchofield commented on code in PR #18833:
URL: https://github.com/apache/kafka/pull/18833#discussion_r1949925944
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -803,7 +807,7 @@ class BrokerServer(
if (clientToControllerChannelManager != null)
CoreUtils.swallow(clientToControllerChannelManager.shutdown(), this)
- if (logManager != null)
+ if (logManager != null && lifecycleManager != null)
Review Comment:
I also think this seems a bit odd. Having gone to all of the trouble to
null-check references to lifecycleManager, I would have expected something more
like:
```
if (logManager != null)
CoreUtils.swallow(logManager.shutdown(if (lifecycleManager != null)
lifecycleManager.brokerEpoch else -1, this)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
