Re: [PR] KAFKA-18518: Add processor to handle rebalance events [kafka]

2025-01-21 Thread via GitHub
cadonna merged PR #18527: URL: https://github.com/apache/kafka/pull/18527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Make `forceUnmap` protected since the only test class that references it is in the same package now. [kafka]

2025-01-21 Thread via GitHub
pramithas commented on code in PR #18638: URL: https://github.com/apache/kafka/pull/18638#discussion_r1924726432 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java: ## @@ -399,8 +399,8 @@ protected void safeForceUnmap() { /** * Forceful

Re: [PR] MINOR: Make `forceUnmap` protected since the only test class that references it is in the same package now. [kafka]

2025-01-21 Thread via GitHub
pramithas commented on code in PR #18638: URL: https://github.com/apache/kafka/pull/18638#discussion_r1924726432 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java: ## @@ -399,8 +399,8 @@ protected void safeForceUnmap() { /** * Forceful

Re: [PR] KAFKA-18529: ConsumerRebootstrapTest should run for async consumer [kafka]

2025-01-21 Thread via GitHub
TaiJuWu commented on code in PR #18554: URL: https://github.com/apache/kafka/pull/18554#discussion_r1924699832 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -207,10 +207,10 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

[jira] [Updated] (KAFKA-18529) ConsumerRebootstrapTest should run for async consumer

2025-01-21 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu updated KAFKA-18529: Summary: ConsumerRebootstrapTest should run for async consumer (was: PlaintextAdminIntegrationTest and Co

Re: [PR] KAFKA-18559: Cleanup FinalizedFeatures [kafka]

2025-01-21 Thread via GitHub
chia7712 commented on code in PR #18593: URL: https://github.com/apache/kafka/pull/18593#discussion_r1924657309 ## server-common/src/main/java/org/apache/kafka/server/common/FinalizedFeatures.java: ## @@ -27,25 +27,19 @@ public final class FinalizedFeatures { private final

Re: [PR] KAFKA-18483: Disable `Log4jController` and `Loggers` if Log4j Core absent [kafka]

2025-01-21 Thread via GitHub
github-actions[bot] commented on PR #18496: URL: https://github.com/apache/kafka/pull/18496#issuecomment-2606191761 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18559: Cleanup FinalizedFeatures [kafka]

2025-01-21 Thread via GitHub
frankvicky commented on code in PR #18593: URL: https://github.com/apache/kafka/pull/18593#discussion_r1924620570 ## server-common/src/main/java/org/apache/kafka/server/common/FinalizedFeatures.java: ## @@ -27,25 +27,19 @@ public final class FinalizedFeatures { private fina

Re: [PR] KAFKA-18590: Cleanup DelegationTokenManager [kafka]

2025-01-21 Thread via GitHub
frankvicky commented on code in PR #18618: URL: https://github.com/apache/kafka/pull/18618#discussion_r1924625542 ## core/src/main/scala/kafka/server/DelegationTokenManager.scala: ## @@ -157,126 +118,25 @@ class DelegationTokenManager(val config: KafkaConfig, * @param token

Re: [PR] KAFKA-18559: Cleanup FinalizedFeatures [kafka]

2025-01-21 Thread via GitHub
frankvicky commented on code in PR #18593: URL: https://github.com/apache/kafka/pull/18593#discussion_r1924620570 ## server-common/src/main/java/org/apache/kafka/server/common/FinalizedFeatures.java: ## @@ -27,25 +27,19 @@ public final class FinalizedFeatures { private fina

Re: [PR] KAFKA-18559: Cleanup FinalizedFeatures [kafka]

2025-01-21 Thread via GitHub
frankvicky commented on code in PR #18593: URL: https://github.com/apache/kafka/pull/18593#discussion_r1924620570 ## server-common/src/main/java/org/apache/kafka/server/common/FinalizedFeatures.java: ## @@ -27,25 +27,19 @@ public final class FinalizedFeatures { private fina

Re: [PR] KAFKA-18533: Remove KafkaConfig zookeeper related logic [kafka]

2025-01-21 Thread via GitHub
ijuma commented on code in PR #18547: URL: https://github.com/apache/kafka/pull/18547#discussion_r1924617888 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -188,14 +188,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def valuesFromThis

Re: [PR] KAFKA-18474: Remove zkBroker tag [kafka]

2025-01-21 Thread via GitHub
ijuma commented on PR #18477: URL: https://github.com/apache/kafka/pull/18477#issuecomment-2606161400 Can you please resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] MINOR: Cleanup ControllerContext and StateChangeLogger [kafka]

2025-01-21 Thread via GitHub
ijuma merged PR #18588: URL: https://github.com/apache/kafka/pull/18588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18559: Cleanup FinalizedFeatures [kafka]

2025-01-21 Thread via GitHub
ijuma commented on code in PR #18593: URL: https://github.com/apache/kafka/pull/18593#discussion_r1924613895 ## server-common/src/main/java/org/apache/kafka/server/common/FinalizedFeatures.java: ## @@ -27,25 +27,19 @@ public final class FinalizedFeatures { private final lon

Re: [PR] KAFKA-18561: Remove withKip853Rpc and replace it with withRaftProtocol [kafka]

2025-01-21 Thread via GitHub
ijuma commented on PR #18600: URL: https://github.com/apache/kafka/pull/18600#issuecomment-2606155592 @jsancio You're ok with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-18590: Cleanup DelegationTokenManager [kafka]

2025-01-21 Thread via GitHub
ijuma commented on code in PR #18618: URL: https://github.com/apache/kafka/pull/18618#discussion_r1924612768 ## core/src/main/scala/kafka/server/DelegationTokenManager.scala: ## @@ -157,126 +118,25 @@ class DelegationTokenManager(val config: KafkaConfig, * @param token *

Re: [PR] MINOR: Remove recordVersion param from javadoc [kafka]

2025-01-21 Thread via GitHub
ijuma merged PR #18603: URL: https://github.com/apache/kafka/pull/18603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Remove recordVersion param from javadoc [kafka]

2025-01-21 Thread via GitHub
ijuma commented on PR #18603: URL: https://github.com/apache/kafka/pull/18603#issuecomment-2606153076 This changes javadoc only, test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-18592: Cleanup ReplicaManager [kafka]

2025-01-21 Thread via GitHub
ijuma commented on PR #18621: URL: https://github.com/apache/kafka/pull/18621#issuecomment-2606152233 Please resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-18599: Remove Optional wrapping for forwardingManager in ApiVersionManager [kafka]

2025-01-21 Thread via GitHub
ijuma commented on code in PR #18630: URL: https://github.com/apache/kafka/pull/18630#discussion_r1924609967 ## core/src/test/scala/unit/kafka/server/ApiVersionManagerTest.scala: ## @@ -103,51 +105,29 @@ class ApiVersionManagerTest { val forwardingManager = Mockito.mock(cla

[PR] KAFKA-18310: Flaky AbstractCoordinatorTest [kafka]

2025-01-21 Thread via GitHub
FrankYang0529 opened a new pull request, #18665: URL: https://github.com/apache/kafka/pull/18665 The `AbstractCoordinator#joinGroupIfNeeded` calls `ConsumerNetworkClient#poll(RequestFuture, Timer)` [0]. It calls another method with `disableWakeup = false`. If `joinFuture` is not done, Cons

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-21 Thread via GitHub
junrao commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1924510229 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -408,22 +407,44 @@ protected Map prepareFetchRequests() long cur

Re: [PR] MINOR: Ignore streams eos test until we have an agreed upon fix. [kafka]

2025-01-21 Thread via GitHub
bbejeck commented on PR #18664: URL: https://github.com/apache/kafka/pull/18664#issuecomment-2605950782 merged #18664 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] MINOR: Ignore streams eos test until we have an agreed upon fix. [kafka]

2025-01-21 Thread via GitHub
bbejeck merged PR #18664: URL: https://github.com/apache/kafka/pull/18664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

2025-01-21 Thread via GitHub
fonsdant commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2605940755 Hi, @mjsax! I have updated (instead of removing) the migration/applying section and added the example for old process. Now, I am reviewing the Slang example and analyzing the use of Cont

[PR] MINOR: Ignore streams eos test until we have an agreed upon fix. [kafka]

2025-01-21 Thread via GitHub
bbejeck opened a new pull request, #18664: URL: https://github.com/apache/kafka/pull/18664 Ignore the `streams_eos_test.py` until we come up with a fix for[ creating local standby tasks on startup](#16922). ### Committer Checklist (excluded from commit message) - [ ] Verify design

[jira] [Assigned] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2025-01-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15402: - Assignee: Kirk True > Performance regression on close consumer after upgrading to 3.5.0 > -

Re: [PR] KAFKA-17402: DefaultStateUpdated should transit task atomically [kafka]

2025-01-21 Thread via GitHub
mjsax commented on PR #18607: URL: https://github.com/apache/kafka/pull/18607#issuecomment-2605858781 Merged to `trunk` and cherry-picked to `4.0`, `3.9`, and `3.8` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

2025-01-21 Thread via GitHub
kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1924296931 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -682,13 +690,15 @@ private void transitionToCandidate(long currentTimeMs) { private void

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

2025-01-21 Thread via GitHub
kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1924296931 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -682,13 +690,15 @@ private void transitionToCandidate(long currentTimeMs) { private void

[jira] [Commented] (KAFKA-18527) SaslClientsWithInvalidCredentialsTest.java and SaslClientsWithInvalidCredentialsTest.scala should run for async consumer

2025-01-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915839#comment-17915839 ] Lianet Magrans commented on KAFKA-18527: Hey [~frankvicky] , this looks interest

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1924375276 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -408,22 +407,44 @@ protected Map prepareFetchRequests() long c

Re: [PR] KAFKA-18527: SaslClientsWithInvalidCredentialsTest.java should run for async consumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #18609: URL: https://github.com/apache/kafka/pull/18609#discussion_r1924367542 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java: ## @@ -149,7 +149,7 @@ public void testConsumerGroupServiceWi

[jira] [Commented] (KAFKA-18087) Revert unnecessary integration testing of both consumer group protocols

2025-01-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915835#comment-17915835 ] Kirk True commented on KAFKA-18087: --- cc [~lianetm] > Revert unnecessary integration t

Re: [PR] KAFKA-18529: PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #18554: URL: https://github.com/apache/kafka/pull/18554#discussion_r1924361968 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -207,10 +207,10 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegr

Re: [PR] KAFKA-18517: Enable ConsumerBounceTest to run for new async consumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #18532: URL: https://github.com/apache/kafka/pull/18532#discussion_r1924351924 ## core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala: ## @@ -297,12 +302,15 @@ class ConsumerBounceTest extends AbstractConsumerTest with Logging {

Re: [PR] KAFKA-18529: PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #18554: URL: https://github.com/apache/kafka/pull/18554#discussion_r1924360209 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -207,10 +207,10 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegr

Re: [PR] KAFKA-18517: Enable ConsumerBounceTest to run for new async consumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #18532: URL: https://github.com/apache/kafka/pull/18532#discussion_r1924353526 ## core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala: ## @@ -319,17 +327,20 @@ class ConsumerBounceTest extends AbstractConsumerTest with Logging {

Re: [PR] KAFKA-18517: Enable ConsumerBounceTest to run for new async consumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #18532: URL: https://github.com/apache/kafka/pull/18532#discussion_r1924350378 ## core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala: ## @@ -59,7 +59,12 @@ class ConsumerBounceTest extends AbstractConsumerTest with Logging {

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1924346311 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -408,22 +407,44 @@ protected Map prepareFetchRequests() long c

Re: [PR] KAFKA-17402: DefaultStateUpdated should transit task atomically [kafka]

2025-01-21 Thread via GitHub
mjsax merged PR #18607: URL: https://github.com/apache/kafka/pull/18607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18610 [1/N]: add flush-interval-ms metric [kafka]

2025-01-21 Thread via GitHub
dajac commented on PR #18663: URL: https://github.com/apache/kafka/pull/18663#issuecomment-2605671940 @jeffkbkim I think that we would need a new KIP for this metric. KIP-848 is almost released hence I don’t want to amend it anymore. -- This is an automated message from the Apache Git Ser

Re: [PR] KAFKA-18610 [1/N]: add flush-interval-ms metric [kafka]

2025-01-21 Thread via GitHub
dajac commented on code in PR #18663: URL: https://github.com/apache/kafka/pull/18663#discussion_r1924322291 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/KafkaMetricHistogram.java: ## @@ -125,6 +127,6 @@ public List stats() { @Override

[jira] [Commented] (KAFKA-18369) State updater's *-ratio metrics are incorrect

2025-01-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915826#comment-17915826 ] Matthias J. Sax commented on KAFKA-18369: - Did not think about it in detail... –

Re: [PR] KAFKA-17402: DefaultStateUpdated should transit task atomically [kafka]

2025-01-21 Thread via GitHub
mjsax commented on PR #18607: URL: https://github.com/apache/kafka/pull/18607#issuecomment-2605662818 Java 23 passed. Java 17: ``` Found 1 test failures: FAILED ❌ KafkaAdminClientTest > testAdminClientApisAuthenticationFailure() Found 3 flaky test failures: FLAKY ⚠️ Abs

Re: [PR] KAFKA-18610 [1/N]: add flush-interval-ms metric [kafka]

2025-01-21 Thread via GitHub
jeffkbkim commented on code in PR #18663: URL: https://github.com/apache/kafka/pull/18663#discussion_r1924316239 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/KafkaMetricHistogram.java: ## @@ -125,6 +127,6 @@ public List stats() { @Overri

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1924311418 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -456,6 +484,44 @@ protected Map prepareFetchRequests() return

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

2025-01-21 Thread via GitHub
kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1924296931 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -682,13 +690,15 @@ private void transitionToCandidate(long currentTimeMs) { private void

[jira] [Commented] (KAFKA-18583) Improve/fix KRaftMetadataCache.getPartitionReplicaEndpoints

2025-01-21 Thread Dimitar Dimitrov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915823#comment-17915823 ] Dimitar Dimitrov commented on KAFKA-18583: -- Posted [PR #18657|https://github.co

Re: [PR] KAFKA-17894: Implemented broker topic metrics for Share Group 1/N (KIP-1103) [kafka]

2025-01-21 Thread via GitHub
junrao commented on code in PR #18444: URL: https://github.com/apache/kafka/pull/18444#discussion_r1924285917 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -598,6 +632,12 @@ void processShareFetch(ShareFetch shareFetch) { sharePartitions

Re: [PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-01-21 Thread via GitHub
smjn commented on code in PR #18662: URL: https://github.com/apache/kafka/pull/18662#discussion_r1924283168 ## test-common/test-common-api/src/test/java/org/apache/kafka/common/test/api/ClusterTestBeforeEachTest.java: ## @@ -0,0 +1,38 @@ +package org.apache.kafka.common.test.api

[PR] KAFKA-18610 [1/N]: add flush-interval-ms metric [kafka]

2025-01-21 Thread via GitHub
jeffkbkim opened a new pull request, #18663: URL: https://github.com/apache/kafka/pull/18663 Add flush-interval-ms histogram: track how long it takes from when a batch is first created, to right before writing to disk. The bulk of the time will represent the time spent in the timer, waiting

Re: [PR] KAFKA-18575: Transaction Version 2 doesn't correctly handle race condition with completing and new transaction [kafka]

2025-01-21 Thread via GitHub
jolshan commented on code in PR #18604: URL: https://github.com/apache/kafka/pull/18604#discussion_r1924267950 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -600,6 +600,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, */ def hasOngoingTransaction(prod

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-21 Thread via GitHub
junrao commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1924265557 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -408,22 +407,44 @@ protected Map prepareFetchRequests() long cur

Re: [PR] KAFKA-18529: PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer [kafka]

2025-01-21 Thread via GitHub
lianetm commented on code in PR #18554: URL: https://github.com/apache/kafka/pull/18554#discussion_r1924158432 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -207,10 +207,10 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

Re: [PR] MINOR: Make `forceUnmap` protected since the only test class that references it is in the same package now. [kafka]

2025-01-21 Thread via GitHub
divijvaidya commented on code in PR #18638: URL: https://github.com/apache/kafka/pull/18638#discussion_r1924246526 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java: ## @@ -399,8 +399,8 @@ protected void safeForceUnmap() { /** * Forcef

Re: [PR] KAFKA-18575: Transaction Version 2 doesn't correctly handle race condition with completing and new transaction [kafka]

2025-01-21 Thread via GitHub
CalvinConfluent commented on code in PR #18604: URL: https://github.com/apache/kafka/pull/18604#discussion_r1924240294 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -600,6 +600,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, */ def hasOngoingTransact

Re: [PR] MINOR: Refactor ShareConsumerTest to use ClusterTestExtensions. [kafka]

2025-01-21 Thread via GitHub
mumrah commented on code in PR #18656: URL: https://github.com/apache/kafka/pull/18656#discussion_r1924249603 ## core/src/test/java/kafka/test/api/ShareConsumerTest.java: ## @@ -101,67 +100,64 @@ @Timeout(1200) @Tag("integration") +@ExtendWith(ClusterTestExtensions.class) +@

[PR] KAFKA-18617 Allow use of ClusterInstance inside BeforeEach [kafka]

2025-01-21 Thread via GitHub
mumrah opened a new pull request, #18662: URL: https://github.com/apache/kafka/pull/18662 Move the ClusterTest setup callback to `BeforeEachCallback` instead of `BeforeTestExecutionCallback`. This allows the setup to happen slightly earlier and before any `@BeforeEach` methods are invoked.

Re: [PR] KAFKA-18392: Ensure client sets member ID for share group [kafka]

2025-01-21 Thread via GitHub
lianetm commented on code in PR #18649: URL: https://github.com/apache/kafka/pull/18649#discussion_r1924239073 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -846,28 +846,29 @@ private ShareGroup getOrMaybeCreateShareGroup(

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-21 Thread via GitHub
kirktrue commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1924238531 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -408,22 +407,44 @@ protected Map prepareFetchRequests() long c

[jira] [Commented] (KAFKA-18572) Update Kafka Streams metric documenation

2025-01-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915808#comment-17915808 ] Matthias J. Sax commented on KAFKA-18572: - Sure! Thanks for picking it up. > Up

[jira] [Created] (KAFKA-18618) Reduce stickiness of share session handlers

2025-01-21 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-18618: Summary: Reduce stickiness of share session handlers Key: KAFKA-18618 URL: https://issues.apache.org/jira/browse/KAFKA-18618 Project: Kafka Issue Typ

[jira] [Created] (KAFKA-18617) Support ClusterInstance in BeforeEach/AfterEach fixtures

2025-01-21 Thread David Arthur (Jira)
David Arthur created KAFKA-18617: Summary: Support ClusterInstance in BeforeEach/AfterEach fixtures Key: KAFKA-18617 URL: https://issues.apache.org/jira/browse/KAFKA-18617 Project: Kafka Issu

Re: [PR] MINOR: Refactor ShareConsumerTest to use ClusterTestExtensions. [kafka]

2025-01-21 Thread via GitHub
mumrah commented on code in PR #18656: URL: https://github.com/apache/kafka/pull/18656#discussion_r1924223156 ## core/src/test/java/kafka/test/api/ShareConsumerTest.java: ## @@ -101,67 +100,64 @@ @Timeout(1200) @Tag("integration") +@ExtendWith(ClusterTestExtensions.class) +@

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-21 Thread via GitHub
junrao commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1924211525 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -456,6 +484,44 @@ protected Map prepareFetchRequests() return f

Re: [PR] MINOR Fix condition in flaky test report workflow [kafka]

2025-01-21 Thread via GitHub
mumrah merged PR #18599: URL: https://github.com/apache/kafka/pull/18599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] [KAFKA-18454] Publish build scans to develocity.apache.org [kafka]

2025-01-21 Thread via GitHub
mumrah merged PR #18539: URL: https://github.com/apache/kafka/pull/18539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18484; Improve exception handling during coordinator unload [kafka]

2025-01-21 Thread via GitHub
squah-confluent commented on PR #18499: URL: https://github.com/apache/kafka/pull/18499#issuecomment-2605469015 @dajac and I had a discussion and we decided to break this into multiple PRs, starting with the deferred event exception handling. -- This is an automated message from the Apach

[PR] KAFKA-18484 [1/N]; Handle exceptions from deferred events in coordinator [kafka]

2025-01-21 Thread via GitHub
squah-confluent opened a new pull request, #18661: URL: https://github.com/apache/kafka/pull/18661 Guard against the coordinator getting stuck due to deferred events throwing exceptions. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-21 Thread via GitHub
junrao commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1924163161 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -408,22 +407,44 @@ protected Map prepareFetchRequests() long cur

[jira] [Commented] (KAFKA-18369) State updater's *-ratio metrics are incorrect

2025-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915789#comment-17915789 ] Rafał Sumisławski commented on KAFKA-18369: --- [~lucasbru]  I described the simi

[jira] [Created] (KAFKA-18616) Refactor DumpLogSegments's MessageParsers

2025-01-21 Thread David Jacot (Jira)
David Jacot created KAFKA-18616: --- Summary: Refactor DumpLogSegments's MessageParsers Key: KAFKA-18616 URL: https://issues.apache.org/jira/browse/KAFKA-18616 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-18529: PlaintextAdminIntegrationTest and ConsumerRebootstrapTest should run for async consumer [kafka]

2025-01-21 Thread via GitHub
lianetm commented on code in PR #18554: URL: https://github.com/apache/kafka/pull/18554#discussion_r1924158432 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -207,10 +207,10 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

[jira] [Created] (KAFKA-18615) StreamThread *-ratio metrics suffer from sampling bias

2025-01-21 Thread Jira
Rafał Sumisławski created KAFKA-18615: - Summary: StreamThread *-ratio metrics suffer from sampling bias Key: KAFKA-18615 URL: https://issues.apache.org/jira/browse/KAFKA-18615 Project: Kafka

[jira] [Commented] (KAFKA-18285) Add Admin.describeStreamsGroups

2025-01-21 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915782#comment-17915782 ] Lucas Brutschy commented on KAFKA-18285: This is currently blocked, since this i

Re: [PR] Kafka 17792 header parsing times out processing and using large quantities of memory if the string looks like a number [kafka]

2025-01-21 Thread via GitHub
gharris1727 commented on code in PR #17510: URL: https://github.com/apache/kafka/pull/17510#discussion_r1924063426 ## connect/api/src/main/java/org/apache/kafka/connect/data/Values.java: ## @@ -71,6 +71,8 @@ public class Values { static final String ISO_8601_DATE_FORMAT_PAT

[jira] [Assigned] (KAFKA-18498) Kafka Streams main thread does not release lock

2025-01-21 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck reassigned KAFKA-18498: --- Assignee: Bill Bejeck > Kafka Streams main thread does not release lock > -

[jira] [Created] (KAFKA-18614) Add StreamsGroupDescribe handler in group coordinator

2025-01-21 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-18614: -- Summary: Add StreamsGroupDescribe handler in group coordinator Key: KAFKA-18614 URL: https://issues.apache.org/jira/browse/KAFKA-18614 Project: Kafka Iss

[jira] [Created] (KAFKA-18613) Add StreamsGroupHeartbeat handler in the group coordinator

2025-01-21 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-18613: -- Summary: Add StreamsGroupHeartbeat handler in the group coordinator Key: KAFKA-18613 URL: https://issues.apache.org/jira/browse/KAFKA-18613 Project: Kafka

[jira] [Assigned] (KAFKA-18613) Add StreamsGroupHeartbeat handler in the group coordinator

2025-01-21 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-18613: -- Assignee: Lucas Brutschy > Add StreamsGroupHeartbeat handler in the group coordinator

[jira] [Resolved] (KAFKA-15820) Add a metric to track the number of partitions under min ISR

2025-01-21 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-15820. Resolution: Won't Fix We can use the kafka.replication.under_min_isr to track this info > Add a m

Re: [PR] MINOR: Make `forceUnmap` protected since the only test class that references it is in the same package now. [kafka]

2025-01-21 Thread via GitHub
pramithas commented on PR #18638: URL: https://github.com/apache/kafka/pull/18638#issuecomment-2605316556 @divijvaidya Can you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-8862: Improve Producer error message for failed metadata update [kafka]

2025-01-21 Thread via GitHub
mjsax commented on PR #18587: URL: https://github.com/apache/kafka/pull/18587#issuecomment-2605224811 Great find, @ijuma. It's the exact same thing. Update the PR from "minor" to KAFKA-8862 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Resolved] (KAFKA-18302) Update CoordinatorRecord

2025-01-21 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18302. - Fix Version/s: 4.1.0 Resolution: Fixed > Update CoordinatorRecord > -

Re: [PR] KAFKA-18302; Update CoordinatorRecord [kafka]

2025-01-21 Thread via GitHub
dajac merged PR #18512: URL: https://github.com/apache/kafka/pull/18512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Created] (KAFKA-18612) Update ApiMessageFormatter

2025-01-21 Thread David Jacot (Jira)
David Jacot created KAFKA-18612: --- Summary: Update ApiMessageFormatter Key: KAFKA-18612 URL: https://issues.apache.org/jira/browse/KAFKA-18612 Project: Kafka Issue Type: Sub-task Rep

[jira] [Commented] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2025-01-21 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915767#comment-17915767 ] David Jacot commented on KAFKA-15402: - > I have added a timer around this method, an

[jira] [Commented] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2025-01-21 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915766#comment-17915766 ] David Jacot commented on KAFKA-15402: - Hi [~bdelbosc]. I agree that this is an issue

Re: [PR] KAFKA-18281: Kafka (3.9.0) is improperly validating non-advertised listeners for routable controller addresses [kafka]

2025-01-21 Thread via GitHub
ahuang98 commented on code in PR #18387: URL: https://github.com/apache/kafka/pull/18387#discussion_r1924087587 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -559,7 +559,16 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) controllerLis

Re: [PR] [WIP]KAFKA-18034: CommitRequestManager should fail pending requests on fatal coordinator errors [kafka]

2025-01-21 Thread via GitHub
m1a2st commented on code in PR #18548: URL: https://github.com/apache/kafka/pull/18548#discussion_r1924053429 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java: ## @@ -263,6 +264,12 @@ public void resetPollTimer(final long

Re: [PR] KAFKA-15370: Support Participation in 2PC (KIP-939) (2/N) [kafka]

2025-01-21 Thread via GitHub
jolshan merged PR #18316: URL: https://github.com/apache/kafka/pull/18316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Created] (KAFKA-18611) Update MV to enable transaction version 2 by default for 4.0

2025-01-21 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-18611: -- Summary: Update MV to enable transaction version 2 by default for 4.0 Key: KAFKA-18611 URL: https://issues.apache.org/jira/browse/KAFKA-18611 Project: Kafka

[jira] [Comment Edited] (KAFKA-18369) State updater's *-ratio metrics are incorrect

2025-01-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915761#comment-17915761 ] Matthias J. Sax edited comment on KAFKA-18369 at 1/21/25 4:54 PM:

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

2025-01-21 Thread via GitHub
mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2605263355 @fonsdant -- How are things. Any progress? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (KAFKA-18369) State updater's *-ratio metrics are incorrect

2025-01-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17915761#comment-17915761 ] Matthias J. Sax commented on KAFKA-18369: - Well, if we have two summed window, w

Re: [PR] KAFKA-8862: Improve Producer error message for failed metadata update [kafka]

2025-01-21 Thread via GitHub
mjsax commented on PR #18587: URL: https://github.com/apache/kafka/pull/18587#issuecomment-2605251207 Merged to `trunk`, and cherry-picked to `4.0` and 3.9` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (KAFKA-8862) Misleading exception message for non-existant partition

2025-01-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-8862: --- Fix Version/s: 4.0.0 3.9.1 (was: 4.1.0) > Misleadin

[jira] [Updated] (KAFKA-18571) Investigate the use of metadata caching to improve fetch request generation performance

2025-01-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18571: -- Labels: fetcher (was: ) > Investigate the use of metadata caching to improve fetch request generation

  1   2   3   >