jolshan commented on code in PR #18604:
URL: https://github.com/apache/kafka/pull/18604#discussion_r1924267950
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -600,6 +600,11 @@ class UnifiedLog(@volatile var logStartOffset: Long,
*/
def hasOngoingTransaction(producerId: Long, producerEpoch: Short): Boolean =
lock synchronized {
val entry = producerStateManager.activeProducers.get(producerId)
+ // With transactions V2, if we see a future epoch, we are likely in the
process of completing the previous transaction.
+ // Return early with ConcurrentTransactionsException until the transaction
completes.
+ if (entry != null && entry.currentTxnFirstOffset.isPresent &&
entry.producerEpoch() < producerEpoch)
Review Comment:
I would like to try to keep this change simple due to the code freeze. But
yes, we could do that in a followup. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
