ijuma commented on code in PR #18547:
URL: https://github.com/apache/kafka/pull/18547#discussion_r1924617888
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -188,14 +188,6 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
def valuesFromThisConfigWithPrefixOverride(prefix: String): util.Map[String,
AnyRef] =
super.valuesWithPrefixOverride(prefix)
- /** ********* Zookeeper Configuration ***********/
- val zkConnect: String = getString(ZkConfigs.ZK_CONNECT_CONFIG)
- val zkSessionTimeoutMs: Int = getInt(ZkConfigs.ZK_SESSION_TIMEOUT_MS_CONFIG)
- val zkConnectionTimeoutMs: Int =
-
Option(getInt(ZkConfigs.ZK_CONNECTION_TIMEOUT_MS_CONFIG)).map(_.toInt).getOrElse(getInt(ZkConfigs.ZK_SESSION_TIMEOUT_MS_CONFIG))
- val zkEnableSecureAcls: Boolean =
getBoolean(ZkConfigs.ZK_ENABLE_SECURE_ACLS_CONFIG)
- val zkMaxInFlightRequests: Int =
getInt(ZkConfigs.ZK_MAX_IN_FLIGHT_REQUESTS_CONFIG)
Review Comment:
Can we also remove thsm from `ZkConfigs`?
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -188,14 +188,6 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
def valuesFromThisConfigWithPrefixOverride(prefix: String): util.Map[String,
AnyRef] =
super.valuesWithPrefixOverride(prefix)
- /** ********* Zookeeper Configuration ***********/
- val zkConnect: String = getString(ZkConfigs.ZK_CONNECT_CONFIG)
- val zkSessionTimeoutMs: Int = getInt(ZkConfigs.ZK_SESSION_TIMEOUT_MS_CONFIG)
- val zkConnectionTimeoutMs: Int =
-
Option(getInt(ZkConfigs.ZK_CONNECTION_TIMEOUT_MS_CONFIG)).map(_.toInt).getOrElse(getInt(ZkConfigs.ZK_SESSION_TIMEOUT_MS_CONFIG))
- val zkEnableSecureAcls: Boolean =
getBoolean(ZkConfigs.ZK_ENABLE_SECURE_ACLS_CONFIG)
- val zkMaxInFlightRequests: Int =
getInt(ZkConfigs.ZK_MAX_IN_FLIGHT_REQUESTS_CONFIG)
Review Comment:
Can we also remove them from `ZkConfigs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
