kirktrue commented on code in PR #18532:
URL: https://github.com/apache/kafka/pull/18532#discussion_r1924353526
##########
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##########
@@ -319,17 +327,20 @@ class ConsumerBounceTest extends AbstractConsumerTest
with Logging {
* the group should be forced to rebalance when it becomes hosted on a
Coordinator with the new config.
* Then, 1 consumer should be left out of the group.
*/
- @Test
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+ @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
@Disabled // TODO: To be re-enabled once we can make it less flaky
(KAFKA-13421)
Review Comment:
KAFKA-13421 is still open, so I assume that's why we can't get rid of the
`@Disabled` annotation, right?
##########
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##########
@@ -401,11 +414,15 @@ class ConsumerBounceTest extends AbstractConsumerTest
with Logging {
*/
@ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly"))
+ // TODO: enable for all protocols after fix for not generating/blocking on
unneeded
+ // FindCoordinator on close for the new consumer
Review Comment:
Is this referring to KAFKA-18569?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
