[jira] [Commented] (KAFKA-14373) provide builders for producer/consumer

[ https://issues.apache.org/jira/browse/KAFKA-14373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712211#comment-17712211 ] Daniel Scanteianu commented on KAFKA-14373: --- possibly a duplicate of https://i

[jira] [Resolved] (KAFKA-7499) Extend ProductionExceptionHandler to cover serialization exceptions

[ https://issues.apache.org/jira/browse/KAFKA-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-7499. Fix Version/s: 3.5.0 Resolution: Fixed > Extend ProductionExceptionHandler to cover

[GitHub] [kafka] mjsax merged pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

mjsax merged PR #13477: URL: https://github.com/apache/kafka/pull/13477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Assigned] (KAFKA-14907) Add the traffic metric of the partition dimension in BrokerTopicStats

[ https://issues.apache.org/jira/browse/KAFKA-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi reassigned KAFKA-14907: -- Assignee: hudeqi > Add the traffic metric of the partition dimension in BrokerTopicStats > --

[jira] [Created] (KAFKA-14907) Add the traffic metric of the partition dimension in BrokerTopicStats

hudeqi created KAFKA-14907: -- Summary: Add the traffic metric of the partition dimension in BrokerTopicStats Key: KAFKA-14907 URL: https://issues.apache.org/jira/browse/KAFKA-14907 Project: Kafka Is

[jira] [Resolved] (KAFKA-14834) Improved processor semantics for versioned stores

[ https://issues.apache.org/jira/browse/KAFKA-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14834. - Fix Version/s: 3.5.0 Resolution: Fixed > Improved processor semantics for version

[GitHub] [kafka] jeqo commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

jeqo commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1166318900 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo read(Remote

[GitHub] [kafka] ijuma opened a new pull request, #13569: MINOR: Upgrade to Gradle 8.1

ijuma opened a new pull request, #13569: URL: https://github.com/apache/kafka/pull/13569 Release notes: https://docs.gradle.org/8.1/release-notes.html ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

[GitHub] [kafka] philipnee commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

philipnee commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1166283763 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -213,6 +212,32 @@ public void send(final String topic,

[GitHub] [kafka] hudeqi commented on pull request #13471: KAFKA-14868:Remove some forgotten metrics when the replicaManager is closed

hudeqi commented on PR #13471: URL: https://github.com/apache/kafka/pull/13471#issuecomment-1507928390 Hello, are you still reviewing this PR? @dajac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mjsax merged pull request #13566: KAFKA-14834: [10/N] Reserve repartition topic formats to include `isLatest`

mjsax merged PR #13566: URL: https://github.com/apache/kafka/pull/13566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] philipnee commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

philipnee commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1166276780 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -213,6 +212,32 @@ public void send(final String topic,

[GitHub] [kafka] mjsax merged pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

mjsax merged PR #13564: URL: https://github.com/apache/kafka/pull/13564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] hudeqi opened a new pull request, #13568: KAFKA-14906:Extract the coordinator service log from server log

hudeqi opened a new pull request, #13568: URL: https://github.com/apache/kafka/pull/13568 Currently, the coordinator service log and server log are mixed together. When troubleshooting the coordinator problem, it is necessary to filter from the server log, which is not very convenient. Ther

[jira] [Assigned] (KAFKA-14906) Extract the coordinator service log from server log

[ https://issues.apache.org/jira/browse/KAFKA-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi reassigned KAFKA-14906: -- Assignee: hudeqi > Extract the coordinator service log from server log >

[jira] [Created] (KAFKA-14906) Extract the coordinator service log from server log

hudeqi created KAFKA-14906: -- Summary: Extract the coordinator service log from server log Key: KAFKA-14906 URL: https://issues.apache.org/jira/browse/KAFKA-14906 Project: Kafka Issue Type: Improveme

[GitHub] [kafka] mjsax commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

mjsax commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1166240554 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/Change.java: ## @@ -42,12 +48,13 @@ public boolean equals(final Object o) { return false;

[GitHub] [kafka] mjsax merged pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return validTo

mjsax merged PR #13554: URL: https://github.com/apache/kafka/pull/13554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu resolved KAFKA-14139. Resolution: Fixed > Replaced disk can lead to loss of committed data even with non-empty ISR > ---

[jira] [Commented] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712165#comment-17712165 ] Calvin Liu commented on KAFKA-14139: It is resolved in https://issues.apache.org/jir

[GitHub] [kafka] mjsax commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

mjsax commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1166218023 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -213,6 +212,32 @@ public void send(final String topic,

[GitHub] [kafka] ijuma opened a new pull request, #13567: MINOR: Update zstd-jni to 1.5.5

ijuma opened a new pull request, #13567: URL: https://github.com/apache/kafka/pull/13567 1.5.4 is a large release that offers significant performance improvements across multiple scenarios, as well as new features. 1.5.5 is a smaller release that corrects a rare corruption bug and

[GitHub] [kafka] vcrfxia commented on pull request #13533: KAFKA-12446: update change encoding to use varint

vcrfxia commented on PR #13533: URL: https://github.com/apache/kafka/pull/13533#issuecomment-1507759402 Hey @mjsax changes LGTM (besides the checkstyle error) -- I opened https://github.com/apache/kafka/pull/13566 which would've conflicted with this change. Instead of having one of us rebas

[GitHub] [kafka] vcrfxia opened a new pull request, #13566: KAFKA-14834: [10/N] Reserve repartition topic formats to include `isLatest`

vcrfxia opened a new pull request, #13566: URL: https://github.com/apache/kafka/pull/13566 (This PR is stacked on https://github.com/apache/kafka/pull/13564. The first two commits do not need to be reviewed separately.) https://github.com/apache/kafka/pull/13564 introduced a new boole

[jira] [Updated] (KAFKA-14905) Failing tests in MM2 ForwardingAdmin test since KIP-894

[ https://issues.apache.org/jira/browse/KAFKA-14905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14905: Description: There are three tests which are consistently failing in MirrorConnectorsWithCustomFo

[jira] [Updated] (KAFKA-14905) Failing tests in MM2 ForwardingAdmin test since KIP-894

[ https://issues.apache.org/jira/browse/KAFKA-14905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14905: Description: There are three tests which are consistently failing in MirrorConnectorsWithCustomFo

[jira] [Created] (KAFKA-14905) Failing tests in MM2 ForwardingAdmin test since KIP-894

Greg Harris created KAFKA-14905: --- Summary: Failing tests in MM2 ForwardingAdmin test since KIP-894 Key: KAFKA-14905 URL: https://issues.apache.org/jira/browse/KAFKA-14905 Project: Kafka Issue T

[GitHub] [kafka] mjsax commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

mjsax commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1166127428 ## streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueStoreWrapper.java: ## @@ -39,6 +39,9 @@ */ public class KeyValueStoreWrapper implements State

[GitHub] [kafka] mjsax commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

mjsax commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1166126656 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/Change.java: ## @@ -22,10 +22,16 @@ public final T newValue; public final T oldValue; +

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1166126612 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/Change.java: ## @@ -42,12 +48,13 @@ public boolean equals(final Object o) { return fals

[GitHub] [kafka] mjsax commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

mjsax commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1166126315 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimestampedCacheFlushListener.java: ## @@ -47,7 +47,8 @@ public void apply(final Record>> record) {

[GitHub] [kafka] mjsax commented on a diff in pull request #13565: KAFKA-14834: [N/9] Disable versioned-stores for unsupported operations

mjsax commented on code in PR #13565: URL: https://github.com/apache/kafka/pull/13565#discussion_r1166125557 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java: ## @@ -177,6 +178,24 @@ public void shouldBuildSimpleGlobalTableTopol

[GitHub] [kafka] mjsax commented on a diff in pull request #13565: KAFKA-14834: [N/9] Disable versioned-stores for unsupported operations

mjsax commented on code in PR #13565: URL: https://github.com/apache/kafka/pull/13565#discussion_r1166125010 ## streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java: ## @@ -369,6 +369,8 @@ public synchronized KTable table(final String topic, * * Note

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1166124000 ## streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueStoreWrapper.java: ## @@ -39,6 +39,9 @@ */ public class KeyValueStoreWrapper implements Sta

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1166121244 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimestampedCacheFlushListener.java: ## @@ -47,7 +47,8 @@ public void apply(final Record>> record) {

[GitHub] [kafka] mjsax commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

mjsax commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1166102301 ## streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueStoreWrapper.java: ## @@ -39,6 +39,9 @@ */ public class KeyValueStoreWrapper implements State

[GitHub] [kafka] bbejeck commented on a diff in pull request #13565: KAFKA-14834: [N/9] Disable versioned-stores for unsupported operations

bbejeck commented on code in PR #13565: URL: https://github.com/apache/kafka/pull/13565#discussion_r1166100148 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ## @@ -539,6 +540,10 @@ public KStream toStream(final KeyValueMapper suppress(fina

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13565: KAFKA-14834: [N/9] Disable versioned-stores for unsupported operations

vcrfxia commented on code in PR #13565: URL: https://github.com/apache/kafka/pull/13565#discussion_r1166096414 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -164,6 +166,11 @@ public GlobalKTable globalTable(final String

[GitHub] [kafka] mjsax commented on a diff in pull request #13565: KAFKA-14834: [N/9] Disable versioned-stores for unsupported operations

mjsax commented on code in PR #13565: URL: https://github.com/apache/kafka/pull/13565#discussion_r1166095377 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/SuppressTopologyTest.java: ## @@ -209,4 +213,33 @@ public void shouldApplyNameToSuppressionNode() {

[GitHub] [kafka] mjsax commented on a diff in pull request #13565: KAFKA-14834: [N/9] Disable versioned-stores for unsupported operations

mjsax commented on code in PR #13565: URL: https://github.com/apache/kafka/pull/13565#discussion_r1166094148 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ## @@ -539,6 +540,10 @@ public KStream toStream(final KeyValueMapper suppress(final

[GitHub] [kafka] mjsax opened a new pull request, #13565: KAFKA-14834: [N/9] Disable versioned-stores for unsupported operations

mjsax opened a new pull request, #13565: URL: https://github.com/apache/kafka/pull/13565 Using versioned-stores for global-KTables is not allowed, because a global-table is bootstrapped on startup, and a stream-globalTable join does not support temporal semantics. Furthermore, `suppr

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1166087199 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/Change.java: ## @@ -42,12 +48,13 @@ public boolean equals(final Object o) { return fals

[jira] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

[ https://issues.apache.org/jira/browse/KAFKA-14904 ] Justine Olshan deleted comment on KAFKA-14904: was (Author: jolshan): Seems like we close the producer forcefully. Perhaps this is why we never complete the future for the end txn (commi

[GitHub] [kafka] vcrfxia opened a new pull request, #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia opened a new pull request, #13564: URL: https://github.com/apache/kafka/pull/13564 (This PR is stacked on https://github.com/apache/kafka/pull/13554. The first commit does not need to be reviewed separately.) This PR adds an additional boolean `isLatest` into `Change` which sp

[jira] [Commented] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

[ https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712115#comment-17712115 ] Justine Olshan commented on KAFKA-14904: Seems like we close the producer forcef

[jira] [Updated] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

[ https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14904: --- Description: After merging KAFKA-14561 I noticed this test still occasionally failed via  o

[GitHub] [kafka] cmccabe commented on pull request #13551: MINOR: Allow tagged fields with version subset of flexible version range

cmccabe commented on PR #13551: URL: https://github.com/apache/kafka/pull/13551#issuecomment-1507673705 Thanks for finding this. I think the fix is sort of debatable. If a message has `flexibleVersions: "1+"` and we set `taggedVersions: "0+"` on some field, shouldn't that be an error that a

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1166062323 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -114,6 +127,7 @@ public class Worker { public static final long CONNECTOR_G

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1166062401 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -1237,6 +1238,34 @@ public void testInitTransactionWhileThrottled() {

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1166062323 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -114,6 +127,7 @@ public class Worker { public static final long CONNECTOR_G

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1166059935 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -607,6 +608,14 @@ public synchronized void handleCompletedBatch(Pro

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1166059149 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -155,7 +155,7 @@ private enum State { private boolean isTra

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1166058138 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try { transacti

[jira] [Commented] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

[ https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712090#comment-17712090 ] Justine Olshan commented on KAFKA-14904: Jenkins truncates this out since the bo

[GitHub] [kafka] mjsax merged pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax merged PR #13552: URL: https://github.com/apache/kafka/pull/13552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] junrao commented on a diff in pull request #13503: MINOR: Refactor TierStateMachine related tests into a separate test file

junrao commented on code in PR #13503: URL: https://github.com/apache/kafka/pull/13503#discussion_r1166015374 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherTierStateMachineTest.scala: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return validTo

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1166012524 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -837,6 +847,7 @@ private void finishPut( segment

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return validTo

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1166012524 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -837,6 +847,7 @@ private void finishPut( segment

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return validTo

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1166012353 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -825,7 +835,7 @@ private void finishPut( if (Ro

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return validTo

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1166009780 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -641,6 +642,8 @@ private PutStatus maybePutToLatestValueStore(

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return validTo

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1166009780 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStore.java: ## @@ -641,6 +642,8 @@ private PutStatus maybePutToLatestValueStore(

[GitHub] [kafka] junrao commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

junrao commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1164654776 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1083,48 +1095,100 @@ class ReplicaManager(val config: KafkaConfig, fetchPartitionStatus += (t

[GitHub] [kafka] wcarlson5 merged pull request #13491: KAFKA-14722: Make BooleanSerde public (an addition of upgrade.html changes)

wcarlson5 merged PR #13491: URL: https://github.com/apache/kafka/pull/13491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return validTo

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1165998633 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -84,22 +86,37 @@ extends MeteredKeyValueStore> {

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return validTo

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1165996502 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -84,22 +86,37 @@ extends MeteredKeyValueStore> {

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return validTo

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1165993027 ## streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java: ## @@ -41,6 +42,9 @@ */ public interface VersionedKeyValueStore extends StateStore

[GitHub] [kafka] mjsax commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1165991631 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java: ## @@ -705,12 +711,304 @@ public void shouldNotOptimizeJoinWhenNotInC

[GitHub] [kafka] mjsax opened a new pull request, #13563: MINOR: Refactor changelogger to accept timestamp

mjsax opened a new pull request, #13563: URL: https://github.com/apache/kafka/pull/13563 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

[GitHub] [kafka] dajac commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

dajac commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165986528 ## core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala: ## @@ -148,17 +152,23 @@ object TransactionLog { // Formatter for use with tools to read tra

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return boolean

vcrfxia commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1165975843 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -84,22 +86,37 @@ extends MeteredKeyValueStore> {

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1165960472 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -153,43 +158,45 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1165959573 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -153,43 +158,46 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return boolean

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1165957316 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -84,22 +86,37 @@ extends MeteredKeyValueStore> {

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1165947809 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -16,6 +16,13 @@ */ package org.apache.kafka.clients.consume

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return boolean

vcrfxia commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1165935761 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -84,22 +86,37 @@ extends MeteredKeyValueStore> {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return boolean

vcrfxia commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1165935761 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -84,22 +86,37 @@ extends MeteredKeyValueStore> {

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165929989 ## core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala: ## @@ -148,17 +152,23 @@ object TransactionLog { // Formatter for use with tools to read

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165928094 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -683,8 +685,10 @@ class GroupMetadataManager(brokerId: Int, re

[GitHub] [kafka] mjsax commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return boolean

mjsax commented on code in PR #13554: URL: https://github.com/apache/kafka/pull/13554#discussion_r1165926367 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -84,22 +86,37 @@ extends MeteredKeyValueStore> {

[jira] [Created] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

Justine Olshan created KAFKA-14904: -- Summary: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId() Key: KAFKA-14904 URL: https://issues.apache.org/jira/browse/KAFKA-14904 Project: Kafka

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165922479 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -1368,3 +1378,8 @@ case class GroupMetadataKey(version: Short, key: String) extends

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165919308 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -1155,7 +1159,12 @@ object GroupMetadataManager { // version 2 refers to group

[GitHub] [kafka] ruslankrivoshein opened a new pull request, #13562: KAFKA-14581: Moving GetOffsetShell to tools

ruslankrivoshein opened a new pull request, #13562: URL: https://github.com/apache/kafka/pull/13562 WIP This PR is based on [another PR](https://github.com/apache/kafka/pull/13158). During development I just had copied that files, since there was no more remarks. Also I've stuck w

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1165892001 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/MemberAssignment.java: ## @@ -54,6 +60,6 @@ public int hashCode() { @Override

[GitHub] [kafka] Hangleton commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

Hangleton commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165769118 ## core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala: ## @@ -148,17 +152,23 @@ object TransactionLog { // Formatter for use with tools to read

[GitHub] [kafka] yashmayya commented on a diff in pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

yashmayya commented on code in PR #13530: URL: https://github.com/apache/kafka/pull/13530#discussion_r1165743153 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -229,7 +229,12 @@ private synchronized void putConnectorConf

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1165681079 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/common/TopicIdToPartition.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1165679441 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicMetadata.java: ## @@ -25,12 +25,12 @@ public class AssignmentTopicMetada

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1165678602 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ## @@ -37,29 +39,30 @@ public class AssignmentMemberSpec {

[GitHub] [kafka] dajac commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

dajac commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1165647641 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -683,8 +685,10 @@ class GroupMetadataManager(brokerId: Int, remove

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1165614955 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1142,9 +1190,20 @@ public ControllerResult generateRecordsAndResult() throws Excepti

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1165608795 ## clients/src/main/java/org/apache/kafka/common/record/CompressionType.java: ## @@ -64,17 +66,20 @@ public OutputStream wrapForOutput(ByteBufferOutputStream buffe

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] Hangleton commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1165606409 ## core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala: ## @@ -824,14 +823,14 @@ private[group] class GroupMetadata(val groupId: String, initialState: Gr

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1165588383 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ## @@ -108,6 +112,12 @@ public Integer value() { return me

[GitHub] [kafka] cadonna commented on pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

cadonna commented on PR #12607: URL: https://github.com/apache/kafka/pull/12607#issuecomment-1507025872 > What worries you about the testing strategy in the class? My worry is that we verify interactions with mocks (mainly strict mocks) in unit tests in which we test unrelated aspects

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1165568140 ## raft/src/main/java/org/apache/kafka/raft/internals/RecordsIterator.java: ## @@ -215,14 +215,14 @@ private Batch readBatch(DefaultRecordBatch batch) {

  1   2   >