vcrfxia commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1166124000
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueStoreWrapper.java:
##########
@@ -39,6 +39,9 @@
*/
public class KeyValueStoreWrapper<K, V> implements StateStore {
+ public static final long PUT_RETURN_CODE_IS_LATEST
Review Comment:
Technically no since we could just use `PUT_RETURN_CODE_VALID_TO_UNDEFINED`
directly instead. I just thought it might be confusing for readers to reason
about why we set `isLatest = putReturnCode ==
PUT_RETURN_CODE_VALID_TO_UNDEFINED;` everywhere, especially since
`PUT_RETURN_CODE_VALID_TO_UNDEFINED` is defined in `VersionedKeyValueStore` and
appears to be specific to versioned stores on first glance, whereas
`KeyValueStoreWrapper#put()` is more general (supports timestamped stores too).
If you think this indirection is even more confusing, though, I can remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
