jeffkbkim commented on code in PR #13511:
URL: https://github.com/apache/kafka/pull/13511#discussion_r1165919308
##########
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##########
@@ -1155,7 +1159,12 @@ object GroupMetadataManager {
// version 2 refers to group metadata
val key = new GroupMetadataKeyData(new ByteBufferAccessor(buffer),
version)
GroupMetadataKey(version, key.group)
- } else throw new IllegalStateException(s"Unknown group metadata message
version: $version")
+ } else {
+ // Unknown versions may exist when a downgraded coordinator is reading
records from the log.
+ warn(s"Found unknown message key version: $version." +
+ s" The downgraded coordinator will ignore this key and corresponding
value.")
Review Comment:
makes sense, will use Unknown instead of Unexpected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
