ruslankrivoshein opened a new pull request, #13562:
URL: https://github.com/apache/kafka/pull/13562

   WIP
   
   This PR is based on [another 
PR](https://github.com/apache/kafka/pull/13158). During development I just had 
copied that files, since there was no more remarks.
   Also I've stuck with one thing. GetOffsetShellTest extends 
KafkaServerTestHarness and KafkaServerTestHarness extends QuorumTestHarness, 
all of them are written in Scala, so I'd like to ask any suggestion about 
refactoring. A lot of test classes depends on KafkaServerTestHarness, so after 
GetOffsetShellTest that class also must be rewritten at the same time. Should I 
start rewriting it completely or I may write any stub for the first time?
   And I also have to ask about createTopicPartitionFilterWithPatternList and 
createTopicPartitionFilterWithTopicAndPartitionPattern methods. For sake of 
good tests transfer I've made that methods public. Is that good for such a 
little util command?
   
   @ijuma, @mimaison, I hope I tag you right. Could you take a look and clarify 
it for me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to