[GitHub] [kafka] mjsax commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

[via GitHub]

mjsax commented on code in PR #13564:
URL: https://github.com/apache/kafka/pull/13564#discussion_r1166126315


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimestampedCacheFlushListener.java:
##########
@@ -47,7 +47,8 @@ public void apply(final Record<KOut, 
Change<ValueAndTimestamp<VOut>>> record) {
                     .withValue(
                         new Change<>(
                             getValueOrNull(record.value().newValue),
-                            getValueOrNull(record.value().oldValue)))
+                            getValueOrNull(record.value().oldValue),
+                            record.value().isLatest))

Review Comment:
   Ah. Yes, versioned stores always disable caching, so we are fine. Thanks for 
the reminder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org