[jira] (KAFKA-14453) Flaky test suite MirrorConnectorsWithCustomForwardingAdminIntegrationTest

[ https://issues.apache.org/jira/browse/KAFKA-14453 ] Kamalesh Palanisamy deleted comment on KAFKA-14453: - was (Author: JIRAUSER298672): [~ChrisEgerton] is this test still failing? I am a newbie and I can look into this. Thanks! > Flak

[GitHub] [kafka] smjn commented on a diff in pull request #13119: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

smjn commented on code in PR #13119: URL: https://github.com/apache/kafka/pull/13119#discussion_r1070212730 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetriever.java: ## @@ -240,6 +240,9 @@ static String handleOutput(fi

[GitHub] [kafka] jolshan commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070186362 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp = expireTime

[GitHub] [kafka] jolshan commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070186244 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp = expireTime

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070170859 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2764,37 +2763,170 @@ class KafkaApisTest { val request = buildRequest(offsetDeleteRequest)

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1070162021 ## core/src/test/scala/unit/kafka/server/ControllerApisTest.scala: ## @@ -523,8 +523,23 @@ class ControllerApisTest { new ListPartitionReassignmentsReques

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1070162021 ## core/src/test/scala/unit/kafka/server/ControllerApisTest.scala: ## @@ -523,8 +523,23 @@ class ControllerApisTest { new ListPartitionReassignmentsReques

[GitHub] [kafka] rondagostino commented on pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1382580751 Thanks, Colin. I moved the minor stuff into https://github.com/apache/kafka/pull/13118 and put the check into `ControllerApis`. The only difference with what you suggested is that

[jira] [Commented] (KAFKA-14622) Create a junit test which would have caught KAFKA-14618

[ https://issues.apache.org/jira/browse/KAFKA-14622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676788#comment-17676788 ] José Armando García Sancio commented on KAFKA-14622: One suggestion

[GitHub] [kafka] jsancio commented on pull request #13108: KAFKA-14618; Fix off by one error in snapshot id

jsancio commented on PR #13108: URL: https://github.com/apache/kafka/pull/13108#issuecomment-1382578491 > Can you file a JIRA for creating a test that would have caught this? Yes. When I implement https://issues.apache.org/jira/browse/KAFKA-14619, we can reliably catch this kind of is

[GitHub] [kafka] jsancio commented on a diff in pull request #13108: KAFKA-14618; Fix off by one error in snapshot id

jsancio commented on code in PR #13108: URL: https://github.com/apache/kafka/pull/13108#discussion_r1070156218 ## metadata/src/main/java/org/apache/kafka/image/MetadataProvenance.java: ## @@ -28,30 +29,30 @@ public final class MetadataProvenance { public static final Metad

[GitHub] [kafka] jolshan commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jolshan commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1070132569 ## clients/src/main/java/org/apache/kafka/common/requests/ConsumerGroupHeartbeatRequest.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] jolshan commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jolshan commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1070126393 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -185,11 +215,11 @@ public static ApiVersionsResponse createApiVersionsRespons

[jira] [Commented] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

[ https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676778#comment-17676778 ] Kirk True commented on KAFKA-14623: --- cc [~smjn] [~omkreddy]  > OAuth's HttpAccessToke

[GitHub] [kafka] jolshan commented on pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jolshan commented on PR #12902: URL: https://github.com/apache/kafka/pull/12902#issuecomment-1382451476 Things are starting to fall into a pretty common pattern here. :) Looks pretty good, but I'll give Jeff a chance to take a look as well. -- This is an automated message from the Apache

[GitHub] [kafka] kirktrue commented on a diff in pull request #13119: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

kirktrue commented on code in PR #13119: URL: https://github.com/apache/kafka/pull/13119#discussion_r1070115905 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetriever.java: ## @@ -240,6 +240,9 @@ static String handleOutpu

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070115003 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2817,14 +2949,18 @@ class KafkaApisTest { .setTopics(topics) ).build() val r

[GitHub] [kafka] kirktrue commented on pull request #13119: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

kirktrue commented on PR #13119: URL: https://github.com/apache/kafka/pull/13119#issuecomment-1382446967 @smjn @omkreddy - can you take a look at this fix for OAuth logging potentially exposing secrets? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] kirktrue opened a new pull request, #13119: KAFKA-14623: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

kirktrue opened a new pull request, #13119: URL: https://github.com/apache/kafka/pull/13119 Removed logging of the HTTP response directly in all known cases to prevent potentially logging access tokens. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] jolshan commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1070097639 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2817,14 +2949,18 @@ class KafkaApisTest { .setTopics(topics) ).build() val

[GitHub] [kafka] bbejeck merged pull request #13115: Update doc entry in ProducerConfig.java to be consistent with behavior described in max.in.flight.requests.per.connection

bbejeck merged PR #13115: URL: https://github.com/apache/kafka/pull/13115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] bbejeck commented on pull request #13115: Update doc entry in ProducerConfig.java to be consistent with behavior described in max.in.flight.requests.per.connection

bbejeck commented on PR #13115: URL: https://github.com/apache/kafka/pull/13115#issuecomment-1382419745 merged #13115 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Assigned] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

[ https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-14623: - Assignee: Kirk True > OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging >

[jira] [Created] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

Kirk True created KAFKA-14623: - Summary: OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging Key: KAFKA-14623 URL: https://issues.apache.org/jira/browse/KAFKA-14623 Project: Kafka

[GitHub] [kafka] rondagostino commented on a diff in pull request #13118: MINOR: fix some typos in comments/docs/variable names

rondagostino commented on code in PR #13118: URL: https://github.com/apache/kafka/pull/13118#discussion_r1070083056 ## docs/ops.html: ## @@ -1197,7 +1197,7 @@ - Client quotas: Kafka supports different types of (per-user principal) client quotas. Because a client's quota

[GitHub] [kafka] rondagostino opened a new pull request, #13118: MINOR: fix some typos in comments/docs/variable names

rondagostino opened a new pull request, #13118: URL: https://github.com/apache/kafka/pull/13118 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[GitHub] [kafka] cmccabe commented on pull request #13108: KAFKA-14618; Fix off by one error in snapshot id

cmccabe commented on PR #13108: URL: https://github.com/apache/kafka/pull/13108#issuecomment-1382409158 I filed a follow-up jira here https://issues.apache.org/jira/browse/KAFKA-14622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (KAFKA-14622) Create a junit test which would have caught KAFKA-14618

Colin McCabe created KAFKA-14622: Summary: Create a junit test which would have caught KAFKA-14618 Key: KAFKA-14622 URL: https://issues.apache.org/jira/browse/KAFKA-14622 Project: Kafka Issue

[jira] [Resolved] (KAFKA-14618) Off by one error in generated snapshot IDs causes misaligned fetching

[ https://issues.apache.org/jira/browse/KAFKA-14618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-14618. -- Resolution: Fixed > Off by one error in generated snapshot IDs causes misaligned fetching > --

[GitHub] [kafka] cmccabe commented on pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

cmccabe commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1382406862 Thanks very much for this, @rondagostino ! Anyway what I’d like to do here is two things: 1. split all the spelling corrections and docs changes into a separate PR which we can

[GitHub] [kafka] cmccabe commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

cmccabe commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1070071187 ## docs/ops.html: ## @@ -1197,7 +1197,7 @@ - Client quotas: Kafka supports different types of (per-user principal) client quotas. Because a client's quotas app

[GitHub] [kafka] rondagostino commented on pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1382381390 Only implemented/tested the create-topics case so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1070011382 ## metadata/src/main/java/org/apache/kafka/controller/ControllerRequestContext.java: ## @@ -42,19 +45,39 @@ public static OptionalLong requestTimeoutMsToDeadlineNs

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r107035 ## docs/ops.html: ## @@ -1197,7 +1197,7 @@ - Client quotas: Kafka supports different types of (per-user principal) client quotas. Because a client's quota

[GitHub] [kafka] rondagostino opened a new pull request, #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino opened a new pull request, #13116: URL: https://github.com/apache/kafka/pull/13116 Adds hooks to check controller mutation quotas in KRaft. It won't actually work in practice until controllers support dynamic reconfiguration (https://issues.apache.org/jira/browse/KAFKA-14

[jira] [Assigned] (KAFKA-14351) Implement controller mutation quotas in KRaft

[ https://issues.apache.org/jira/browse/KAFKA-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino reassigned KAFKA-14351: - Assignee: Ron Dagostino > Implement controller mutation quotas in KRaft > -

[GitHub] [kafka] cherylws opened a new pull request, #13115: Update doc entry in ProducerConfig.java to be consistent with behavior described in max.in.flight.requests.per.connection

cherylws opened a new pull request, #13115: URL: https://github.com/apache/kafka/pull/13115 This should be greater than 1 to be consistent with behavior described in max.in.flight.requests.per.connection property. *More detailed description of your change, if necessary. The PR titl

[jira] [Created] (KAFKA-14621) Don't startup in migration mode if an authorizer is enabled

David Arthur created KAFKA-14621: Summary: Don't startup in migration mode if an authorizer is enabled Key: KAFKA-14621 URL: https://issues.apache.org/jira/browse/KAFKA-14621 Project: Kafka

[GitHub] [kafka] dajac commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1069967097 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp = expireTimest

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

artemlivshits commented on code in PR #12901: URL: https://github.com/apache/kafka/pull/12901#discussion_r1069963790 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -397,19 +389,24 @@ class GroupCoordinatorAdapter( request: TxnOffsetCommi

[GitHub] [kafka] rondagostino commented on pull request #12587: [WIP] MINOR: Use named class for ExpiringCredential to improve `principalLogText()` output

rondagostino commented on PR #12587: URL: https://github.com/apache/kafka/pull/12587#issuecomment-1382319525 Ok, I looked at this again, and I think there was a mistake combined with a poorly named variable that was causing confusion. The `private String principalName = null;` variabl

[jira] (KAFKA-14603) Move KafkaMetricsGroup to server-common module.

[ https://issues.apache.org/jira/browse/KAFKA-14603 ] Ivan Yurchenko deleted comment on KAFKA-14603: was (Author: ivanyu): https://github.com/apache/kafka/pull/13067 > Move KafkaMetricsGroup to server-common module. > --

[GitHub] [kafka] ivanyu commented on pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on PR #13067: URL: https://github.com/apache/kafka/pull/13067#issuecomment-1382303264 I've finished porting `KafkaMetricsGroup` to Java and I'm opening this for review. I decided to not implement the performance improvements @lbownik proposed above and stick to verba

[GitHub] [kafka] kamalcph commented on pull request #13060: KAFKA-14559: Fix JMX tool to handle the object names with wild cards and optional attributes

kamalcph commented on PR #13060: URL: https://github.com/apache/kafka/pull/13060#issuecomment-1382263830 @ijuma @showuon @mimaison Ping for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] kamalcph commented on pull request #13059: MINOR: KafkaConfig should not expose internal config when queried for non-internal values

kamalcph commented on PR #13059: URL: https://github.com/apache/kafka/pull/13059#issuecomment-1382262128 @ijuma @showuon Can you merge this patch? Rebased with the trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1069827409 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -42,7 +43,7 @@ class BrokerMetadataListener( val snapshotter: Option[MetadataSnapshot

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1069826661 ## core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala: ## @@ -34,7 +33,7 @@ import scala.jdk.CollectionConverters._ /** * This is an integration test

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1069825536 ## core/src/main/scala/kafka/log/remote/RemoteLogManager.scala: ## @@ -48,7 +47,7 @@ import scala.jdk.CollectionConverters._ */ class RemoteLogManager(rlmConfig: Remo

[GitHub] [kafka] jolshan commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1069791363 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp = expireTime

[GitHub] [kafka] cmccabe merged pull request #13108: KAFKA-14618; Fix off by one error in snapshot id

cmccabe merged PR #13108: URL: https://github.com/apache/kafka/pull/13108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] jolshan commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1069791363 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp = expireTime

[GitHub] [kafka] jolshan commented on a diff in pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12902: URL: https://github.com/apache/kafka/pull/12902#discussion_r1069791363 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala: ## @@ -470,4 +470,45 @@ class GroupCoordinatorAdapter( expireTimestamp = expireTime

[GitHub] [kafka] fvaleri commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

fvaleri commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1069628843 ## tools/src/main/java/org/apache/kafka/tools/EndToEndLatency.java: ## @@ -0,0 +1,309 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] pprovenzano opened a new pull request, #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano opened a new pull request, #13114: URL: https://github.com/apache/kafka/pull/13114 This commit adds support to store the SCRAM credentials in a cluster with KRaft quorum servers and no ZK cluster backing the metadata. This commit does not include changes to allow bootstrap

[GitHub] [kafka] woja commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

woja commented on PR #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1382118315 Great! I'll take a look then On Fri, 13 Jan 2023 at 10:18, Bruno Cadonna ***@***.***> wrote: > @woja Thank you for your interest! > > You can f

[jira] [Commented] (KAFKA-14453) Flaky test suite MirrorConnectorsWithCustomForwardingAdminIntegrationTest

[ https://issues.apache.org/jira/browse/KAFKA-14453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676683#comment-17676683 ] Kamalesh Palanisamy commented on KAFKA-14453: - [~ChrisEgerton] is this test

[jira] [Commented] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676682#comment-17676682 ] Kamalesh Palanisamy commented on KAFKA-14218: - [~divijvaidya] [~showuon] is

[jira] [Commented] (KAFKA-5238) BrokerTopicMetrics can be recreated after topic is deleted

[ https://issues.apache.org/jira/browse/KAFKA-5238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676681#comment-17676681 ] Edoardo Comar commented on KAFKA-5238: -- Retrying with https://github.com/apache/kafk

[GitHub] [kafka] edoardocomar opened a new pull request, #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

edoardocomar opened a new pull request, #13113: URL: https://github.com/apache/kafka/pull/13113 Do not recreate the BrokerTopicMetrics on creating the fetch response to a DelayedFetch request executed after a topic was deleted Add a variant of MetricsTest.testBrokerTopicMetricsUnregi

[GitHub] [kafka] edoardocomar commented on pull request #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

edoardocomar commented on PR #13113: URL: https://github.com/apache/kafka/pull/13113#issuecomment-1382078154 This PR comes adapted to current trunk many many years after https://github.com/apache/kafka/pull/4204 thanks to @mimaison @ijuma @rajinisivaram who had reviewed it. That was

[jira] [Commented] (KAFKA-13709) Document exactly-once support for source connectors

[ https://issues.apache.org/jira/browse/KAFKA-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676676#comment-17676676 ] ASF GitHub Bot commented on KAFKA-13709: C0urante commented on PR #478: URL: htt

[jira] [Commented] (KAFKA-13709) Document exactly-once support for source connectors

[ https://issues.apache.org/jira/browse/KAFKA-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676675#comment-17676675 ] ASF GitHub Bot commented on KAFKA-13709: C0urante opened a new pull request, #47

[jira] [Assigned] (KAFKA-14610) Publish Mirror Maker 2 offset syncs in task commit method

[ https://issues.apache.org/jira/browse/KAFKA-14610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14610: - Assignee: Chris Egerton > Publish Mirror Maker 2 offset syncs in task commit method > -

[GitHub] [kafka] edoardocomar closed pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

edoardocomar closed pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted URL: https://github.com/apache/kafka/pull/4204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] dajac closed pull request #13110: KAFKA-14367; Add `partitionFor` and `handleTxnCompletion` to the new `GroupCoordinator` interface

dajac closed pull request #13110: KAFKA-14367; Add `partitionFor` and `handleTxnCompletion` to the new `GroupCoordinator` interface URL: https://github.com/apache/kafka/pull/13110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] dajac commented on pull request #13110: KAFKA-14367; Add `partitionFor` and `handleTxnCompletion` to the new `GroupCoordinator` interface

dajac commented on PR #13110: URL: https://github.com/apache/kafka/pull/13110#issuecomment-1382015201 Included in https://github.com/apache/kafka/pull/13112. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] dajac opened a new pull request, #13112: KAFKA-14367; Finalize migration to the new GroupCoordinator interface

dajac opened a new pull request, #13112: URL: https://github.com/apache/kafka/pull/13112 WIP - This includes https://github.com/apache/kafka/pull/13110 at the momnent. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify tes

[jira] [Commented] (KAFKA-14615) Use sizeCompare(Iterable[_]) to compare two iterables

[ https://issues.apache.org/jira/browse/KAFKA-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676660#comment-17676660 ] Divij Vaidya commented on KAFKA-14615: -- [~kamalesh0420]  You can either start with

[GitHub] [kafka] calmera commented on a diff in pull request #12740: Update of the PAPI testing classes to the latest implementation

calmera commented on code in PR #12740: URL: https://github.com/apache/kafka/pull/12740#discussion_r1069563020 ## streams/src/test/java/org/apache/kafka/test/MockProcessor.java: ## @@ -41,16 +44,16 @@ public MockProcessor() { delegate = new MockApiProcessor<>(); }

[GitHub] [kafka] calmera commented on a diff in pull request #12740: Update of the PAPI testing classes to the latest implementation

calmera commented on code in PR #12740: URL: https://github.com/apache/kafka/pull/12740#discussion_r1069562574 ## streams/src/test/java/org/apache/kafka/test/MockProcessor.java: ## @@ -28,9 +29,11 @@ import java.util.List; import java.util.Map; -@SuppressWarnings("deprecatio

[GitHub] [kafka] C0urante merged pull request #13106: KAFKA-13709 (follow-up): Fix wording around exactly-once in Connect

C0urante merged PR #13106: URL: https://github.com/apache/kafka/pull/13106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante commented on pull request #13106: KAFKA-13709 (follow-up): Fix wording around exactly-once in Connect

C0urante commented on PR #13106: URL: https://github.com/apache/kafka/pull/13106#issuecomment-1381923555 👍 Thanks Matthias! Will backport to 3.4 and 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676359#comment-17676359 ] Terry Beard edited comment on KAFKA-14565 at 1/13/23 1:31 PM:

[GitHub] [kafka] divijvaidya commented on pull request #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

divijvaidya commented on PR #13111: URL: https://github.com/apache/kafka/pull/13111#issuecomment-1381853980 @jolshan, since you are our topic Id expert, please take a look at this change when you get a chance. I would request some urgency (if possible) since I would preferably like to have

[GitHub] [kafka] divijvaidya opened a new pull request, #13111: KAFKA-14190: Update Zk TopicId from locally stored cache in controller

divijvaidya opened a new pull request, #13111: URL: https://github.com/apache/kafka/pull/13111 ## Change Controller should update Zk with locally cached TopicId (when available) instead of assigning a new one when Zk doesn't have a TopicId. ## Motivation for this change This pro

[jira] [Comment Edited] (KAFKA-14565) Improve Interceptor Resource Leakage Prevention

[ https://issues.apache.org/jira/browse/KAFKA-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676359#comment-17676359 ] Terry Beard edited comment on KAFKA-14565 at 1/13/23 12:48 PM: ---

[jira] [Assigned] (KAFKA-14586) Move StreamsResetter to tools

[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14586: - Assignee: Sagar Rao > Move StreamsResetter to tools > - > >

[jira] [Assigned] (KAFKA-14583) Move ReplicaVerificationTool to tools

[ https://issues.apache.org/jira/browse/KAFKA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14583: - Assignee: Sagar Rao > Move ReplicaVerificationTool to tools > -

[jira] [Commented] (KAFKA-14490) Consider using UncheckdIOException instead of IOException in the log layer

[ https://issues.apache.org/jira/browse/KAFKA-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676593#comment-17676593 ] Sagar Rao commented on KAFKA-14490: --- [~ijuma] , can I take this one up?  > Consider u

[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1381703690 Looks like there are some more checkstyle failures. Will fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on code in PR #13095: URL: https://github.com/apache/kafka/pull/13095#discussion_r1069260140 ## tests/kafkatest/services/performance/end_to_end_latency.py: ## @@ -87,7 +87,7 @@ def start_cmd(self, node): cmd = "export KAFKA_LOG4J_OPTS=\"-Dlog4j.co

[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1381690612 hi @mimaison , I added a few basic unit tests and updated the system test needs (end_to_end_latency.py). I haven't set it up locally but I am hoping those should run from here to val

[GitHub] [kafka] cadonna commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

cadonna commented on PR #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1381611825 @woja Thank you for your interest! You can find the cve list here: https://github.com/apache/kafka-site/blob/asf-site/cve-list.html Please also read the contribution guidel

[GitHub] [kafka] woja commented on pull request #11743: KAFKA-13660: Switch log4j12 to reload4j

woja commented on PR #11743: URL: https://github.com/apache/kafka/pull/11743#issuecomment-1381581124 I would be happy to have a go - but I cannot see where this part of the site is defined. It's not in the docs and a search shows nothing in this repo (or in fact any part of Apache org on gi

[jira] [Commented] (KAFKA-14606) Use virtual threads to publish Kafka records

[ https://issues.apache.org/jira/browse/KAFKA-14606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676547#comment-17676547 ] Alexandre Dupriez commented on KAFKA-14606: --- Got it. Thanks. > Use virtual th

[jira] [Comment Edited] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676546#comment-17676546 ] Alexandre Dupriez edited comment on KAFKA-14139 at 1/13/23 9:41 AM: --

[jira] [Comment Edited] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676546#comment-17676546 ] Alexandre Dupriez edited comment on KAFKA-14139 at 1/13/23 9:40 AM: --

[jira] [Comment Edited] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676546#comment-17676546 ] Alexandre Dupriez edited comment on KAFKA-14139 at 1/13/23 9:39 AM: --

[GitHub] [kafka] dajac opened a new pull request, #13110: KAFKA-14367; Add `partitionFor` to the new `GroupCoordinator` interface

dajac opened a new pull request, #13110: URL: https://github.com/apache/kafka/pull/13110 This patch adds `partitionFor ` to the new `GroupCoordinator` interface and updates `KafkaApis` to use it. ### Committer Checklist (excluded from commit message) - [ ] Verify design and impleme

[jira] [Commented] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676546#comment-17676546 ] Alexandre Dupriez commented on KAFKA-14139: --- Hi, Jason, thank you  for the ver

[GitHub] [kafka] dajac commented on pull request #12902: KAFKA-14367; Add `OffsetDelete` to the new `GroupCoordinator` interface

dajac commented on PR #12902: URL: https://github.com/apache/kafka/pull/12902#issuecomment-1381512820 cc @jolshan @jeffkbkim -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] dajac merged pull request #12901: KAFKA-14367; Add `TxnOffsetCommit` to the new `GroupCoordinator` interface

dajac merged PR #12901: URL: https://github.com/apache/kafka/pull/12901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] fvaleri commented on pull request #13085: KAFKA-14568: Move FetchDataInfo and related to storage module

fvaleri commented on PR #13085: URL: https://github.com/apache/kafka/pull/13085#issuecomment-1381478406 > I pushed a few clean-ups and it LGTM now. @fvaleri Are you good with them too? Yes, good. Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] drgnchan opened a new pull request, #13109: MINOR: doc: sendfile implement in `TransferableRecords` instead of `MessageSet`

drgnchan opened a new pull request, #13109: URL: https://github.com/apache/kafka/pull/13109 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin