cmccabe commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1382406862
Thanks very much for this, @rondagostino ! Anyway what I’d like to do here is two things: 1. split all the spelling corrections and docs changes into a separate PR which we can do today. They look like no-brainers 2. second PR do everything in Scala, see if that is cleaner. I think it will be. It would be better not to involve the core controller in this. we should be able to see which partition(s) were successfully created from ControllerServer (check the controller response) also we'll need a test. As you said, we need to get a bit of dynamic config code in first, but that is pretty small. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
