vamossagar12 commented on code in PR #13095:
URL: https://github.com/apache/kafka/pull/13095#discussion_r1069260140
##########
tests/kafkatest/services/performance/end_to_end_latency.py:
##########
@@ -87,7 +87,7 @@ def start_cmd(self, node):
cmd = "export KAFKA_LOG4J_OPTS=\"-Dlog4j.configuration=file:%s\"; " %
EndToEndLatencyService.LOG4J_CONFIG
if node.version.consumer_supports_bootstrap_server():
cmd += "KAFKA_OPTS=%(kafka_opts)s %(kafka_run_class)s
%(java_class_name)s " % args
- cmd += "%(bootstrap_servers)s %(topic)s %(num_records)d %(acks)d
%(message_bytes)d %(config_file)s" % args
+ cmd += "-b %(bootstrap_servers)s -t %(topic)s -n %(num_records)d
-a %(acks)d -s %(message_bytes)d -f %(config_file)s" % args
Review Comment:
This change and
https://github.com/apache/kafka/pull/13095/files#diff-1a3735187400a54aac5a802fb2d2ff6d4fe9cdfbc5fd953a45e2890ad43f58cfR157-R207
are needed because in argparse4j, if we are using positional arguments, then
from what I understood, they can't be made optional. Properties file is an
optional argument as per the scala code but it worked in that case as the main
arguments were used as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
