rondagostino commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1382580751
Thanks, Colin. I moved the minor stuff into https://github.com/apache/kafka/pull/13118 and put the check into `ControllerApis`. The only difference with what you suggested is that I consider the partitions requested (except for the ones with obvious issues like lack of authorization or duplicate topic names) rather than the partitions that the controller creates. When a quota is exceeded the request is not accepted, so we can't let the controller mutate the partition count and then decide -- we have to decide before letting the controller do its thing. Again, the create-topic only case is the only one I've done. I've added a test as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
