Re: [PR] SOLR-17678, SOLR-17732: Add matchScore support for ReRank queries [solr]

2025-04-04 Thread via GitHub
HoustonPutman commented on PR #3222: URL: https://github.com/apache/solr/pull/3222#issuecomment-2779569791 I'm planning on merging this early next week. Lots of tests to make sure everything works. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHitsAllowed per shard. [solr]

2025-04-04 Thread via GitHub
HoustonPutman commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2779573805 I'm planning on merging this early next week in case either of you have additional comments @dsmiley @gus-asf . I'm going to make a separate ticket and PR to remove the `terminat

Re: [PR] remove deprecated (DocValues,Norms)FieldExistsQuery use [solr]

2025-04-04 Thread via GitHub
github-actions[bot] commented on PR #2632: URL: https://github.com/apache/solr/pull/2632#issuecomment-2779919962 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam

[jira] [Updated] (SOLR-17726) CloudMLTQParser fails to use copyFields due to RealTimeGet

2025-04-04 Thread ilariapet (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ilariapet updated SOLR-17726: - Component/s: MoreLikeThis Affects Version/s: 9.8.1 Description: When using CloudMLTQP

[jira] [Updated] (SOLR-17725) Automatically upgrade Solr indexes without needing to reindex from source

2025-04-04 Thread Rahul Goswami (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Goswami updated SOLR-17725: - Description: Today upgrading from Solr version X to X+2 requires complete reingestion of data fr

[jira] [Updated] (SOLR-17707) HttpJdkSolrClient threads stuck on exceptions

2025-04-04 Thread Artem Abeleshev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Abeleshev updated SOLR-17707: --- Description: There is a problem with _HttpJdkSolrClient_ used by {_}SolrJ{_}. In case of exc

Re: [PR] SOLR-17655: Remove ExternalFileField [solr]

2025-04-04 Thread via GitHub
epugh merged PR #3244: URL: https://github.com/apache/solr/pull/3244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17683: Update test to reflect only one type of Currency Field in Solr. [solr]

2025-04-04 Thread via GitHub
HoustonPutman merged PR #3306: URL: https://github.com/apache/solr/pull/3306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

Re: [PR] SOLR-17724: adding a script on how to calculated the encoded password format [solr]

2025-04-04 Thread via GitHub
elangelo commented on PR #3162: URL: https://github.com/apache/solr/pull/3162#issuecomment-249239 > @elangelo would you be interestedin picking up @janhoy idea of tweaking the AuthTool to handle the encoding? I'd prefer not to add another bash based tool, and stick to Java... I'm

Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]

2025-04-04 Thread via GitHub
epugh commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2778002263 Going to need some help! I am getting this error: ``` 10746 ERROR (TEST-TestMinMaxOnMultiValuedField.testExpectedSortMissingOrderings-seed#[48FFD9DEBAEFAB26]) [n: c: s: r: x: t:] o.a.s.

Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]

2025-04-04 Thread via GitHub
epugh commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2778011765 Eric, don't forget to edit https://solr.apache.org/guide/solr/latest/indexing-guide/docvalues.html and remove `EnumField` -- This is an automated message from the Apache Git Service. To res

Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]

2025-04-04 Thread via GitHub
epugh commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2778017080 On re-reading refguide it appears that "SORTED_NUMERIC" is actually correct for the `EnumFieldType`. Not sure how to handle this test... Maybe the test assumed EnumField only? And

Re: [PR] SOLR-17718: Upgrade bytebuddy to 1.17.4 [solr]

2025-04-04 Thread via GitHub
HoustonPutman merged PR #3286: URL: https://github.com/apache/solr/pull/3286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

Re: [PR] SOLR-17617: Add smoke test for V2 API and fix up problems [solr]

2025-04-04 Thread via GitHub
colvinco commented on code in PR #3023: URL: https://github.com/apache/solr/pull/3023#discussion_r2029046624 ## solr/core/src/test/org/apache/solr/handler/admin/api/V2APISmokeTest.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[jira] [Created] (SOLR-17728) Create a smoke test for the v2 API

2025-04-04 Thread Colvin Cowie (Jira)
Colvin Cowie created SOLR-17728: --- Summary: Create a smoke test for the v2 API Key: SOLR-17728 URL: https://issues.apache.org/jira/browse/SOLR-17728 Project: Solr Issue Type: Test Security

[PR] Update mockito to v5.17.0 [solr]

2025-04-04 Thread via GitHub
solrbot opened a new pull request, #3309: URL: https://github.com/apache/solr/pull/3309 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.mockito:mockito-subclass](https://redirect.github.com/mockito/mockito) | dependencies |

Re: [PR] Jetty12 + EE10 [solr]

2025-04-04 Thread via GitHub
dsmiley commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2777480066 > ServletApiRequest.getRequest() will return a non-null value once the request crosses an async boundary (e.g., background threads, ExecutorService, etc.) This wasn't clear to me so I

[jira] [Created] (SOLR-17729) Some endpoints are missing from the v2 API spec

2025-04-04 Thread Colvin Cowie (Jira)
Colvin Cowie created SOLR-17729: --- Summary: Some endpoints are missing from the v2 API spec Key: SOLR-17729 URL: https://issues.apache.org/jira/browse/SOLR-17729 Project: Solr Issue Type: Improv

[jira] [Commented] (SOLR-17458) Metrics: switch from DropWizard to OpenTelemetry

2025-04-04 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940984#comment-17940984 ] Matthew Biscocho commented on SOLR-17458: - So the /metrics endpoint becomes prome

Re: [PR] SOLR-17617: Add smoke test for V2 API and fix up problems [solr]

2025-04-04 Thread via GitHub
colvinco commented on PR #3023: URL: https://github.com/apache/solr/pull/3023#issuecomment-2779015426 Thanks for the feedback @gerlowskija. Okay yep lets get something in and iterate on the rest of it. I will do a bit of cleanup, raise some issues under [SOLR-15734](https://issues.apache

[jira] [Created] (SOLR-17730) v2 API error handling

2025-04-04 Thread Colvin Cowie (Jira)
Colvin Cowie created SOLR-17730: --- Summary: v2 API error handling Key: SOLR-17730 URL: https://issues.apache.org/jira/browse/SOLR-17730 Project: Solr Issue Type: Improvement Reporter

Re: [PR] SOLR-17698: Remove deprecated EnumField [solr]

2025-04-04 Thread via GitHub
dsmiley commented on PR #3256: URL: https://github.com/apache/solr/pull/3256#issuecomment-2778648557 Fixed it. You replaced org.apache.solr.schema.EnumFieldType#getSortField with that of the base class. If you remove an intermediate class in the hierarchy inline to a subclass, don't repla

Re: [PR] SOLR-17432: Allow OTel Java Agent [solr]

2025-04-04 Thread via GitHub
dsmiley commented on PR #2687: URL: https://github.com/apache/solr/pull/2687#issuecomment-2778987448 I very much want to get back to this for Solr 10... need to maybe reformulate what's happening into multiple things. CC @mlbiscoc -- This is an automated message from the Apache Git Se

[jira] [Updated] (SOLR-17432) Enable use of OTEL Agent

2025-04-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17432: Fix Version/s: main (10.0) Priority: Blocker (was: Major) > Enable use of OTEL Agent > --

[jira] [Created] (SOLR-17731) Some v2 APIs are overshadowed at runtime so can't be used

2025-04-04 Thread Colvin Cowie (Jira)
Colvin Cowie created SOLR-17731: --- Summary: Some v2 APIs are overshadowed at runtime so can't be used Key: SOLR-17731 URL: https://issues.apache.org/jira/browse/SOLR-17731 Project: Solr Issue Ty

[jira] [Updated] (SOLR-17731) Some v2 APIs are overshadowed at runtime so can't be used

2025-04-04 Thread Colvin Cowie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colvin Cowie updated SOLR-17731: Issue Type: Bug (was: Improvement) > Some v2 APIs are overshadowed at runtime so can't be used > -

[jira] [Created] (SOLR-17732) Improve score returning logic for distributed requests

2025-04-04 Thread Houston Putman (Jira)
Houston Putman created SOLR-17732: - Summary: Improve score returning logic for distributed requests Key: SOLR-17732 URL: https://issues.apache.org/jira/browse/SOLR-17732 Project: Solr Issue T

Re: [PR] SOLR-17432: Allow OTel Java Agent [solr]

2025-04-04 Thread via GitHub
mlbiscoc commented on code in PR #2687: URL: https://github.com/apache/solr/pull/2687#discussion_r2029138937 ## solr/core/src/java/org/apache/solr/core/TracerConfigurator.java: ## @@ -38,33 +41,53 @@ public abstract class TracerConfigurator implements NamedListInitializedPlugin

Re: [PR] SOLR-17678, SOLR-17732: Add matchScore support for ReRank queries [solr]

2025-04-04 Thread via GitHub
HoustonPutman commented on PR #3222: URL: https://github.com/apache/solr/pull/3222#issuecomment-2779275057 I've added https://issues.apache.org/jira/browse/SOLR-17732 to account for the relatively big code change to support distributed score fields. -- This is an automated message from th

[jira] [Created] (SOLR-17733) Cluster filestore v2 API fails in cloud mode

2025-04-04 Thread Colvin Cowie (Jira)
Colvin Cowie created SOLR-17733: --- Summary: Cluster filestore v2 API fails in cloud mode Key: SOLR-17733 URL: https://issues.apache.org/jira/browse/SOLR-17733 Project: Solr Issue Type: Bug

[jira] [Comment Edited] (SOLR-17458) Metrics: switch from DropWizard to OpenTelemetry

2025-04-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941031#comment-17941031 ] Andrzej Bialecki edited comment on SOLR-17458 at 4/4/25 4:57 PM: --

[jira] [Commented] (SOLR-17725) Automatically upgrade Solr indexes without needing to reindex from source

2025-04-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941033#comment-17941033 ] Andrzej Bialecki commented on SOLR-17725: - The already existing {{REINDEXCOLLECTI

Re: [PR] SOLR-17728: Add smoke test for V2 API [solr]

2025-04-04 Thread via GitHub
colvinco commented on PR #3023: URL: https://github.com/apache/solr/pull/3023#issuecomment-2779314827 Messed up a merge there, so there's a bit of noise sorry. @gerlowskija I think that the status of the tests is roughly: - Good to go - testNodesApi() - testConfigSetsA

[jira] [Updated] (SOLR-17728) Create a smoke test for the v2 API

2025-04-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17728: -- Labels: pull-request-available (was: ) > Create a smoke test for the v2 API >

Re: [PR] SOLR-17703: BinaryResponseParser and BinaryRequestWriter rename to JavaBin... [solr]

2025-04-04 Thread via GitHub
abumarjikar commented on code in PR #3307: URL: https://github.com/apache/solr/pull/3307#discussion_r2027067989 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/JavaBinResponseParser.java: ## @@ -27,13 +27,13 @@ /** * @since solr 1.3 */ -public class BinaryResponseP

Re: [PR] SOLR-17703: BinaryResponseParser and BinaryRequestWriter rename to JavaBin... [solr]

2025-04-04 Thread via GitHub
dsmiley commented on code in PR #3307: URL: https://github.com/apache/solr/pull/3307#discussion_r2027052351 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/JavaBinResponseParser.java: ## @@ -27,13 +27,13 @@ /** * @since solr 1.3 */ -public class BinaryResponseParse

Re: [PR] SOLR-17584: Remove code and documentation for "trusted" configsets [solr]

2025-04-04 Thread via GitHub
abumarjikar commented on PR #3272: URL: https://github.com/apache/solr/pull/3272#issuecomment-2749127357 @dsmiley Changes made in major changes doc file. Please review. @gerlowskija and @epugh Please review the PR. -- This is an automated message from the Apache Git Service. To respond

[jira] [Created] (SOLR-17726) CloudMLTQParser fails to use copyFields due to RealTimeGet

2025-04-04 Thread ilariapet (Jira)
ilariapet created SOLR-17726: Summary: CloudMLTQParser fails to use copyFields due to RealTimeGet Key: SOLR-17726 URL: https://issues.apache.org/jira/browse/SOLR-17726 Project: Solr Issue Type: B

Re: [PR] SOLR-17703: BinaryResponseParser and BinaryRequestWriter rename to JavaBin... [solr]

2025-04-04 Thread via GitHub
abumarjikar commented on PR #3307: URL: https://github.com/apache/solr/pull/3307#issuecomment-2779487086 @dsmiley Ready with your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] SOLR-17705 SolrRequest's type is now unbounded [solr]

2025-04-04 Thread via GitHub
dsmiley commented on PR #3270: URL: https://github.com/apache/solr/pull/3270#issuecomment-2744535206 NP :-). I observed some colleagues at work do a self-review right after posting a PR, and I appreciated it so much (as a reviewer) that I try to do the same for PRs I author for anything non

[PR] SOLR-17724: clarify basic auth credential docs [solr]

2025-04-04 Thread via GitHub
epugh opened a new pull request, #3301: URL: https://github.com/apache/solr/pull/3301 https://issues.apache.org/jira/browse/SOLR-17724 10x only # Description Please provide a short description of the changes you're making with this pull request. # Solu

Re: [PR] SOLR-17705 SolrRequest's type is now unbounded [solr]

2025-04-04 Thread via GitHub
dsmiley commented on PR #3270: URL: https://github.com/apache/solr/pull/3270#issuecomment-2741398533 I'm not going to delay the V2 work that will use this; I could even start a branch off of this one to show the work. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] SOLR-17703: BinaryResponseParser and BinaryRequestWriter rename to JavaBin... [solr]

2025-04-04 Thread via GitHub
dsmiley merged PR #3307: URL: https://github.com/apache/solr/pull/3307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17458) Metrics: switch from DropWizard to OpenTelemetry

2025-04-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941031#comment-17941031 ] Andrzej Bialecki commented on SOLR-17458: - This is going to be a lot of work, ind

Re: [PR] Configure operator logging in helm chart [solr-operator]

2025-04-04 Thread via GitHub
gerlowskija commented on code in PR #779: URL: https://github.com/apache/solr-operator/pull/779#discussion_r2027279783 ## helm/solr-operator/Chart.yaml: ## @@ -55,6 +55,11 @@ annotations: # Allowed syntax is described at: https://artifacthub.io/docs/topics/annotations/helm/#

Re: [PR] SOLR-17707 HttpJdkSolrClient handle exceptions [solr]

2025-04-04 Thread via GitHub
HoustonPutman commented on code in PR #3273: URL: https://github.com/apache/solr/pull/3273#discussion_r2004243474 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java: ## @@ -294,15 +294,16 @@ private PreparedRequest preparePutOrPost( final Pipe

[jira] [Commented] (SOLR-17692) DELETEREPLICA should preempt full-recovery instead of waiting for completion

2025-04-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940360#comment-17940360 ] ASF subversion and git services commented on SOLR-17692: Commit e

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-04 Thread via GitHub
dsmiley commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r2006610968 ## solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java: ## @@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) { this.queryParams = queryPa

[jira] [Commented] (SOLR-17651) Obfuscate System.exit(), remove direct usage

2025-04-04 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941064#comment-17941064 ] Houston Putman commented on SOLR-17651: --- [~psalagnac] can this be closed? > Obfusc

[jira] [Commented] (SOLR-17703) BinaryResponseParser and BinaryRequestWriter rename to "JavaBin..."

2025-04-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941062#comment-17941062 ] ASF subversion and git services commented on SOLR-17703: Commit e

[jira] [Commented] (SOLR-17655) Deprecate ExternalFileField in lieu of in-place docValue updates

2025-04-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940267#comment-17940267 ] ASF subversion and git services commented on SOLR-17655: Commit 3

[jira] [Commented] (SOLR-17584) Remove code and documentation for "trusted"configsets

2025-04-04 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936472#comment-17936472 ] Sanjay Dutt commented on SOLR-17584: As per the documentation: {quote}A configset is

[I] security.json not created in zookeeper [solr-operator]

2025-04-04 Thread via GitHub
RangaSamudrala opened a new issue, #780: URL: https://github.com/apache/solr-operator/issues/780 Problem is similar to one reported in https://github.com/apache/solr-operator/issues/720 I tried install Solr Operator and Solr Cloud from scratch. ```yaml # secrets apiVersio

Re: [PR] SOLR-17701: Strip out AUTH_PORT in favour of SOLR_PORT [solr]

2025-04-04 Thread via GitHub
epugh commented on code in PR #3265: URL: https://github.com/apache/solr/pull/3265#discussion_r2024161553 ## solr/CHANGES.txt: ## @@ -39,6 +39,8 @@ Improvements * SOLR-17685: Simplify bin/solr scripts by no longer SOLR_TOOL_HOST variable in favour of existing SOLR_HOST ENV v

[jira] [Resolved] (SOLR-17703) BinaryResponseParser and BinaryRequestWriter rename to "JavaBin..."

2025-04-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17703. - Fix Version/s: main (10.0) Resolution: Fixed > BinaryResponseParser and BinaryRequestWrite

[jira] [Created] (SOLR-17734) Remove segmentTerminateEarly as the functionality is already supported by minExactCount

2025-04-04 Thread Houston Putman (Jira)
Houston Putman created SOLR-17734: - Summary: Remove segmentTerminateEarly as the functionality is already supported by minExactCount Key: SOLR-17734 URL: https://issues.apache.org/jira/browse/SOLR-17734

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHitsAllowed per shard. [solr]

2025-04-04 Thread via GitHub
HoustonPutman commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2779692896 > Your changes since my last review are nice/simple. I'm not sure how to resolve maybe differing views on what should be consolidated or removed, but happy to defer to your judgement H

[jira] [Resolved] (SOLR-3886) CurrencyField support for * search and JavaDocs fixes

2025-04-04 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-3886. - Resolution: Won't Fix SOLR-17683 removes CurrencyField in favour of CurrencyFieldType.  If this ticket is